Skip to contentSkip to conversation

selftests: rtc: Increase test timeout so that all tests run

PATCH In review Nícolas F. R. A. Prado 3 participants 4 messages Jan 12, 2022 – Jan 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests: rtc: Increase test timeout so that all tests run

The timeout setting for the rtc kselftest is currently 90 seconds. This setting is used by the kselftest runner to stop running a test if it takes longer than the assigned value.

However, two of the test cases inside rtc set alarms. These alarms are set to the next beginning of the minute, so each of these test cases may take up to, in the worst case, 60 seconds.

In order to allow for all test cases in rtc to run, even in the worst case, when using the kselftest runner, the timeout value should be increased to at least 120. Set it to 180, so there's some additional slack.

Correct operation can be tested by running the following command right after the start of a minute (low second count), and checking that all test cases run:

./run_kselftest.sh -c rtc

---

Changes in v2:
- Expanded commit message to make the issue, and how to test the fix, clearer

v1: https://lore.kernel.org/all/[email protected]/

 tools/testing/selftests/rtc/settings | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/rtc/settings +1 -1
index ba4d85f74cd6..a953c96aa16e 100644
@@ -1 +1 @@
-timeout=90
+timeout=180
Signature · 1 line
2.34.1
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 13 lines · Nícolas F. R. A. Prado

The timeout setting for the rtc kselftest is currently 90 seconds. This setting is used by the kselftest runner to stop running a test if it takes longer than the assigned value.

However, two of the test cases inside rtc set alarms. These alarms are set to the next beginning of the minute, so each of these test cases may take up to, in the worst case, 60 seconds.

In order to allow for all test cases in rtc to run, even in the worst case, when using the kselftest runner, the timeout value should be increased to at least 120. Set it to 180, so there's some additional slack.

Quoted 7 lines

Correct operation can be tested by running the following command right after the start of a minute (low second count), and checking that all test cases run:

./run_kselftest.sh -c rtc

Quoted 20 lines

---

Changes in v2:
- Expanded commit message to make the issue, and how to test the fix, clearer

v1: https://lore.kernel.org/all/[email protected]/

 tools/testing/selftests/rtc/settings | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/rtc/settings +1 -1
index ba4d85f74cd6..a953c96aa16e 100644
@@ -1 +1 @@
-timeout=90
+timeout=180
Signature · 1 line
2.34.1
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#2 lore raw
Quoted 14 lines · Alexandre Belloni
Quoted 13 lines · Nícolas F. R. A. Prado

The timeout setting for the rtc kselftest is currently 90 seconds. This setting is used by the kselftest runner to stop running a test if it takes longer than the assigned value.

However, two of the test cases inside rtc set alarms. These alarms are set to the next beginning of the minute, so each of these test cases may take up to, in the worst case, 60 seconds.

In order to allow for all test cases in rtc to run, even in the worst case, when using the kselftest runner, the timeout value should be increased to at least 120. Set it to 180, so there's some additional slack.

Quoted 8 lines
Quoted 7 lines

Correct operation can be tested by running the following command right after the start of a minute (low second count), and checking that all test cases run:

./run_kselftest.sh -c rtc

Thank you both. Will apply this for 5.17-rc2 once the merge window closes.

thanks,
-- Shuah

maintainer
#3 lore raw
Quoted 19 lines · Shuah Khan
Quoted 18 lines · Alexandre Belloni
Quoted 17 lines · Nícolas F. R. A. Prado

The timeout setting for the rtc kselftest is currently 90 seconds. This setting is used by the kselftest runner to stop running a test if it takes longer than the assigned value.

However, two of the test cases inside rtc set alarms. These alarms are set to the next beginning of the minute, so each of these test cases may take up to, in the worst case, 60 seconds.

In order to allow for all test cases in rtc to run, even in the worst case, when using the kselftest runner, the timeout value should be increased to at least 120. Set it to 180, so there's some additional slack.

Correct operation can be tested by running the following command right after the start of a minute (low second count), and checking that all test cases run:

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

    ./run_kselftest.sh -c rtc

Thank you both. Will apply this for 5.17-rc2 once the merge window closes.

Applied to linux-kselftest fixes branch for rc2/rc3

thanks,
-- Shuah