Skip to contentSkip to conversation

pps: clients: gpio: Propagate return value from pps_gpio_probe

PATCH In review Robert Hancock 4 participants 8 messages Jan 12, 2022 – Feb 4, 2022 PPS support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pps: clients: gpio: Propagate return value from pps_gpio_probe

If the pps-gpio driver was probed prior to the GPIO device it uses, the devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that deferred probe works properly.

Fixes 161520451dfa (pps: new client driver using GPIO)
---
 drivers/pps/clients/pps-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pps/clients/pps-gpio.c +1 -1
index 35799e6401c9..2f4b11b4dfcd 100644
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */
 	ret = gpiod_to_irq(data->gpio_pin);
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that deferred probe works properly.

FWIW,

Quoted 22 lines
Fixes 161520451dfa (pps: new client driver using GPIO)
---
 drivers/pps/clients/pps-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pps/clients/pps-gpio.c +1 -1
index 35799e6401c9..2f4b11b4dfcd 100644
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */
 	ret = gpiod_to_irq(data->gpio_pin);
Signature · 1 line
2.31.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Acked-by
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that deferred probe works properly.

FWIW,

Quoted 24 lines
Quoted 23 lines
Fixes 161520451dfa (pps: new client driver using GPIO)
---
 drivers/pps/clients/pps-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pps/clients/pps-gpio.c +1 -1
index 35799e6401c9..2f4b11b4dfcd 100644
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */
 	ret = gpiod_to_irq(data->gpio_pin);
Signature · 1 line
2.31.1
Signature · 4 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
#3 lore raw
Quoted 8 lines · Rodolfo Giometti
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that deferred probe works properly.

Quoted 4 lines
Quoted 2 lines

FWIW,

It's not entirely clear to me what tree PPS patches are supposed to go through. Seems like some recent ones have gone through char-misc? Not sure if someone has this in their queue?

Quoted 26 lines
Quoted 24 lines
Quoted 24 lines
Fixes 161520451dfa (pps: new client driver using GPIO)
---
 drivers/pps/clients/pps-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pps/clients/pps- renamed from drivers/pps/clients/pps-gpio.c +0 -0

gpio.c
index 35799e6401c9..2f4b11b4dfcd 100644

drivers/pps/clients/pps-gpio.c +1 -1
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device
 *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */

ret = gpiod_to_irq(data->gpio_pin);

Signature · 1 line
2.31.1
Signature · 3 lines
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com
maintainer
#4 lore raw
Quoted 9 lines · Robert Hancock
Quoted 8 lines · Rodolfo Giometti
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that deferred probe works properly.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

FWIW,

It's not entirely clear to me what tree PPS patches are supposed to go through. Seems like some recent ones have gone through char-misc? Not sure if someone has this in their queue?

LinuxPPS has no its own tree. All related patches usually are sent to me to be acked and to Greg Kroah-Hartman for inclusion.

Ciao,

Rodolfo

Signature · 4 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
#5 lore raw
Quoted 24 lines · Rodolfo Giometti
Quoted 15 lines · Robert Hancock
Quoted 14 lines · Rodolfo Giometti
Quoted 12 lines · Andy Shevchenko
Quoted 8 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the
devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that
deferred probe works properly.

FWIW,

Quoted 7 lines
Quoted 1 line

It's not entirely clear to me what tree PPS patches are supposed to go through.
Seems like some recent ones have gone through char-misc? Not sure if someone
has this in their queue?

Quoted 8 lines

LinuxPPS has no its own tree. All related patches usually are sent to me to be
acked and to Greg Kroah-Hartman for inclusion.

Ciao,

Rodolfo

It looks like some MAINTAINERS links should maybe be updated for PPS - the referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to be dead. There is http://linuxpps.org/doku.php which points to a new mailing list location as well, but that seems to have very little activity.

Greg, can you pick this patch ( https://lkml.org/lkml/2022/1/12/879 ) up?

Signature · 3 lines
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com
maintainer
#6 lore raw
Quoted 31 lines · Robert Hancock
Quoted 30 lines · Rodolfo Giometti
Quoted 15 lines · Robert Hancock
Quoted 14 lines · Rodolfo Giometti
Quoted 12 lines · Andy Shevchenko
Quoted 8 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the
devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that
deferred probe works properly.

FWIW,

Quoted 7 lines
Quoted 1 line

It's not entirely clear to me what tree PPS patches are supposed to go through.
Seems like some recent ones have gone through char-misc? Not sure if someone
has this in their queue?

LinuxPPS has no its own tree. All related patches usually are sent to me to be
acked and to Greg Kroah-Hartman for inclusion.

Ciao,

Quoted 7 lines
Quoted 2 lines

Rodolfo

It looks like some MAINTAINERS links should maybe be updated for PPS - the referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to be dead. There is http://linuxpps.org/doku.php which points to a new mailing list location as well,

Yeah. Attached is a patch to fix these.

Quoted 1 line

but that seems to have very little activity.

That's one of reasons why LunuxPPS doesn't have its own tree. :)

Ciao,

Rodolfo

Signature · 4 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti

From ab95f9b0dcbd538eb43e09eb358c782404ddf024 Mon Sep 17 00:00:00 2001
From: Rodolfo Giometti <[email protected]>
Date: Wed, 2 Feb 2022 18:37:20 +0100
Subject: [PATCH] MAINTAINERS: update LinuxPPS's resources

---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
index f41088418aae..9176ba3093b7 100644
@@ -15490,9 +15490,9 @@ F:	drivers/net/ppp/ppp_*
 
 PPS SUPPORT
 M:	Rodolfo Giometti <[email protected]>
-L:	[email protected] (subscribers-only)
+L:	[email protected] (subscribers-only)
 S:	Maintained
-W:	http://wiki.enneenne.com/index.php/LinuxPPS_support
+W:	http://linuxpps.org/doku.php
 F:	Documentation/ABI/testing/sysfs-pps
 F:	Documentation/devicetree/bindings/pps/pps-gpio.txt
 F:	Documentation/driver-api/pps.rst
Signature · 1 line
2.25.1
#7 lore raw
In reply to Robert Hancock
Quoted 34 lines · Robert Hancock
Quoted 24 lines · Rodolfo Giometti
Quoted 15 lines · Robert Hancock
Quoted 14 lines · Rodolfo Giometti
Quoted 12 lines · Andy Shevchenko
Quoted 8 lines · Robert Hancock

If the pps-gpio driver was probed prior to the GPIO device it uses, the
devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
replaced that error code with -EINVAL, causing the pps-gpio probe to fail and not be retried later. Propagate the error return value so that
deferred probe works properly.

FWIW,

Quoted 7 lines
Quoted 1 line

It's not entirely clear to me what tree PPS patches are supposed to go through.
Seems like some recent ones have gone through char-misc? Not sure if someone
has this in their queue?

Quoted 8 lines

LinuxPPS has no its own tree. All related patches usually are sent to me to be
acked and to Greg Kroah-Hartman for inclusion.

Ciao,

Rodolfo

Quoted 6 lines

It looks like some MAINTAINERS links should maybe be updated for PPS - the referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to be dead. There is http://linuxpps.org/doku.php which points to a new mailing list location as well, but that seems to have very little activity.

Greg, can you pick this patch ( https://lkml.org/lkml/2022/1/12/879 ) up?

Please use lore.kernel.org, lkml.org does not work with our tools, nor do we have any control over it.

thanks,

greg k-h