Skip to contentSkip to conversation

RDMA/rxe: Remove the unused variable

PATCH Applied [email protected] 3 participants 3 messages Dec 15, 2021 – Jan 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/rxe: Remove the unused variable

From: Zhu Yanjun <[email protected]>

The member variable xmit_errors can be replaced with rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So remove it.

---
 drivers/infiniband/sw/rxe/rxe_net.c   | 1 -
 drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
 2 files changed, 3 deletions(-)
drivers/infiniband/sw/rxe/rxe_net.c +0 -1
index 2cb810cb890a..112506c31b37 100644
@@ -444,7 +444,6 @@ int rxe_xmit_packet(struct rxe_qp *qp, struct rxe_pkt_info *pkt,
 	else
 		err = rxe_send(skb, pkt);
 	if (err) {
-		rxe->xmit_errors++;
 		rxe_counter_inc(rxe, RXE_CNT_SEND_ERR);
 		return err;
 	}
drivers/infiniband/sw/rxe/rxe_verbs.h +0 -2
index 35e041450090..af0117710175 100644
@@ -392,8 +392,6 @@ struct rxe_dev {
 
 	struct net_device	*ndev;
 
-	int			xmit_errors;
-
 	struct rxe_pool		uc_pool;
 	struct rxe_pool		pd_pool;
 	struct rxe_pool		ah_pool;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Thu, Dec 16, 2021 at 12:48:42AM -0500, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

The member variable xmit_errors can be replaced with rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So remove it.

Quoted 6 lines
---
 drivers/infiniband/sw/rxe/rxe_net.c   | 1 -
 drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
 2 files changed, 3 deletions(-)

Thanks,

maintainer Applied
#2 lore raw
In reply to [email protected]
Quoted 6 lines · On Thu, Dec 16, 2021 at 12:48:42AM -0500, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

The member variable xmit_errors can be replaced with rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So remove it.

Quoted 6 lines
---
 drivers/infiniband/sw/rxe/rxe_net.c   | 1 -
 drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
 2 files changed, 3 deletions(-)

Applied to for-next, thanks

Jason