Skip to contentSkip to conversation

dmaengine: ioatdma: use default_groups in kobj_type

PATCH Applied Greg Kroah-Hartman 3 participants 3 messages Jan 4, 2022 – Jan 5, 2022 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: ioatdma: use default_groups in kobj_type

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the ioatdma sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.

---
 drivers/dma/ioat/sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/ioat/sysfs.c +2 -1
index aa44bcd6a356..168adf28c5b1 100644
@@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
 	&intr_coalesce_attr.attr,
 	NULL,
 };
+ATTRIBUTE_GROUPS(ioat);
 
 struct kobj_type ioat_ktype = {
 	.sysfs_ops = &ioat_sysfs_ops,
-	.default_attrs = ioat_attrs,
+	.default_groups = ioat_groups,
 };
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Greg Kroah-Hartman

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the ioatdma sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.

Quoted 19 lines
---
  drivers/dma/ioat/sysfs.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/ioat/sysfs.c +2 -1
index aa44bcd6a356..168adf28c5b1 100644
@@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
  	&intr_coalesce_attr.attr,
  	NULL,
  };
+ATTRIBUTE_GROUPS(ioat);
 
  struct kobj_type ioat_ktype = {
  	.sysfs_ops = &ioat_sysfs_ops,
-	.default_attrs = ioat_attrs,
+	.default_groups = ioat_groups,
  };
maintainer Applied
#2 lore raw
In reply to Greg Kroah-Hartman
Quoted 6 lines · Greg Kroah-Hartman

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the ioatdma sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.

Applied, thanks

Signature · 1 line
~Vinod