net: dsa|ethernet: use bool values to pass bool param of phy_init_eee
Subsystems (11)
PATCH 1/1 net: dsa|ethernet: use bool values to pass bool param of phy_init_eee
The 2nd param of phy_init_eee(): clk_stop_enable is a bool param, use true or false instead of 1/0.
--- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mt7530.c | 2 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- drivers/net/ethernet/freescale/fec_main.c | 2 +- drivers/net/ethernet/marvell/mvneta.c | 2 +- drivers/net/ethernet/microchip/lan743x_ethtool.c | 2 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
drivers/net/dsa/b53/b53_common.c +1 -1
@@ -2186,7 +2186,7 @@ int b53_eee_init(struct dsa_switch *ds, int port, struct phy_device *phy) {int ret; - ret =phy_init_eee (phy,0 ); + ret =phy_init_eee (phy, false);if (ret)return 0 ;
drivers/net/dsa/mt7530.c +1 -1
@@ -2846,7 +2846,7 @@ static void mt753x_phylink_mac_link_up(struct dsa_switch *ds, int port, mcr |=PMCR_RX_FC_EN ; } -if (mode ==MLO_AN_PHY && phydev &&phy_init_eee (phydev,0 ) >=0 ) { +if (mode ==MLO_AN_PHY && phydev &&phy_init_eee (phydev, false) >=0 ) {switch (speed) {case SPEED_1000 : mcr |=PMCR_FORCE_EEE1G ;
drivers/net/ethernet/broadcom/genet/bcmgenet.c +1 -1
@@ -1368,7 +1368,7 @@ static int bcmgenet_set_eee(struct net_device *dev, struct ethtool_eee *e)if (!p->eee_enabled) {bcmgenet_eee_enable_set (dev, false); }else { - ret =phy_init_eee (dev->phydev,0 ); + ret =phy_init_eee (dev->phydev, false);if (ret) {netif_err (priv, hw, dev,"EEE initialization failed\n" );return ret;
drivers/net/ethernet/freescale/fec_main.c +1 -1
@@ -2797,7 +2797,7 @@ static int fec_enet_eee_mode_set(struct net_device *ndev, bool enable)int ret =0 ;if (enable) { - ret =phy_init_eee (ndev->phydev,0 ); + ret =phy_init_eee (ndev->phydev, false);if (ret)return ret;
drivers/net/ethernet/marvell/mvneta.c +1 -1
@@ -4169,7 +4169,7 @@ static void mvneta_mac_link_up(struct phylink_config *config,mvneta_port_up (pp);if (phy && pp->eee_enabled) { - pp->eee_active =phy_init_eee (phy,0 ) >=0 ; + pp->eee_active =phy_init_eee (phy, false) >=0 ;mvneta_set_eee (pp, pp->eee_active && pp->tx_lpi_enabled); } }
drivers/net/ethernet/microchip/lan743x_ethtool.c +1 -1
@@ -750,7 +750,7 @@ static int lan743x_ethtool_set_eee(struct net_device *netdev, }if (eee->eee_enabled) { - ret =phy_init_eee (phydev,0 ); + ret =phy_init_eee (phydev, false);if (ret) {netif_err (adapter, drv, adapter->netdev,"EEE initialization failed\n" );
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +1 -1
@@ -127,7 +127,7 @@ bool sxgbe_eee_init(struct sxgbe_priv_data * const priv)/* MAC core supports the EEE feature. */ if (priv->hw_cap.eee) {/* Check if the PHY supports EEE */ -if (phy_init_eee (ndev->phydev,1 )) +if (phy_init_eee (ndev->phydev, true))return false; priv->eee_active =1 ;
Signature · 1 line
2.34.1
Quoted 4 lines · Jisheng Zhang
The 2nd param of
phy_init_eee():clk_stop_enableis a bool param, use true or false instead of 1/0.Signed-off-by Jisheng Zhang <[email protected]>
Andrew
Quoted 4 lines · Jisheng Zhang
The 2nd param of
phy_init_eee():clk_stop_enableis a bool param, use true or false instead of 1/0.Signed-off-by Jisheng Zhang <[email protected]>
Nit: for future changes, if your patch spans multiple subsystems/directories, just go with the top-most subject prefix, for instance here "net: " would have been sufficient. Thanks!
Signature · 1 line
Florian
Quoted 4 lines · On Sun, 23 Jan 2022 23:22:41 +0800 Jisheng Zhang wrote:
The 2nd param of
phy_init_eee():clk_stop_enableis a bool param, use true or false instead of 1/0.Signed-off-by Jisheng Zhang <[email protected]>
Applied, thanks!
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek