Skip to contentSkip to conversation

arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL

PATCH Applied Masami Hiramatsu 3 participants 3 messages Jan 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL

Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL because this function is called from ftrace and lockdep to get the caller address via return_address(). The lockdep is used in kprobes, it should also be NOKPROBE_SYMBOL.

Fixes b07f3499661c ("arm64: stacktrace: Move start_backtrace() out of the header")
---
 arch/arm64/kernel/stacktrace.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/kernel/stacktrace.c +2 -1
index 94f83cd44e50..b0f21677764d 100644
@@ -33,7 +33,7 @@
  */
 
 
-void start_backtrace(struct stackframe *frame, unsigned long fp,
+void notrace start_backtrace(struct stackframe *frame, unsigned long fp,
 		     unsigned long pc)
 {
 	frame->fp = fp;
@@ -55,6 +55,7 @@ void start_backtrace(struct stackframe *frame, unsigned long fp,
 	frame->prev_fp = 0;
 	frame->prev_type = STACK_TYPE_UNKNOWN;
 }
+NOKPROBE_SYMBOL(start_backtrace);
 
 /*
  * Unwind from one frame record (A) to the next frame record (B).
#1 lore raw
Quoted 4 lines · Masami Hiramatsu

Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL because this function is called from ftrace and lockdep to get the caller address via return_address(). The lockdep is used in kprobes, it should also be NOKPROBE_SYMBOL.

maintainer Applied
#2 lore raw
In reply to Masami Hiramatsu
Quoted 4 lines · Masami Hiramatsu

Mark the start_backtrace() as notrace and NOKPROBE_SYMBOL because this function is called from ftrace and lockdep to get the caller address via return_address(). The lockdep is used in kprobes, it should also be NOKPROBE_SYMBOL.

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL

      https://git.kernel.org/arm64/c/1e0924bd0991
Signature · 1 line
Catalin