move shared mac code in mt76_connac module
Subsystems (3)
Lorenzo Bianconi
maintainercover move shared mac code in mt76_connac module
Move mac code shared between mt7921 and mt7915 drivers in mt76_connac_mac.c and remove duplicated code.
Lorenzo Bianconi (5):
mt76: connac: move mt76_connac_lmac_mapping in mt76-connac module
mt76: connac: move common mac defs in mt76_connac_mac.h
mt76: connac: move mt76_connac_reverse_frag0_hdr_trans in common
module
mt76: connac: move he radiotap parsing in connac module
mt76: connac: move mt76_connac_mac_write_txwi in connac module
.../net/wireless/mediatek/mt76/mt76_connac.h | 14 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 362 ++++++++++++++++ .../wireless/mediatek/mt76/mt76_connac_mac.h | 296 +++++++++++++ .../net/wireless/mediatek/mt76/mt7915/mac.c | 396 +---------------- .../net/wireless/mediatek/mt76/mt7915/mac.h | 279 +----------- .../net/wireless/mediatek/mt76/mt7915/main.c | 3 +- .../wireless/mediatek/mt76/mt7915/mt7915.h | 6 - .../wireless/mediatek/mt76/mt7915/testmode.c | 2 +- .../net/wireless/mediatek/mt76/mt7921/mac.c | 398 +----------------- .../net/wireless/mediatek/mt76/mt7921/mac.h | 293 +------------ .../net/wireless/mediatek/mt76/mt7921/main.c | 3 +- .../wireless/mediatek/mt76/mt7921/mt7921.h | 6 - 12 files changed, 717 insertions(+), 1341 deletions(-) create mode 100644 drivers/net/wireless/mediatek/mt76/mt76_connac_mac.h
Signature · 1 line
2.34.1
Lorenzo Bianconi
maintainerPATCH 1/5 mt76: connac: move mt76_connac_lmac_mapping in mt76-connac module
mt76_connac_lmac_mapping is shared between mt7921 and mt7915
--- drivers/net/wireless/mediatek/mt76/mt76_connac.h | 6 ++++++ drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7915/main.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h | 6 ------ drivers/net/wireless/mediatek/mt76/mt7915/testmode.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 4 ++-- drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h | 6 ------ 8 files changed, 13 insertions(+), 21 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac.h +6 -0
@@ -159,6 +159,12 @@ static inline u8 mt76_connac_chan_bw(struct cfg80211_chan_def *chandef)return width_to_bw[chandef->width]; } +static inline u8 mt76_connac_lmac_mapping (u8 ac) +{ +/* LMAC uses the reverse order of mac80211 AC indexes */ +return 3 - ac; +} +int mt76_connac_pm_wake (struct mt76_phy *phy,struct mt76_connac_pm *pm);void mt76_connac_power_save_sched (struct mt76_phy *phy,struct mt76_connac_pm *pm);
drivers/net/wireless/mediatek/mt76/mt7915/mac.c +2 -2
@@ -165,7 +165,7 @@ static void mt7915_mac_sta_poll(struct mt7915_dev *dev) sta = container_of((void *)msta, struct ieee80211_sta, drv_priv);for (i =0 ; i <IEEE80211_NUM_ACS ; i++) { -u8 q =mt7915_lmac_mapping (dev, i); +u8 q =mt76_connac_lmac_mapping (i);u32 tx_cur = tx_time[q];u32 rx_cur = rx_time[q];u8 tid = ac_to_tid[i];
@@ -1205,7 +1205,7 @@ void mt7915_mac_write_txwi(struct mt7915_dev *dev, __le32 *txwi, }else { p_fmt =MT_TX_TYPE_CT ; q_idx = wmm_idx *MT7915_MAX_WMM_SETS + -mt7915_lmac_mapping (dev,skb_get_queue_mapping (skb)); +mt76_connac_lmac_mapping (skb_get_queue_mapping (skb)); } val = FIELD_PREP(MT_TXD0_TX_BYTES, skb->len + MT_TXD_SIZE) |
drivers/net/wireless/mediatek/mt76/mt7915/main.c +1 -2
@@ -506,11 +506,10 @@ static int mt7915_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u16 queue, const struct ieee80211_tx_queue_params *params) { - struct mt7915_dev *dev = mt7915_hw_dev(hw); struct mt7915_vif *mvif = (struct mt7915_vif *)vif->drv_priv;/* no need to update right away, we'll get BSS_CHANGED_QOS */ - queue =mt7915_lmac_mapping (dev, queue); + queue =mt76_connac_lmac_mapping (queue); mvif->queue_params[queue] = *params;return 0 ;
drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h +0 -6
@@ -378,12 +378,6 @@ mt7915_ext_phy(struct mt7915_dev *dev)return phy->priv; } -static inline u8 mt7915_lmac_mapping (struct mt7915_dev *dev,u8 ac) -{ -/* LMAC uses the reverse order of mac80211 AC indexes */ -return 3 - ac; -} -extern const struct ieee80211_ops mt7915_ops;extern const struct mt76_testmode_ops mt7915_testmode_ops;extern struct pci_driver mt7915_pci_driver;
drivers/net/wireless/mediatek/mt76/mt7915/testmode.c +1 -1
@@ -250,7 +250,7 @@ mt7915_tm_set_ipg_params(struct mt7915_phy *phy, u32 ipg, u8 mode)mt7915_tm_set_slot_time (phy, slot_time, sifs);return mt7915_tm_set_wmm_qid (dev, -mt7915_lmac_mapping (dev,IEEE80211_AC_BE ), +mt76_connac_lmac_mapping (IEEE80211_AC_BE ), aifsn, cw, cw,0 ); }
drivers/net/wireless/mediatek/mt76/mt7921/mac.c +2 -2
@@ -116,7 +116,7 @@ void mt7921_mac_sta_poll(struct mt7921_dev *dev) sta = container_of((void *)msta, struct ieee80211_sta, drv_priv);for (i =0 ; i <IEEE80211_NUM_ACS ; i++) { -u8 q =mt7921_lmac_mapping (dev, i); +u8 q =mt76_connac_lmac_mapping (i);u32 tx_cur = tx_time[q];u32 rx_cur = rx_time[q];u8 tid = ac_to_tid[i];
@@ -949,7 +949,7 @@ void mt7921_mac_write_txwi(struct mt7921_dev *dev, __le32 *txwi, }else { p_fmt = is_mmio ?MT_TX_TYPE_CT :MT_TX_TYPE_SF ; q_idx = wmm_idx *MT7921_MAX_WMM_SETS + -mt7921_lmac_mapping (dev,skb_get_queue_mapping (skb)); +mt76_connac_lmac_mapping (skb_get_queue_mapping (skb)); } val = FIELD_PREP(MT_TXD0_TX_BYTES, skb->len + sz_txd) |
drivers/net/wireless/mediatek/mt76/mt7921/main.c +1 -2
@@ -537,11 +537,10 @@ static int mt7921_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u16 queue, const struct ieee80211_tx_queue_params *params) { - struct mt7921_dev *dev = mt7921_hw_dev(hw); struct mt7921_vif *mvif = (struct mt7921_vif *)vif->drv_priv;/* no need to update right away, we'll get BSS_CHANGED_QOS */ - queue =mt7921_lmac_mapping (dev, queue); + queue =mt76_connac_lmac_mapping (queue); mvif->queue_params[queue] = *params;return 0 ;
drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h +0 -6
@@ -272,12 +272,6 @@ mt7921_hw_dev(struct ieee80211_hw *hw)#define mt7921_mutex_release (dev) \ mt76_connac_mutex_release(&(dev)->mt76, &(dev)->pm) -static inline u8 mt7921_lmac_mapping (struct mt7921_dev *dev,u8 ac) -{ -/* LMAC uses the reverse order of mac80211 AC indexes */ -return 3 - ac; -} -extern const struct ieee80211_ops mt7921_ops;extern struct pci_driver mt7921_pci_driver;
Signature · 1 line
2.34.1
Lorenzo Bianconi
maintainerPATCH 2/5 mt76: connac: move common mac defs in mt76_connac_mac.h
In reply to Lorenzo BianconiMove mac definitions shared between mt7921 and mt7915 in mt76_connac_mac.h header.
--- .../wireless/mediatek/mt76/mt76_connac_mac.h | 292 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7915/mac.h | 279 +---------------- .../net/wireless/mediatek/mt76/mt7921/mac.c | 4 +- .../net/wireless/mediatek/mt76/mt7921/mac.h | 293 +----------------- 4 files changed, 296 insertions(+), 572 deletions(-) create mode 100644 drivers/net/wireless/mediatek/mt76/mt76_connac_mac.h
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.h new file +292 -0
@@ -0,0 +1,292 @@ +/* SPDX-License-Identifier: ISC */ +/* Copyright (C) 2021 MediaTek Inc. */ + +#ifndef __MT76_CONNAC_MAC_H +#define __MT76_CONNAC_MAC_H + +#define MT_CT_PARSE_LEN 72 +#define MT_CT_DMA_BUF_NUM 2 + +#define MT_RXD0_LENGTH GENMASK(15, 0) +#define MT_RXD0_PKT_FLAG GENMASK(19, 16) +#define MT_RXD0_PKT_TYPE GENMASK(31, 27) + +#define MT_RXD0_NORMAL_ETH_TYPE_OFS GENMASK(22, 16) +#define MT_RXD0_NORMAL_IP_SUM BIT(23) +#define MT_RXD0_NORMAL_UDP_TCP_SUM BIT(24) + +enum rx_pkt_type { +PKT_TYPE_TXS , +PKT_TYPE_TXRXV , +PKT_TYPE_NORMAL , +PKT_TYPE_RX_DUP_RFB , +PKT_TYPE_RX_TMR , +PKT_TYPE_RETRIEVE , +PKT_TYPE_TXRX_NOTIFY , +PKT_TYPE_RX_EVENT , +PKT_TYPE_NORMAL_MCU , +PKT_TYPE_RX_FW_MONITOR =0x0c , +}; + +/* RXD DW1 */ +#define MT_RXD1_NORMAL_WLAN_IDX GENMASK(9, 0) +#define MT_RXD1_NORMAL_GROUP_1 BIT(11) +#define MT_RXD1_NORMAL_GROUP_2 BIT(12) +#define MT_RXD1_NORMAL_GROUP_3 BIT(13) +#define MT_RXD1_NORMAL_GROUP_4 BIT(14) +#define MT_RXD1_NORMAL_GROUP_5 BIT(15) +#define MT_RXD1_NORMAL_SEC_MODE GENMASK(20, 16) +#define MT_RXD1_NORMAL_KEY_ID GENMASK(22, 21) +#define MT_RXD1_NORMAL_CM BIT(23) +#define MT_RXD1_NORMAL_CLM BIT(24) +#define MT_RXD1_NORMAL_ICV_ERR BIT(25) +#define MT_RXD1_NORMAL_TKIP_MIC_ERR BIT(26) +#define MT_RXD1_NORMAL_FCS_ERR BIT(27) +#define MT_RXD1_NORMAL_BAND_IDX BIT(28) +#define MT_RXD1_NORMAL_SPP_EN BIT(29) +#define MT_RXD1_NORMAL_ADD_OM BIT(30) +#define MT_RXD1_NORMAL_SEC_DONE BIT(31) + +/* RXD DW2 */ +#define MT_RXD2_NORMAL_BSSID GENMASK(5, 0) +#define MT_RXD2_NORMAL_CO_ANT BIT(6) +#define MT_RXD2_NORMAL_BF_CQI BIT(7) +#define MT_RXD2_NORMAL_MAC_HDR_LEN GENMASK(12, 8) +#define MT_RXD2_NORMAL_HDR_TRANS BIT(13) +#define MT_RXD2_NORMAL_HDR_OFFSET GENMASK(15, 14) +#define MT_RXD2_NORMAL_TID GENMASK(19, 16) +#define MT_RXD2_NORMAL_MU_BAR BIT(21) +#define MT_RXD2_NORMAL_SW_BIT BIT(22) +#define MT_RXD2_NORMAL_AMSDU_ERR BIT(23) +#define MT_RXD2_NORMAL_MAX_LEN_ERROR BIT(24) +#define MT_RXD2_NORMAL_HDR_TRANS_ERROR BIT(25) +#define MT_RXD2_NORMAL_INT_FRAME BIT(26) +#define MT_RXD2_NORMAL_FRAG BIT(27) +#define MT_RXD2_NORMAL_NULL_FRAME BIT(28) +#define MT_RXD2_NORMAL_NDATA BIT(29) +#define MT_RXD2_NORMAL_NON_AMPDU BIT(30) +#define MT_RXD2_NORMAL_BF_REPORT BIT(31) + +/* RXD DW3 */ +#define MT_RXD3_NORMAL_RXV_SEQ GENMASK(7, 0) +#define MT_RXD3_NORMAL_CH_FREQ GENMASK(15, 8) +#define MT_RXD3_NORMAL_ADDR_TYPE GENMASK(17, 16) +#define MT_RXD3_NORMAL_U2M BIT(0) +#define MT_RXD3_NORMAL_HTC_VLD BIT(0) +#define MT_RXD3_NORMAL_TSF_COMPARE_LOSS BIT(19) +#define MT_RXD3_NORMAL_BEACON_MC BIT(20) +#define MT_RXD3_NORMAL_BEACON_UC BIT(21) +#define MT_RXD3_NORMAL_AMSDU BIT(22) +#define MT_RXD3_NORMAL_MESH BIT(23) +#define MT_RXD3_NORMAL_MHCP BIT(24) +#define MT_RXD3_NORMAL_NO_INFO_WB BIT(25) +#define MT_RXD3_NORMAL_DISABLE_RX_HDR_TRANS BIT(26) +#define MT_RXD3_NORMAL_POWER_SAVE_STAT BIT(27) +#define MT_RXD3_NORMAL_MORE BIT(28) +#define MT_RXD3_NORMAL_UNWANT BIT(29) +#define MT_RXD3_NORMAL_RX_DROP BIT(30) +#define MT_RXD3_NORMAL_VLAN2ETH BIT(31) + +/* RXD DW4 */ +#define MT_RXD4_NORMAL_PAYLOAD_FORMAT GENMASK(1, 0) +#define MT_RXD4_FIRST_AMSDU_FRAME GENMASK(1, 0) +#define MT_RXD4_MID_AMSDU_FRAME BIT(1) +#define MT_RXD4_LAST_AMSDU_FRAME BIT(0) +#define MT_RXD4_NORMAL_PATTERN_DROP BIT(9) +#define MT_RXD4_NORMAL_CLS BIT(10) +#define MT_RXD4_NORMAL_OFLD GENMASK(12, 11) +#define MT_RXD4_NORMAL_MAGIC_PKT BIT(13) +#define MT_RXD4_NORMAL_WOL GENMASK(18, 14) +#define MT_RXD4_NORMAL_CLS_BITMAP GENMASK(28, 19) +#define MT_RXD3_NORMAL_PF_MODE BIT(29) +#define MT_RXD3_NORMAL_PF_STS GENMASK(31, 30) + +/* RXD GROUP4 */ +#define MT_RXD6_FRAME_CONTROL GENMASK(15, 0) +#define MT_RXD6_TA_LO GENMASK(31, 16) + +#define MT_RXD7_TA_HI GENMASK(31, 0) + +#define MT_RXD8_SEQ_CTRL GENMASK(15, 0) +#define MT_RXD8_QOS_CTL GENMASK(31, 16) + +#define MT_RXD9_HT_CONTROL GENMASK(31, 0) + +/* P-RXV DW0 */ +#define MT_PRXV_TX_RATE GENMASK(6, 0) +#define MT_PRXV_TX_DCM BIT(4) +#define MT_PRXV_TX_ER_SU_106T BIT(5) +#define MT_PRXV_NSTS GENMASK(9, 7) +#define MT_PRXV_TXBF BIT(10) +#define MT_PRXV_HT_AD_CODE BIT(11) +#define MT_PRXV_FRAME_MODE GENMASK(14, 12) +#define MT_PRXV_HT_SHORT_GI GENMASK(16, 15) +#define MT_PRXV_HT_STBC GENMASK(23, 22) +#define MT_PRXV_TX_MODE GENMASK(27, 24) +#define MT_PRXV_HE_RU_ALLOC_L GENMASK(31, 28) + +/* P-RXV DW1 */ +#define MT_PRXV_RCPI0 GENMASK(7, 0) +#define MT_PRXV_RCPI1 GENMASK(15, 8) +#define MT_PRXV_RCPI2 GENMASK(23, 16) +#define MT_PRXV_RCPI3 GENMASK(31, 24) + +#define MT_PRXV_HE_RU_ALLOC_H GENMASK(3, 0) + +/* C-RXV */ +#define MT_CRXV_HT_STBC GENMASK(1, 0) +#define MT_CRXV_TX_MODE GENMASK(7, 4) +#define MT_CRXV_FRAME_MODE GENMASK(10, 8) +#define MT_CRXV_HT_SHORT_GI GENMASK(14, 13) +#define MT_CRXV_HE_LTF_SIZE GENMASK(18, 17) +#define MT_CRXV_HE_LDPC_EXT_SYM BIT(20) +#define MT_CRXV_HE_PE_DISAMBIG BIT(23) +#define MT_CRXV_HE_NUM_USER GENMASK(30, 24) +#define MT_CRXV_HE_UPLINK BIT(31) + +#define MT_CRXV_HE_RU0 GENMASK(7, 0) +#define MT_CRXV_HE_RU1 GENMASK(15, 8) +#define MT_CRXV_HE_RU2 GENMASK(23, 16) +#define MT_CRXV_HE_RU3 GENMASK(31, 24) + +#define MT_CRXV_HE_MU_AID GENMASK(30, 20) + +#define MT_CRXV_HE_SR_MASK GENMASK(11, 8) +#define MT_CRXV_HE_SR1_MASK GENMASK(16, 12) +#define MT_CRXV_HE_SR2_MASK GENMASK(20, 17) +#define MT_CRXV_HE_SR3_MASK GENMASK(24, 21) + +#define MT_CRXV_HE_BSS_COLOR GENMASK(5, 0) +#define MT_CRXV_HE_TXOP_DUR GENMASK(12, 6) +#define MT_CRXV_HE_BEAM_CHNG BIT(13) +#define MT_CRXV_HE_DOPPLER BIT(16) + +#define MT_CRXV_SNR GENMASK(18, 13) +#define MT_CRXV_FOE_LO GENMASK(31, 19) +#define MT_CRXV_FOE_HI GENMASK(6, 0) +#define MT_CRXV_FOE_SHIFT 13 + +enum tx_header_format { +MT_HDR_FORMAT_802_3 , +MT_HDR_FORMAT_CMD , +MT_HDR_FORMAT_802_11 , +MT_HDR_FORMAT_802_11_EXT , +}; + +enum tx_pkt_type { +MT_TX_TYPE_CT , +MT_TX_TYPE_SF , +MT_TX_TYPE_CMD , +MT_TX_TYPE_FW , +}; + +enum tx_port_idx { +MT_TX_PORT_IDX_LMAC , +MT_TX_PORT_IDX_MCU +}; + +enum tx_mcu_port_q_idx { +MT_TX_MCU_PORT_RX_Q0 =0x20 , +MT_TX_MCU_PORT_RX_Q1 , +MT_TX_MCU_PORT_RX_Q2 , +MT_TX_MCU_PORT_RX_Q3 , +MT_TX_MCU_PORT_RX_FWDL =0x3e +}; + +#define MT_CT_INFO_APPLY_TXD BIT(0) +#define MT_CT_INFO_COPY_HOST_TXD_ALL BIT(1) +#define MT_CT_INFO_MGMT_FRAME BIT(2) +#define MT_CT_INFO_NONE_CIPHER_FRAME BIT(3) +#define MT_CT_INFO_HSR2_TX BIT(4) +#define MT_CT_INFO_FROM_HOST BIT(7) + +#define MT_TXD_SIZE (8 * 4) + +#define MT_TXD0_Q_IDX GENMASK(31, 25) +#define MT_TXD0_PKT_FMT GENMASK(24, 23) +#define MT_TXD0_ETH_TYPE_OFFSET GENMASK(22, 16) +#define MT_TXD0_TX_BYTES GENMASK(15, 0) + +#define MT_TXD1_LONG_FORMAT BIT(31) +#define MT_TXD1_TGID BIT(30) +#define MT_TXD1_OWN_MAC GENMASK(29, 24) +#define MT_TXD1_AMSDU BIT(23) +#define MT_TXD1_TID GENMASK(22, 20) +#define MT_TXD1_HDR_PAD GENMASK(19, 18) +#define MT_TXD1_HDR_FORMAT GENMASK(17, 16) +#define MT_TXD1_HDR_INFO GENMASK(15, 11) +#define MT_TXD1_ETH_802_3 BIT(15) +#define MT_TXD1_VTA BIT(10) +#define MT_TXD1_WLAN_IDX GENMASK(9, 0) + +#define MT_TXD2_FIX_RATE BIT(31) +#define MT_TXD2_FIXED_RATE BIT(30) +#define MT_TXD2_POWER_OFFSET GENMASK(29, 24) +#define MT_TXD2_MAX_TX_TIME GENMASK(23, 16) +#define MT_TXD2_FRAG GENMASK(15, 14) +#define MT_TXD2_HTC_VLD BIT(13) +#define MT_TXD2_DURATION BIT(12) +#define MT_TXD2_BIP BIT(11) +#define MT_TXD2_MULTICAST BIT(10) +#define MT_TXD2_RTS BIT(9) +#define MT_TXD2_SOUNDING BIT(8) +#define MT_TXD2_NDPA BIT(7) +#define MT_TXD2_NDP BIT(6) +#define MT_TXD2_FRAME_TYPE GENMASK(5, 4) +#define MT_TXD2_SUB_TYPE GENMASK(3, 0) + +#define MT_TXD3_SN_VALID BIT(31) +#define MT_TXD3_PN_VALID BIT(30) +#define MT_TXD3_SW_POWER_MGMT BIT(29) +#define MT_TXD3_BA_DISABLE BIT(28) +#define MT_TXD3_SEQ GENMASK(27, 16) +#define MT_TXD3_REM_TX_COUNT GENMASK(15, 11) +#define MT_TXD3_TX_COUNT GENMASK(10, 6) +#define MT_TXD3_TIMING_MEASURE BIT(5) +#define MT_TXD3_DAS BIT(4) +#define MT_TXD3_EEOSP BIT(3) +#define MT_TXD3_EMRD BIT(2) +#define MT_TXD3_PROTECT_FRAME BIT(1) +#define MT_TXD3_NO_ACK BIT(0) + +#define MT_TXD4_PN_LOW GENMASK(31, 0) + +#define MT_TXD5_PN_HIGH GENMASK(31, 16) +#define MT_TXD5_MD BIT(15) +#define MT_TXD5_ADD_BA BIT(14) +#define MT_TXD5_TX_STATUS_HOST BIT(10) +#define MT_TXD5_TX_STATUS_MCU BIT(9) +#define MT_TXD5_TX_STATUS_FMT BIT(8) +#define MT_TXD5_PID GENMASK(7, 0) + +#define MT_TXD6_TX_IBF BIT(31) +#define MT_TXD6_TX_EBF BIT(30) +#define MT_TXD6_TX_RATE GENMASK(29, 16) +#define MT_TXD6_SGI GENMASK(15, 14) +#define MT_TXD6_HELTF GENMASK(13, 12) +#define MT_TXD6_LDPC BIT(11) +#define MT_TXD6_SPE_ID_IDX BIT(10) +#define MT_TXD6_ANT_ID GENMASK(7, 4) +#define MT_TXD6_DYN_BW BIT(3) +#define MT_TXD6_FIXED_BW BIT(2) +#define MT_TXD6_BW GENMASK(1, 0) + +#define MT_TXD7_TXD_LEN GENMASK(31, 30) +#define MT_TXD7_UDP_TCP_SUM BIT(29) +#define MT_TXD7_IP_SUM BIT(28) + +#define MT_TXD7_TYPE GENMASK(21, 20) +#define MT_TXD7_SUB_TYPE GENMASK(19, 16) + +#define MT_TXD7_PSE_FID GENMASK(27, 16) +#define MT_TXD7_SPE_IDX GENMASK(15, 11) +#define MT_TXD7_HW_AMSDU BIT(10) +#define MT_TXD7_TX_TIME GENMASK(9, 0) + +#define MT_TX_RATE_STBC BIT(13) +#define MT_TX_RATE_NSS GENMASK(12, 10) +#define MT_TX_RATE_MODE GENMASK(9, 6) +#define MT_TX_RATE_SU_EXT_TONE BIT(5) +#define MT_TX_RATE_DCM BIT(4) + +#endif /* __MT76_CONNAC_MAC_H */
drivers/net/wireless/mediatek/mt76/mt7915/mac.h +1 -278
295 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7921/mac.c +2 -2
@@ -668,8 +668,8 @@ mt7921_mac_fill_rx(struct mt7921_dev *dev, struct sk_buff *skb)if (status->signal ==-128 ) status->flag |=RX_FLAG_NO_SIGNAL_VAL ; - stbc =FIELD_GET (MT_PRXV_STBC , v0); - gi =FIELD_GET (MT_PRXV_SGI , v0); + stbc =FIELD_GET (MT_PRXV_HT_STBC , v0); + gi =FIELD_GET (MT_PRXV_HT_SHORT_GI , v0); cck = false; idx = i =FIELD_GET (MT_PRXV_TX_RATE , v0);
drivers/net/wireless/mediatek/mt76/mt7921/mac.h +1 -292
306 lines not on this page · raw message
Signature · 1 line
2.34.1
Felix Fietkau
maintainerRe: [PATCH 2/5] mt76: connac: move common mac defs in mt76_connac_mac.h
Quoted 6 lines · Lorenzo Bianconi
Move mac definitions shared between mt7921 and mt7915 in
mt76_connac_mac.hheader.Signed-off-by Lorenzo Bianconi <[email protected]>--- .../wireless/mediatek/mt76/mt76_connac_mac.h | 292 +++++++++++++++++
I think this should probably be put in mt76_connac2_mac.h or something like that. The definitions are different for 7663/7615 (connac v1), and they will probably be different again for newer chipset generations.
Maybe we should reorganize the code to make it clear which parts are connac2 specific.
- Felix
Re: [PATCH 2/5] mt76: connac: move common mac defs in mt76_connac_mac.h
Quoted 7 lines · Lorenzo Bianconi
Quoted 6 lines
Move mac definitions shared between mt7921 and mt7915 in
mt76_connac_mac.hheader.Signed-off-by Lorenzo Bianconi <[email protected]>--- .../wireless/mediatek/mt76/mt76_connac_mac.h | 292 +++++++++++++++++
Quoted 9 lines
I think this should probably be put in
mt76_connac2_mac.hor something like that. The definitions are different for 7663/7615 (connac v1), and they will probably be different again for newer chipset generations.Maybe we should reorganize the code to make it clear which parts are connac2 specific.
- Felix
ack. According to irc discussion with Ryder and Sean, I marked this series as 'superseded' in patchwork.
I guess we can keep patch 1/5: "mt76: connac: move mt76_connac_lmac_mapping in mt76-connac module".
Regards,
Lorenzo
Lorenzo Bianconi
maintainerPATCH 3/5 mt76: connac: move mt76_connac_reverse_frag0_hdr_trans in common module
In reply to Lorenzo BianconiMove mt76_connac_reverse_frag0_hdr_trans in mt76-connac since it is shared between mt7921 and mt7915 drivers.
--- .../net/wireless/mediatek/mt76/mt76_connac.h | 3 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 68 ++++++++++++++ .../net/wireless/mediatek/mt76/mt7915/mac.c | 88 +++---------------- .../net/wireless/mediatek/mt76/mt7921/mac.c | 88 +++---------------- 4 files changed, 97 insertions(+), 150 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac.h +3 -0
@@ -239,5 +239,8 @@ void mt76_connac_pm_queue_skb(struct ieee80211_hw *hw, struct sk_buff *skb);void mt76_connac_pm_dequeue_skbs (struct mt76_phy *phy,struct mt76_connac_pm *pm); +int mt76_connac_reverse_frag0_hdr_trans (struct sk_buff *skb,u16 hdr_offset, +struct ieee80211_sta *sta, +struct ieee80211_vif *vif);#endif /* __MT76_CONNAC_H */
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +68 -0
77 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7915/mac.c +13 -75
101 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7921/mac.c +13 -75
101 lines not on this page · raw message
Signature · 1 line
2.34.1
Lorenzo Bianconi
maintainerPATCH 4/5 mt76: connac: move he radiotap parsing in connac module
In reply to Lorenzo BianconiMove HE radiotap parsing code in mt76-connac module since it is shared between mt7921 and mt7915 drivers.
--- .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +---------------- .../net/wireless/mediatek/mt76/mt7921/mac.c | 182 +----------------- 5 files changed, 176 insertions(+), 355 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac.h +2 -0
@@ -242,5 +242,7 @@ void mt76_connac_pm_dequeue_skbs(struct mt76_phy *phy,int mt76_connac_reverse_frag0_hdr_trans (struct sk_buff *skb,u16 hdr_offset,struct ieee80211_sta *sta,struct ieee80211_vif *vif); +void mt76_connac_mac_decode_he_radiotap (struct sk_buff *skb, +__le32 *rxv,u32 mode);#endif /* __MT76_CONNAC_H */
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +168 -0
171 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.h +4 -0
@@ -4,6 +4,10 @@#ifndef __MT76_CONNAC_MAC_H#define __MT76_CONNAC_MAC_H +#define HE_BITS (f) cpu_to_le16(IEEE80211_RADIOTAP_HE_##f) +#define HE_PREP (f, m, v) le16_encode_bits(le32_get_bits(v, MT_CRXV_HE_##m),\ + IEEE80211_RADIOTAP_HE_##f) +#define MT_CT_PARSE_LEN 72#define MT_CT_DMA_BUF_NUM 2
drivers/net/wireless/mediatek/mt76/mt7915/mac.c +1 -174
193 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7921/mac.c +1 -181
200 lines not on this page · raw message
Signature · 1 line
2.34.1
Ryder Lee
maintainerRe: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module
Quoted 11 lines · Lorenzo Bianconi
Move HE radiotap parsing code in mt76-connac module since it is shared
between mt7921 and mt7915 drivers.Signed-off-by Lorenzo Bianconi <[email protected]>--- .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +----------------
[...]
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c int mt76_connac_reverse_frag0_hdr_trans(struct sk_buff *skb, u16 hdr_offset, · line 248
Quoted 13 lines
+mt76_connac_mac_decode_he_mu_radiotap(struct
sk_buff*skb,__le32*rxv)(quoted diff) +2
-0+{ + struct mt76_rx_status *status = (struct mt76_rx_status *)skb-Quoted 1 line
cb;
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +8
-0+static const struct ieee80211_radiotap_he_mu mu_known = { + .flags1 =HE_BITS (MU_FLAGS1_SIG_B_MCS_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_DCM_KNOWN ) | +HE_BITS (MU_FLAGS1_CH1_RU_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_COMP_KNOWN ), + .flags2 =HE_BITS (MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN ) | +HE_BITS (MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN ),
I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here.
Ryder
Lorenzo Bianconi
maintainerRe: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module
Quoted 20 lines · Lorenzo Bianconi
Quoted 11 lines
Move HE radiotap parsing code in mt76-connac module since it is shared
between mt7921 and mt7915 drivers.Signed-off-by Lorenzo Bianconi <[email protected]>--- .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +----------------
[...]
Quoted 5 lines
+mt76_connac_mac_decode_he_mu_radiotap(struct
sk_buff*skb,__le32*rxv)(quoted diff) +2
-0+{ + struct mt76_rx_status *status = (struct mt76_rx_status *)skb-Quoted 1 line
cb;
Quoted 11 lines
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c int mt76_connac_reverse_frag0_hdr_trans(struct sk_buff *skb, u16 hdr_offset, · line 248
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +8
-0+static const struct ieee80211_radiotap_he_mu mu_known = { + .flags1 =HE_BITS (MU_FLAGS1_SIG_B_MCS_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_DCM_KNOWN ) | +HE_BITS (MU_FLAGS1_CH1_RU_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN ) | +HE_BITS (MU_FLAGS1_SIG_B_COMP_KNOWN ), + .flags2 =HE_BITS (MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN ) | +HE_BITS (MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN ),I think hardware doesn't report
MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWNandMU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here.
ack, thx for point this out.
@Sean: can you please confirm it?
Regards,
Lorenzo
Quoted 3 lines
Ryder
Lorenzo Bianconi
maintainerPATCH 5/5 mt76: connac: move mt76_connac_mac_write_txwi in connac module
In reply to Lorenzo BianconiMove mt76_connac_mac_write_txwi_8023 and mt76_connac_mac_write_txwi_80211 routines in mt76-connac module since they are shared between mt7921 and mt7915 drivers.
--- .../net/wireless/mediatek/mt76/mt76_connac.h | 3 + .../wireless/mediatek/mt76/mt76_connac_mac.c | 126 +++++++++++++++++ .../net/wireless/mediatek/mt76/mt7915/mac.c | 129 +----------------- .../net/wireless/mediatek/mt76/mt7921/mac.c | 120 +--------------- 4 files changed, 135 insertions(+), 243 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76_connac.h +3 -0
@@ -244,5 +244,8 @@ int mt76_connac_reverse_frag0_hdr_trans(struct sk_buff *skb, u16 hdr_offset, struct ieee80211_vif *vif);void mt76_connac_mac_decode_he_radiotap (struct sk_buff *skb,__le32 *rxv,u32 mode); +void mt76_connac_mac_write_txwi (struct sk_buff *skb,__le32 *txwi, +struct mt76_wcid *wcid, +struct ieee80211_key_conf *key);#endif /* __MT76_CONNAC_H */
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +126 -0
129 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7915/mac.c +5 -124
149 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt7921/mac.c +1 -119
138 lines not on this page · raw message
Signature · 1 line
2.34.1