pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards
PATCH 1/1 pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards
When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due to missing DB1XXX symbols. The PCMCIA driver should be restricted to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error.
ERROR: modpost: "bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined!
ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined!
--- drivers/pcmcia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pcmcia/Kconfig +1 -1
@@ -151,7 +151,7 @@ config TCIC config PCMCIA_ALCHEMY_DEVBOARD tristate "Alchemy Db/Pb1xxx PCMCIA socket services" - depends on MIPS_ALCHEMY && PCMCIA + depends on MIPS_DB1XXX && PCMCIA help Enable this driver of you want PCMCIA support on your Alchemy Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
Hello,
drivers/pcmcia/Kconfig config TCIC · line 157
Quoted 12 lines · Randy Dunlap
When the
MIPS_ALCHEMYboard selection isMIPS_XXS1500instead ofMIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due to missing DB1XXX symbols. The PCMCIA driver should be restricted toMIPS_DB1XXXinstead ofMIPS_ALCHEMYto fix this build error.config
PCMCIA_ALCHEMY_DEVBOARD
tristate "Alchemy Db/Pb1xxx PCMCIA socket services"drivers/pcmcia/Kconfig +1
-1- depends on MIPS_ALCHEMY && PCMCIA + depends on MIPS_DB1XXX && PCMCIA help Enable this driver of you want PCMCIA support on your Alchemy Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
Seems sensible.
Thank you!
Manuel
Am Sun, Jan 23, 2022 at 09:40:31AM -0800 schrieb Randy Dunlap:
Quoted 8 lines
When the
MIPS_ALCHEMYboard selection isMIPS_XXS1500instead ofMIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due to missing DB1XXX symbols. The PCMCIA driver should be restricted toMIPS_DB1XXXinstead ofMIPS_ALCHEMYto fix this build error.ERROR: modpost: "
bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined!
ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined!
Quoted 10 lines
Fixes 42a4f17dc356 ("MIPS: Alchemy: remove SOC_AU1X00 in favor of MIPS_ALCHEMY")Signed-off-by Randy Dunlap <[email protected]>Reported-by kernel test robot <[email protected]>Cc Dominik Brodowski <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Daniel Vetter <[email protected]>Cc Kees Cook <[email protected]>Cc Manuel Lauss <[email protected]>Cc Thomas Bogendoerfer <[email protected]>
Applied to -pcmcia, thanks!
Dominik