irq_work: Allow irq_work_sync() to sleep if irq_work() no IRQ support.
Hello Sebastian Andrzej Siewior,
The patch 810979682ccc: "irq_work: Allow irq_work_sync() to sleep if irq_work() no IRQ support." from Oct 6, 2021, leads to the following Smatch static checker warning:
kernel/events/core.c:4955 _free_event() warn: sleeping in atomic context
There are two potential call trees where preemption is disabled.
perf_remove_from_context() <- disables preempt__perf_event_exit_context() <- disables preempt
-> __perf_remove_from_context()
-> perf_group_detach()
-> perf_put_aux_event()
-> put_event()
-> _free_event()_free_event() calls irq_work_sync() which can now sleep.
regards,
dan carpenter
+peterz, tglx
Quoted 6 lines · Dan Carpenter
Hello Sebastian Andrzej Siewior,
The patch
810979682ccc: "irq_work: Allowirq_work_sync()to sleep ifirq_work()no IRQ support." from Oct 6, 2021, leads to the following Smatch static checker warning:
Quoted 6 lines
kernel/events/core.c:4955 _free_event() warn: sleeping in atomic contextThere are two potential call trees where preemption is disabled.
perf_remove_from_context()<- disables preempt
raw_spin_lock_irq(&ctx->lock)
Quoted 1 line
__perf_event_exit_context()<- disables preempt
don't see additional one.
Quoted 7 lines
->
__perf_remove_from_context()
->perf_group_detach()-> perf_put_aux_event() -> put_event() -> _free_event()
_free_event()callsirq_work_sync()which can now sleep.
That is true. There is also
| if (event->rb)
| mutex_lock(&event->mmap_mutex);
Can we somehow delay the whole thing? There are also kfree() and spinlock_t usage which are not very RT compatible with disabled preemption.
Quoted 2 lines
regards,
dan carpenter
Sebastian
Quoted 5 lines · Sebastian Andrzej Siewior
Quoted 2 lines
__perf_event_exit_context()<- disables preemptdon't see additional one.
Quoted 1 line
->
__perf_remove_from_context()
In linux-next perf_remove_from_context() calls raw_spin_lock() which disabled preemption.
kernel/events/core.c
13343 static void __perf_event_exit_context(void *__info)
13344 {
13345 struct perf_event_context *ctx = __info;
13346 struct perf_cpu_context *cpuctx = __get_cpu_context(ctx);
13347 struct perf_event *event;
13348
13349 raw_spin_lock(&ctx->lock);
^^^^^^^^^^^^^^^^^^^^^^^^^
13350 ctx_sched_out(ctx, cpuctx, EVENT_TIME);
13351 list_for_each_entry(event, &ctx->event_list, event_entry)
13352 __perf_remove_from_context(event, cpuctx, ctx, (void *)DETACH_GROUP);
^^^^^^^^^^^^^^^^^^^^^^^^^^^ 13353 raw_spin_unlock(&ctx->lock);
13354 }
regards,
dan carpenter