netfilter: nft_reject_bridge: Fix for missing reply from prerouting
Subsystems (3)
Phil Sutter
reviewerPATCH 1/1 netfilter: nft_reject_bridge: Fix for missing reply from prerouting
Prior to commit fa538f7cf05aa ("netfilter: nf_reject: add reject skbuff creation helpers"), nft_reject_bridge did not assign to nskb->dev before passing nskb on to br_forward(). The shared skbuff creation helpers introduced in above commit do which seems to confuse br_forward() as reject statements in prerouting hook won't emit a packet anymore.
Fix this by simply passing NULL instead of 'dev' to the helpers - they use the pointer for just that assignment, nothing else.
--- net/bridge/netfilter/nft_reject_bridge.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
net/bridge/netfilter/nft_reject_bridge.c +4 -4
@@ -49,7 +49,7 @@ static void nft_reject_br_send_v4_tcp_reset(struct net *net, {struct sk_buff *nskb; - nskb =nf_reject_skb_v4_tcp_reset (net, oldskb, dev, hook); + nskb =nf_reject_skb_v4_tcp_reset (net, oldskb,NULL , hook);if (!nskb)return ;
@@ -65,7 +65,7 @@ static void nft_reject_br_send_v4_unreach(struct net *net, {struct sk_buff *nskb; - nskb =nf_reject_skb_v4_unreach (net, oldskb, dev, hook, code); + nskb =nf_reject_skb_v4_unreach (net, oldskb,NULL , hook, code);if (!nskb)return ;
@@ -81,7 +81,7 @@ static void nft_reject_br_send_v6_tcp_reset(struct net *net, {struct sk_buff *nskb; - nskb =nf_reject_skb_v6_tcp_reset (net, oldskb, dev, hook); + nskb =nf_reject_skb_v6_tcp_reset (net, oldskb,NULL , hook);if (!nskb)return ;
@@ -98,7 +98,7 @@ static void nft_reject_br_send_v6_unreach(struct net *net, {struct sk_buff *nskb; - nskb =nf_reject_skb_v6_unreach (net, oldskb, dev, hook, code); + nskb =nf_reject_skb_v6_unreach (net, oldskb,NULL , hook, code);if (!nskb)return ;
Signature · 1 line
2.34.1
Quoted 8 lines · Phil Sutter
Prior to commit
fa538f7cf05aa("netfilter:nf_reject: add reject skbuff creation helpers"),nft_reject_bridgedid not assign tonskb->devbefore passing nskb on tobr_forward(). The shared skbuff creation helpers introduced in above commit do which seems to confusebr_forward()as reject statements in prerouting hook won't emit a packet anymore.Fix this by simply passing NULL instead of 'dev' to the helpers - they use the pointer for just that assignment, nothing else.
Applied, thanks