Regression with 5021d709b31b ("tty: serial: Use fifo in 8250 console driver")

DISCUSSION Sudip Mukherjee 5 participants 7 messages Jan 27, 2022 – Jan 31, 2022

Subsystems (2)

TTY layer and serial drivers Regressions

lore

Share & tools

lore

Sudip Mukherjee

author

2022-01-27 23:24 UTC #0 lore raw

Hi Wander,

Not sure if this has been reported before but since last few weeks I am seeing a problem with the rpi4 serial port on my test setup. The initial boot message will be completely garbled as you can see at:
https://lava.qa.codethink.co.uk/scheduler/job/543#L380.
The last good boot was https://lava.qa.codethink.co.uk/scheduler/job/540#L390.

The bisect log:

# bad: [455e73a07f6e288b0061dfcf4fcf54fa9fe06458] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
# good: [7e7b69654724c72bd3219b71f58937845dca0b2b] Merge tag 'dma-mapping-5.17' of git://git.infradead.org/users/hch/dma-mapping
git bisect start '455e73a07f6e288b0061dfcf4fcf54fa9fe06458' '7e7b69654724c72bd3219b71f58937845dca0b2b'
# bad: [342465f5337f7bd5b8bd3b6f939ac12b620cbb43] Merge tag 'tty-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 342465f5337f7bd5b8bd3b6f939ac12b620cbb43
# good: [6dc69d3d0d18d587ab9d809fe060ba4417cf0279] Merge tag 'driver-core-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect good 6dc69d3d0d18d587ab9d809fe060ba4417cf0279
# good: [e269f7acdc53623769da31135f60afeb3a65eaff] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
git bisect good e269f7acdc53623769da31135f60afeb3a65eaff
# bad: [ad234e2bac274a43c9fa540bde8cd9f0c627b71f] tty: serial: meson: Drop the legacy compatible strings and clock code
git bisect bad ad234e2bac274a43c9fa540bde8cd9f0c627b71f
# good: [c66453ce8af8bac78a72ba4e21fd9a86720127d7] tty: fix kernel-doc in n_tty.c
git bisect good c66453ce8af8bac78a72ba4e21fd9a86720127d7
# good: [0882b473b084df31288003b3bee974aabac9dcf9] tty: serial: samsung: Enable console as module
git bisect good 0882b473b084df31288003b3bee974aabac9dcf9
# bad: [b4a29b94804c4774f22555651296b838df6ec0e4] serial: 8250: Move Alpha-specific quirk out of the core
git bisect bad b4a29b94804c4774f22555651296b838df6ec0e4
# good: [e822b4973f49015e1c6f63b91c8641ed9bfaf229] tty/ldsem: Fix syntax errors in comments
git bisect good e822b4973f49015e1c6f63b91c8641ed9bfaf229
# good: [fb09d0ac07725b442b32dbf53f0ab0bea54804e9] tty: Fix the keyboard led light display problem
git bisect good fb09d0ac07725b442b32dbf53f0ab0bea54804e9
# bad: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
git bisect bad 5021d709b31b8a14317998a33cbc78be0de9ab30
# good: [adbfddc757aec1ed54ccb35c4a7ca9170df827e0] docs/driver-api: Replace a comma in the n_gsm.rst with a double colon
git bisect good adbfddc757aec1ed54ccb35c4a7ca9170df827e0

# first bad commit: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver

And, indeed reverting 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") on top of 23a46422c561 ("Merge tag 'net-5.17-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") fixes the problem for me.

This is seen on every boot and I will be happy to test any patch.

--
Regards
Sudip

Thorsten Leemhuis

2022-01-28 04:59 UTC #1 lore raw

[TLDR: I'm adding this regression to regzbot, the Linux kernel regression tracking bot; most text you find below is compiled from a few templates paragraphs some of you might have seen already.]

Hi, this is your Linux kernel regression tracker speaking.

Adding the regression mailing list to the list of recipients, as it should be in the loop for all regressions, as explained here:
https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html

Quoted 34 lines · Sudip Mukherjee

Not sure if this has been reported before but since last few weeks I am seeing a problem with the rpi4 serial port on my test setup. The initial boot message will be completely garbled as you can see at:
https://lava.qa.codethink.co.uk/scheduler/job/543#L380.
The last good boot was https://lava.qa.codethink.co.uk/scheduler/job/540#L390.
The bisect log:
# bad: [455e73a07f6e288b0061dfcf4fcf54fa9fe06458] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
# good: [7e7b69654724c72bd3219b71f58937845dca0b2b] Merge tag 'dma-mapping-5.17' of git://git.infradead.org/users/hch/dma-mapping
git bisect start '455e73a07f6e288b0061dfcf4fcf54fa9fe06458' '7e7b69654724c72bd3219b71f58937845dca0b2b'
# bad: [342465f5337f7bd5b8bd3b6f939ac12b620cbb43] Merge tag 'tty-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 342465f5337f7bd5b8bd3b6f939ac12b620cbb43
# good: [6dc69d3d0d18d587ab9d809fe060ba4417cf0279] Merge tag 'driver-core-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect good 6dc69d3d0d18d587ab9d809fe060ba4417cf0279
# good: [e269f7acdc53623769da31135f60afeb3a65eaff] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
git bisect good e269f7acdc53623769da31135f60afeb3a65eaff
# bad: [ad234e2bac274a43c9fa540bde8cd9f0c627b71f] tty: serial: meson: Drop the legacy compatible strings and clock code
git bisect bad ad234e2bac274a43c9fa540bde8cd9f0c627b71f
# good: [c66453ce8af8bac78a72ba4e21fd9a86720127d7] tty: fix kernel-doc in n_tty.c
git bisect good c66453ce8af8bac78a72ba4e21fd9a86720127d7
# good: [0882b473b084df31288003b3bee974aabac9dcf9] tty: serial: samsung: Enable console as module
git bisect good 0882b473b084df31288003b3bee974aabac9dcf9
# bad: [b4a29b94804c4774f22555651296b838df6ec0e4] serial: 8250: Move Alpha-specific quirk out of the core
git bisect bad b4a29b94804c4774f22555651296b838df6ec0e4
# good: [e822b4973f49015e1c6f63b91c8641ed9bfaf229] tty/ldsem: Fix syntax errors in comments
git bisect good e822b4973f49015e1c6f63b91c8641ed9bfaf229
# good: [fb09d0ac07725b442b32dbf53f0ab0bea54804e9] tty: Fix the keyboard led light display problem
git bisect good fb09d0ac07725b442b32dbf53f0ab0bea54804e9
# bad: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
git bisect bad 5021d709b31b8a14317998a33cbc78be0de9ab30
# good: [adbfddc757aec1ed54ccb35c4a7ca9170df827e0] docs/driver-api: Replace a comma in the n_gsm.rst with a double colon
git bisect good adbfddc757aec1ed54ccb35c4a7ca9170df827e0

Quoted 8 lines

# first bad commit: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
And, indeed reverting 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") on top of 23a46422c561 ("Merge tag 'net-5.17-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") fixes the problem for me.
This is seen on every boot and I will be happy to test any patch.

Thanks for the report.

To be sure this issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot:

#regzbot ^introduced 5021d709b31b
#regzbot title serial: boot message completely garbled with rpi4 serial port #regzbot ignore-activity

Reminder: when fixing the issue, please add a 'Link:' tag with the URL to the report (the parent of this mail) as explained in 'Documentation/process/submitting-patches.rst'. Regzbot then will automatically mark the regression as resolved once the fix lands in the appropriate tree. For more details about regzbot see footer.

Sending this to everyone that got the initial report, to make all aware of the tracking. I also hope that messages like this motivate people to directly get at least the regression mailing list and ideally even regzbot involved when dealing with regressions, as messages like this wouldn't be needed then.

Don't worry, I'll send further messages wrt to this regression just to the lists (with a tag in the subject so people can filter them away), as long as they are intended just for regzbot. With a bit of luck no such messages will be needed anyway.

Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat)

P.S.: As a Linux kernel regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them. Unfortunately therefore I sometimes will get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me about it in a public reply, that's in everyone's interest.

BTW, I have no personal interest in this issue, which is tracked using regzbot, my Linux kernel regression tracking bot
(https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting this mail to get things rolling again and hence don't need to be CC on all further activities wrt to this regression.

---
Additional information about regzbot:

If you want to know more about regzbot, check out its web-interface, the getting start guide, and/or the references documentation:

https://linux-regtracking.leemhuis.info/regzbot/
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md

The last two documents will explain how you can interact with regzbot yourself if your want to.

Hint for reporters: when reporting a regression it's in your interest to tell #regzbot about it in the report, as that will ensure the regression gets on the radar of regzbot and the regression tracker. That's in your interest, as they will make sure the report won't fall through the cracks unnoticed.

Hint for developers: you normally don't need to care about regzbot once it's involved. Fix the issue as you normally would, just remember to include a 'Link:' tag to the report in the commit message, as explained in Documentation/process/submitting-patches.rst
That aspect was recently was made more explicit in commit 1f57bd42b77c:
https://git.kernel.org/linus/1f57bd42b77c

Greg Kroah-Hartman

maintainer

2022-01-28 07:15 UTC #2 lore raw

In reply to Sudip Mukherjee

Quoted 35 lines · Sudip Mukherjee

Hi Wander,
Not sure if this has been reported before but since last few weeks I am seeing a problem with the rpi4 serial port on my test setup. The initial boot message will be completely garbled as you can see at:
https://lava.qa.codethink.co.uk/scheduler/job/543#L380.
The last good boot was https://lava.qa.codethink.co.uk/scheduler/job/540#L390.
The bisect log:
# bad: [455e73a07f6e288b0061dfcf4fcf54fa9fe06458] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
# good: [7e7b69654724c72bd3219b71f58937845dca0b2b] Merge tag 'dma-mapping-5.17' of git://git.infradead.org/users/hch/dma-mapping
git bisect start '455e73a07f6e288b0061dfcf4fcf54fa9fe06458' '7e7b69654724c72bd3219b71f58937845dca0b2b'
# bad: [342465f5337f7bd5b8bd3b6f939ac12b620cbb43] Merge tag 'tty-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 342465f5337f7bd5b8bd3b6f939ac12b620cbb43
# good: [6dc69d3d0d18d587ab9d809fe060ba4417cf0279] Merge tag 'driver-core-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect good 6dc69d3d0d18d587ab9d809fe060ba4417cf0279
# good: [e269f7acdc53623769da31135f60afeb3a65eaff] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
git bisect good e269f7acdc53623769da31135f60afeb3a65eaff
# bad: [ad234e2bac274a43c9fa540bde8cd9f0c627b71f] tty: serial: meson: Drop the legacy compatible strings and clock code
git bisect bad ad234e2bac274a43c9fa540bde8cd9f0c627b71f
# good: [c66453ce8af8bac78a72ba4e21fd9a86720127d7] tty: fix kernel-doc in n_tty.c
git bisect good c66453ce8af8bac78a72ba4e21fd9a86720127d7
# good: [0882b473b084df31288003b3bee974aabac9dcf9] tty: serial: samsung: Enable console as module
git bisect good 0882b473b084df31288003b3bee974aabac9dcf9
# bad: [b4a29b94804c4774f22555651296b838df6ec0e4] serial: 8250: Move Alpha-specific quirk out of the core
git bisect bad b4a29b94804c4774f22555651296b838df6ec0e4
# good: [e822b4973f49015e1c6f63b91c8641ed9bfaf229] tty/ldsem: Fix syntax errors in comments
git bisect good e822b4973f49015e1c6f63b91c8641ed9bfaf229
# good: [fb09d0ac07725b442b32dbf53f0ab0bea54804e9] tty: Fix the keyboard led light display problem
git bisect good fb09d0ac07725b442b32dbf53f0ab0bea54804e9
# bad: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
git bisect bad 5021d709b31b8a14317998a33cbc78be0de9ab30
# good: [adbfddc757aec1ed54ccb35c4a7ca9170df827e0] docs/driver-api: Replace a comma in the n_gsm.rst with a double colon
git bisect good adbfddc757aec1ed54ccb35c4a7ca9170df827e0

Quoted 6 lines

# first bad commit: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
And, indeed reverting 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") on top of 23a46422c561 ("Merge tag 'net-5.17-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") fixes the problem for me.

Thanks, but this is already reverted in my tree and will go to Linus later today.

greg k-h

Thorsten Leemhuis

maintainer

2022-01-28 07:47 UTC #3 lore raw

Re: Regression with 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") #forregzbot

Top-posting for once, to make this easy accessible to everyone.

For the record:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-linus&id=6a7b9f002eca6788d346c16a6ff0c218b41f8d1d

#regzbot fixed-by: 6a7b9f002eca67

TWIMC: this mail is primarily send for documentation purposes and for regzbot, my Linux kernel regression tracking bot. These mails usually contain '#forregzbot' in the subject, to make them easy to spot and filter.

Quoted 47 lines · Greg Kroah-Hartman

Quoted 35 lines · Sudip Mukherjee
Hi Wander,
Not sure if this has been reported before but since last few weeks I am seeing a problem with the rpi4 serial port on my test setup. The initial boot message will be completely garbled as you can see at:
https://lava.qa.codethink.co.uk/scheduler/job/543#L380.
The last good boot was https://lava.qa.codethink.co.uk/scheduler/job/540#L390.
The bisect log:
# bad: [455e73a07f6e288b0061dfcf4fcf54fa9fe06458] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
# good: [7e7b69654724c72bd3219b71f58937845dca0b2b] Merge tag 'dma-mapping-5.17' of git://git.infradead.org/users/hch/dma-mapping
git bisect start '455e73a07f6e288b0061dfcf4fcf54fa9fe06458' '7e7b69654724c72bd3219b71f58937845dca0b2b'
# bad: [342465f5337f7bd5b8bd3b6f939ac12b620cbb43] Merge tag 'tty-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 342465f5337f7bd5b8bd3b6f939ac12b620cbb43
# good: [6dc69d3d0d18d587ab9d809fe060ba4417cf0279] Merge tag 'driver-core-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect good 6dc69d3d0d18d587ab9d809fe060ba4417cf0279
# good: [e269f7acdc53623769da31135f60afeb3a65eaff] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
git bisect good e269f7acdc53623769da31135f60afeb3a65eaff
# bad: [ad234e2bac274a43c9fa540bde8cd9f0c627b71f] tty: serial: meson: Drop the legacy compatible strings and clock code
git bisect bad ad234e2bac274a43c9fa540bde8cd9f0c627b71f
# good: [c66453ce8af8bac78a72ba4e21fd9a86720127d7] tty: fix kernel-doc in n_tty.c
git bisect good c66453ce8af8bac78a72ba4e21fd9a86720127d7
# good: [0882b473b084df31288003b3bee974aabac9dcf9] tty: serial: samsung: Enable console as module
git bisect good 0882b473b084df31288003b3bee974aabac9dcf9
# bad: [b4a29b94804c4774f22555651296b838df6ec0e4] serial: 8250: Move Alpha-specific quirk out of the core
git bisect bad b4a29b94804c4774f22555651296b838df6ec0e4
# good: [e822b4973f49015e1c6f63b91c8641ed9bfaf229] tty/ldsem: Fix syntax errors in comments
git bisect good e822b4973f49015e1c6f63b91c8641ed9bfaf229
# good: [fb09d0ac07725b442b32dbf53f0ab0bea54804e9] tty: Fix the keyboard led light display problem
git bisect good fb09d0ac07725b442b32dbf53f0ab0bea54804e9
# bad: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
git bisect bad 5021d709b31b8a14317998a33cbc78be0de9ab30
# good: [adbfddc757aec1ed54ccb35c4a7ca9170df827e0] docs/driver-api: Replace a comma in the n_gsm.rst with a double colon
git bisect good adbfddc757aec1ed54ccb35c4a7ca9170df827e0
Quoted 6 lines
# first bad commit: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
And, indeed reverting 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") on top of 23a46422c561 ("Merge tag 'net-5.17-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") fixes the problem for me.
Thanks, but this is already reverted in my tree and will go to Linus later today.
greg k-h

Wander Costa

2022-01-28 12:31 UTC #4 lore raw

In reply to Sudip Mukherjee

Quoted 36 lines · Sudip Mukherjee

Hi Wander,
Not sure if this has been reported before but since last few weeks I am seeing a problem with the rpi4 serial port on my test setup. The initial boot message will be completely garbled as you can see at:
https://lava.qa.codethink.co.uk/scheduler/job/543#L380.
The last good boot was https://lava.qa.codethink.co.uk/scheduler/job/540#L390.
The bisect log:
# bad: [455e73a07f6e288b0061dfcf4fcf54fa9fe06458] Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
# good: [7e7b69654724c72bd3219b71f58937845dca0b2b] Merge tag 'dma-mapping-5.17' of git://git.infradead.org/users/hch/dma-mapping
git bisect start '455e73a07f6e288b0061dfcf4fcf54fa9fe06458' '7e7b69654724c72bd3219b71f58937845dca0b2b'
# bad: [342465f5337f7bd5b8bd3b6f939ac12b620cbb43] Merge tag 'tty-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 342465f5337f7bd5b8bd3b6f939ac12b620cbb43
# good: [6dc69d3d0d18d587ab9d809fe060ba4417cf0279] Merge tag 'driver-core-5.17-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect good 6dc69d3d0d18d587ab9d809fe060ba4417cf0279
# good: [e269f7acdc53623769da31135f60afeb3a65eaff] staging: r8188eu: remove the private ioctl "wps_assoc_req_ie"
git bisect good e269f7acdc53623769da31135f60afeb3a65eaff
# bad: [ad234e2bac274a43c9fa540bde8cd9f0c627b71f] tty: serial: meson: Drop the legacy compatible strings and clock code
git bisect bad ad234e2bac274a43c9fa540bde8cd9f0c627b71f
# good: [c66453ce8af8bac78a72ba4e21fd9a86720127d7] tty: fix kernel-doc in n_tty.c
git bisect good c66453ce8af8bac78a72ba4e21fd9a86720127d7
# good: [0882b473b084df31288003b3bee974aabac9dcf9] tty: serial: samsung: Enable console as module
git bisect good 0882b473b084df31288003b3bee974aabac9dcf9
# bad: [b4a29b94804c4774f22555651296b838df6ec0e4] serial: 8250: Move Alpha-specific quirk out of the core
git bisect bad b4a29b94804c4774f22555651296b838df6ec0e4
# good: [e822b4973f49015e1c6f63b91c8641ed9bfaf229] tty/ldsem: Fix syntax errors in comments
git bisect good e822b4973f49015e1c6f63b91c8641ed9bfaf229
# good: [fb09d0ac07725b442b32dbf53f0ab0bea54804e9] tty: Fix the keyboard led light display problem
git bisect good fb09d0ac07725b442b32dbf53f0ab0bea54804e9
# bad: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
git bisect bad 5021d709b31b8a14317998a33cbc78be0de9ab30
# good: [adbfddc757aec1ed54ccb35c4a7ca9170df827e0] docs/driver-api: Replace a comma in the n_gsm.rst with a double colon
git bisect good adbfddc757aec1ed54ccb35c4a7ca9170df827e0

Quoted 9 lines

# first bad commit: [5021d709b31b8a14317998a33cbc78be0de9ab30] tty: serial: Use fifo in 8250 console driver
And, indeed reverting 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") on top of 23a46422c561 ("Merge tag 'net-5.17-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") fixes the problem for me.
This is seen on every boot and I will be happy to test any patch.

Hi Sudip,

Thanks for the report. As Greg said, the patch has been reverted. In the meantime, could you please apply this patch and report if the problem still happens:

(quoted diff) +0 -0

b/drivers/tty/serial/8250/8250_port.c
index 2abb3de11a48..d3a93e5d55f7 100644

drivers/tty/serial/8250/8250_port.c +0 -0

@@ -3343,7 +3343,7 @@ static void serial8250_console_fifo_write(struct

uart_8250_port *up,

 {
        int i;
        const char *end = s + count;
-       unsigned int fifosize = up->port.fifosize;
+       unsigned int fifosize = up->tx_loadsz;
        bool cr_sent = false;

        while (s != end) {
@@ -3409,8 +3409,8 @@ void serial8250_console_write(struct
uart_8250_port *up, const char *s,
        }

        use_fifo = (up->capabilities & UART_CAP_FIFO) &&
-               port->fifosize > 1 &&
-               (serial_port_in(port, UART_FCR) & UART_FCR_ENABLE_FIFO) &&
+               up->tx_loadsz > 1 &&
+               (up->fcr & UART_FCR_ENABLE_FIFO) &&

/*
* After we put a data in the fifo, the controller will send
* it regardless of the CTS state. Therefore, only use fifo

Quoted 5 lines

--
Regards
Sudip

Sudip Mukherjee

author

2022-01-31 12:59 UTC #5 lore raw

Hi Wander,

Quoted 6 lines · Wander Costa

Quoted 3 lines · Sudip Mukherjee
Hi Wander,

<snip>

Quoted 4 lines

Thanks for the report. As Greg said, the patch has been reverted. In the meantime, could you please apply this patch and report if the problem still happens:

Thanks for the patch, and I can confirm after applying the patch the problem is not there any more.
Log at https://lava.qa.codethink.co.uk/scheduler/job/602

Signature · 2 lines

Regards
Sudip

Wander Costa

2022-01-31 13:23 UTC #6 lore raw

Quoted 14 lines · Sudip Mukherjee

Hi Wander,
Quoted 6 lines · Wander Costa
Quoted 3 lines · Sudip Mukherjee
Hi Wander,
<snip>
Quoted 1 line

Quoted 8 lines

Quoted 3 lines
Thanks for the report. As Greg said, the patch has been reverted. In the meantime, could you please apply this patch and report if the problem still happens:
Thanks for the patch, and I can confirm after applying the patch the problem is not there any more.
Log at https://lava.qa.codethink.co.uk/scheduler/job/602

Thanks for testing!

Quoted 5 lines

--
Regards
Sudip