Skip to contentSkip to conversation

add i2c support for mt8186

PATCH Applied Kewei Xu 3 participants 9 messages Jan 25, 2022 – Feb 7, 2022

Subsystems (4)
lore
Share & tools
lore

Kewei Xu

author
#0 lore raw

v2 cover add i2c support for mt8186

V1:
Add i2c compatible for MT8186. Compare to MT8192 i2c controller, MT8186 doesn't need handshake signal with apdma.

Kewei Xu (2):
dt-bindings: i2c: update bindings for MT8186 SoC
i2c: mediatek: Add i2c compatible for Mediatek MT8186

 .../devicetree/bindings/i2c/i2c-mt65xx.txt         |  1 +
 drivers/i2c/busses/i2c-mt65xx.c                    | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

--
2.18.0

author
#1 lore raw

PATCH v2 1/2 dt-bindings: i2c: update bindings for MT8186 SoC

Add a DT binding documentation for the MT8186 soc.

---
 Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt +1 -0
index 5ea216ae7084..88f74a3c81ec 100644
@@ -14,6 +14,7 @@ Required properties:
       "mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek MT7629
       "mediatek,mt8173-i2c": for MediaTek MT8173
       "mediatek,mt8183-i2c": for MediaTek MT8183
+      "mediatek,mt8186-i2c": for MediaTek MT8186
       "mediatek,mt8192-i2c": for MediaTek MT8192
       "mediatek,mt8195-i2c", "mediatek,mt8192-i2c": for MediaTek MT8195
       "mediatek,mt8516-i2c", "mediatek,mt2712-i2c": for MediaTek MT8516
Signature · 1 line
2.25.1
maintainer Reviewed-by on v2 1/2
#2 lore raw

Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC

Quoted 3 lines · Kewei Xu

Add a DT binding documentation for the MT8186 soc.

Quoted 12 lines
---
 Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt +0 -0
index 5ea216ae7084..88f74a3c81ec 100644
@@ -14,6 +14,7 @@ Required properties:
       "mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek

MT7629

Quoted 8 lines
       "mediatek,mt8173-i2c": for MediaTek MT8173
       "mediatek,mt8183-i2c": for MediaTek MT8183
+      "mediatek,mt8186-i2c": for MediaTek MT8186
       "mediatek,mt8192-i2c": for MediaTek MT8192
       "mediatek,mt8195-i2c", "mediatek,mt8192-i2c": for MediaTek
MT8195
       "mediatek,mt8516-i2c", "mediatek,mt2712-i2c": for MediaTek

MT8516

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Applied
#3 lore raw

Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC

In reply to Kewei Xu
Quoted 3 lines · Kewei Xu

Add a DT binding documentation for the MT8186 soc.

Applied to for-next, thanks! But you forgot to add the ack from Rob which he gave when you sent v1.

author
#4 lore raw

Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC

Quoted 8 lines · Wolfram Sang
Quoted 3 lines · Kewei Xu

Add a DT binding documentation for the MT8186 soc.

Applied to for-next, thanks! But you forgot to add the ack from Rob which he gave when you sent v1.

Hi,

I'm sorry for my mistake and thank you very much for your reminder. I will pay attention to this problem next time.

Thanks
Kewei.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

author
#5 lore raw

PATCH v2 2/2 i2c: mediatek: Add i2c compatible for Mediatek MT8186

In reply to Kewei Xu

Add i2c compatible for MT8186. Compare to MT8192 i2c controller, MT8186 doesn't need handshake signal witch apdma.

---
 drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/i2c/busses/i2c-mt65xx.c +14 -0
index 9ea427f53083..aa4d21838e14 100644
@@ -397,6 +397,19 @@ static const struct mtk_i2c_compatible mt8183_compat = {
 	.max_dma_support = 33,
 };
 
+static const struct mtk_i2c_compatible mt8186_compat = {
+	.regs = mt_i2c_regs_v2,
+	.pmic_i2c = 0,
+	.dcm = 0,
+	.auto_restart = 1,
+	.aux_len_reg = 1,
+	.timing_adjust = 1,
+	.dma_sync = 0,
+	.ltiming_adjust = 1,
+	.apdma_sync = 0,
+	.max_dma_support = 36,
+};
+
 static const struct mtk_i2c_compatible mt8192_compat = {
 	.quirks = &mt8183_i2c_quirks,
 	.regs = mt_i2c_regs_v2,
@@ -418,6 +431,7 @@ static const struct of_device_id mtk_i2c_of_match[] = {
 	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
 	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
 	{ .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat },
+	{ .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat },
 	{ .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat },
 	{}
 };
Signature · 7 lines
2.25.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
maintainer Reviewed-by on v2 2/2
#6 lore raw

Re: [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186

Quoted 4 lines · Kewei Xu

Add i2c compatible for MT8186. Compare to MT8192 i2c controller, MT8186 doesn't need handshake signal witch apdma.

Quoted 44 lines
---
 drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/i2c/busses/i2c-mt65xx.c +13 -0
index 9ea427f53083..aa4d21838e14 100644
@@ -397,6 +397,19 @@ static const struct mtk_i2c_compatible
 mt8183_compat = {
 	.max_dma_support = 33,
 };
 
+static const struct mtk_i2c_compatible mt8186_compat = {
+	.regs = mt_i2c_regs_v2,
+	.pmic_i2c = 0,
+	.dcm = 0,
+	.auto_restart = 1,
+	.aux_len_reg = 1,
+	.timing_adjust = 1,
+	.dma_sync = 0,
+	.ltiming_adjust = 1,
+	.apdma_sync = 0,
+	.max_dma_support = 36,
+};
+
 static const struct mtk_i2c_compatible mt8192_compat = {
 	.quirks = &mt8183_i2c_quirks,
drivers/i2c/busses/i2c-mt65xx.c +0 -0
 	.regs = mt_i2c_regs_v2,
@@ -418,6 +431,7 @@ static const struct of_device_id
 mtk_i2c_of_match[] = {
 	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat
 },
 	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat
 },
 	{ .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat

},

drivers/i2c/busses/i2c-mt65xx.c +1 -0
+	{ .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat

},
{ .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat
},
{}
};

Applied
#7 lore raw

Re: [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186

In reply to Kewei Xu
Quoted 4 lines · Kewei Xu

Add i2c compatible for MT8186. Compare to MT8192 i2c controller, MT8186 doesn't need handshake signal witch apdma.

Applied to for-next, thanks!

#8 lore raw
In reply to Kewei Xu
Quoted 3 lines · Kewei Xu

V1:
Add i2c compatible for MT8186. Compare to MT8192 i2c controller, MT8186 doesn't need handshake signal with apdma.

A description of what has changed in v2 would have been helpful. Please add it next time.