Skip to contentSkip to conversation

SCTP tests in LTP vs. on github.com/sctp

RFC Petr Vorel 3 participants 5 messages Feb 2, 2022 – Feb 3, 2022 SCTP protocol

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

Hi all,

SCTP tests lksctp-tools [1] are also in LTP [2].
IMHO it's not worth to have it on both places.

lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?

Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4], maybe worth to be backported to lksctp-tools? Frankly speaking even being older version the LTP code looks to me better. One test was even rewritten to LTP new
C API [5] in order to apply more improvements [6].

BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and rewrite tests into it. But are these tests still relevant? (is it worth of work?)

Kind regards,
Petr

[1] https://github.com/sctp/lksctp-tools
[2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
[3] https://github.com/sctp
[4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
[5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[7] https://github.com/linux-test-project/ltp/wiki/C-Test-API

#2 lore raw
In reply to Petr Vorel

Hi Petr,

Quoted 4 lines · Petr Vorel

Hi all,

SCTP tests lksctp-tools [1] are also in LTP [2].
IMHO it's not worth to have it on both places.

Agree. I wasn't aware of the copy in LTP, btw.

A question I have now is, is getting more exposure because it is in LTP? As in, does it get executed periodically by bots somewhere?

Quoted 11 lines

lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?

Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4], maybe worth to be backported to lksctp-tools? Frankly speaking even being older version the LTP code looks to me better. One test was even rewritten to LTP new
C API [5] in order to apply more improvements [6].

BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and rewrite tests into it. But are these tests still relevant? (is it worth of work?)

These are nice tips, thanks. We certainly can have a take on them.

Best regards,
Marcelo

Quoted 11 lines

Kind regards,
Petr

[1] https://github.com/sctp/lksctp-tools
[2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
[3] https://github.com/sctp
[4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
[5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[7] https://github.com/linux-test-project/ltp/wiki/C-Test-API

author
#3 lore raw

Hi Marcelo,

Quoted 5 lines

Hi Petr,

Quoted 1 line · Petr Vorel

Hi all,

Quoted 7 lines
Quoted 2 lines

SCTP tests lksctp-tools [1] are also in LTP [2].
IMHO it's not worth to have it on both places.

Agree. I wasn't aware of the copy in LTP, btw.

A question I have now is, is getting more exposure because it is in LTP? As in, does it get executed periodically by bots somewhere?

Maybe yes, hard to tell. Not sure even how many people even run SCTP tests included by LTP. We could ask at automated-testing [8] (embedded people + hopefully folks from KernelCI [9]) or send the update there. We'd also put a link in to remaining location in git commit message if agree to remove it from LTP.

Quoted 7 lines
Quoted 6 lines

lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?

Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4], maybe worth to be backported to lksctp-tools? Frankly speaking even being older version the LTP code looks to me better. One test was even rewritten to LTP new
C API [5] in order to apply more improvements [6].

Quoted 5 lines
Quoted 3 lines

BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and rewrite tests into it. But are these tests still relevant? (is it worth of work?)

These are nice tips, thanks. We certainly can have a take on them.

Yw.

Kind regards,
Petr

Quoted 14 lines

Best regards,
Marcelo

Quoted 10 lines

Kind regards,
Petr

[1] https://github.com/sctp/lksctp-tools
[2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
[3] https://github.com/sctp
[4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
[5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
[7] https://github.com/linux-test-project/ltp/wiki/C-Test-API

[8] https://lists.yoctoproject.org/g/automated-testing/
[9] https://foundation.kernelci.org/

#4 lore raw
In reply to Marcelo Ricardo Leitner

Hi!

Quoted 7 lines
Quoted 2 lines

SCTP tests lksctp-tools [1] are also in LTP [2].
IMHO it's not worth to have it on both places.

Agree. I wasn't aware of the copy in LTP, btw.

A question I have now is, is getting more exposure because it is in LTP? As in, does it get executed periodically by bots somewhere?

Generally I think that not many run the LTP network tests, but it seems that the intel 0-day has at least a job definition for the LTP sctp tests:

https://github.com/intel/lkp-tests/blob/3fece75132266f680047f4e1740b39c5b3faabbf/jobs/ltp-stress.yaml

Not sure how often of if they even run it though.

Signature · 2 lines
Cyril Hrubis
[email protected]