Skip to contentSkip to conversation

mfd: arizona: Add missing statics to the of_match_tables

PATCH RESEND Applied Charles Keepax 2 participants 2 messages Jan 4, 2022 – Feb 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 mfd: arizona: Add missing statics to the of_match_tables

When the match tables were split for I2C and SPI a static should have been added since the tables are no longer exported.

Fixes 3f65555c417c ("mfd: arizona: Split of_match table into I2C and SPI versions")
---
 drivers/mfd/arizona-i2c.c | 2 +-
 drivers/mfd/arizona-spi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/arizona-i2c.c +1 -1
index 3ed810e81f631..6d83e6b9a692d 100644
@@ -105,7 +105,7 @@ static const struct i2c_device_id arizona_i2c_id[] = {
 MODULE_DEVICE_TABLE(i2c, arizona_i2c_id);
 
 #ifdef CONFIG_OF
-const struct of_device_id arizona_i2c_of_match[] = {
+static const struct of_device_id arizona_i2c_of_match[] = {
 	{ .compatible = "wlf,wm5102", .data = (void *)WM5102 },
 	{ .compatible = "wlf,wm5110", .data = (void *)WM5110 },
 	{ .compatible = "wlf,wm8280", .data = (void *)WM8280 },
drivers/mfd/arizona-spi.c +1 -1
index 9fe06dda37829..98c87d3bd00fa 100644
@@ -226,7 +226,7 @@ static const struct spi_device_id arizona_spi_ids[] = {
 MODULE_DEVICE_TABLE(spi, arizona_spi_ids);
 
 #ifdef CONFIG_OF
-const struct of_device_id arizona_spi_of_match[] = {
+static const struct of_device_id arizona_spi_of_match[] = {
 	{ .compatible = "wlf,wm5102", .data = (void *)WM5102 },
 	{ .compatible = "wlf,wm5110", .data = (void *)WM5110 },
 	{ .compatible = "wlf,wm8280", .data = (void *)WM8280 },
Signature · 1 line
2.11.0
Applied
#1 lore raw
Quoted 10 lines · Charles Keepax

When the match tables were split for I2C and SPI a static should have been added since the tables are no longer exported.

Fixes 3f65555c417c ("mfd: arizona: Split of_match table into I2C and SPI versions")
---
 drivers/mfd/arizona-i2c.c | 2 +-
 drivers/mfd/arizona-spi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog