Staging: r8188eu: core: Avoid CamelCase: <bEnterPS>
PATCH 1/1 Staging: r8188eu: core: Avoid CamelCase: <bEnterPS>
Fixed a coding style issue.
--- drivers/staging/r8188eu/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/r8188eu/core/rtw_cmd.c +4 -4
@@ -880,7 +880,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan)static void traffic_status_watchdog (struct adapter *padapter) { -u8 bEnterPS; +u8 b_enter_ps;u8 bBusyTraffic = false, bTxBusyTraffic = false, bRxBusyTraffic = false;u8 bHigherBusyTraffic = false, bHigherBusyRxTraffic = false, bHigherBusyTxTraffic = false;struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -913,12 +913,12 @@ static void traffic_status_watchdog(struct adapter *padapter)/* check traffic for powersaving. */ if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + pmlmepriv->LinkDetectInfo.NumTxOkInPeriod) >8 ) || (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod >2 )) - bEnterPS = false; + b_enter_ps = false;else - bEnterPS = true; + b_enter_ps = true;/* LeisurePS only work in infra mode. */ -if (bEnterPS) +if (b_enter_ps)LPS_Enter (padapter);else LPS_Leave (padapter);
Signature · 1 line
2.29.0
Greg KH
maintainerQuoted 1 line · Leonardo Araujo
Fixed a coding style issue.
Please read the kernel documentation for how to write better subject lines and changelog texts. These need a lot of work, you can't just put the checkpatch message in the subject and then nothing in the changelog body.
Quoted 11 lines
Signed-off-by Leonardo Araujo <[email protected]>--- drivers/staging/r8188eu/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/r8188eu/core/rtw_cmd.c +0
-0
drivers/staging/r8188eu/core/rtw_cmd.c u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan) · line 883
Quoted 5 lines
drivers/staging/r8188eu/core/rtw_cmd.c +1
-1@@ -880,7 +880,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan)static void traffic_status_watchdog (struct adapter *padapter) { -u8 bEnterPS; +u8 b_enter_ps;
No, think about what you are changing here. Why keep the "b" at all? What does this variable name? Why was there a "b" to start with?
drivers/staging/r8188eu/core/rtw_cmd.c u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan) · line 884
Quoted 1 line
drivers/staging/r8188eu/core/rtw_cmd.c +0
-0u8 bBusyTraffic = false, bTxBusyTraffic = false, bRxBusyTraffic = false;
What about all of these other variables, why ignore them and not send a patch series to fix them all up?
Remember where the "b" comes from, this is "hungarian notation" and is trying to describe the type of the variable, which makes no sense in this century. Please do not keep it around for no reason at all.
thanks,
greg k-h
Mr. Greg,
first of all, thank you for your time and review. I am learning a lot from your responses since I started contributing, after I came across a YouTube video of one of your presentations on how to contribute to the Linux kernel. I will study the documentation more in depth and send a proper patch series as you requested.
Best regards,
Leonardo Araujo
Atenciosamente,
Eng. M.Sc. Leonardo A. de Araujo
Quoted 43 lines · Greg KH
Quoted 1 line · Leonardo Araujo
Fixed a coding style issue.
Please read the kernel documentation for how to write better subject lines and changelog texts. These need a lot of work, you can't just put the checkpatch message in the subject and then nothing in the changelog body.
Quoted 11 lines
Signed-off-by Leonardo Araujo <[email protected]>--- drivers/staging/r8188eu/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/r8188eu/core/rtw_cmd.c +0
-0drivers/staging/r8188eu/core/rtw_cmd.c u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan) · line 883
Quoted 5 lines
drivers/staging/r8188eu/core/rtw_cmd.c +1
-1@@ -880,7 +880,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan)static void traffic_status_watchdog (struct adapter *padapter) { -u8 bEnterPS; +u8 b_enter_ps;No, think about what you are changing here. Why keep the "b" at all? What does this variable name? Why was there a "b" to start with?
drivers/staging/r8188eu/core/rtw_cmd.c u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan) · line 884
Quoted 1 line
drivers/staging/r8188eu/core/rtw_cmd.c +0
-0u8 bBusyTraffic = false, bTxBusyTraffic = false, bRxBusyTraffic = false;What about all of these other variables, why ignore them and not send a patch series to fix them all up?
Remember where the "b" comes from, this is "hungarian notation" and is trying to describe the type of the variable, which makes no sense in this century. Please do not keep it around for no reason at all.
thanks,
greg k-h