Skip to contentSkip to conversation

lib/iov_iter: initialize "flags" in new pipe_buffer

PATCH Applied Max Kellermann 2 participants 2 messages Feb 21, 2022

Subsystems (4)
Stable branch VFS Library code Userspace copyin/copyout (uiovec)
lore
Share & tools
lore

Max Kellermann

author
#0 lore raw

PATCH 1/1 lib/iov_iter: initialize "flags" in new pipe_buffer

The functions copy_page_to_iter_pipe() and push_pipe() can both allocate a new pipe_buffer, but the "flags" member initializer is missing.

Fixes 241699cd72a8 ("new iov_iter flavour: pipe-backed")

To: Alexander Viro <[email protected]>
To: [email protected]
To: [email protected]

Cc [email protected]
Signed-off-by Max Kellermann <[email protected]>
---
 lib/iov_iter.c | 2 ++
 1 file changed, 2 insertions(+)
lib/iov_iter.c +2 -0
index b0e0acdf96c1..6dd5330f7a99 100644
@@ -414,6 +414,7 @@ static size_t copy_page_to_iter_pipe(struct page *page, size_t offset, size_t by
 		return 0;
 
 	buf->ops = &page_cache_pipe_buf_ops;
+	buf->flags = 0;
 	get_page(page);
 	buf->page = page;
 	buf->offset = offset;

@@ -577,6 +578,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
 			break;
 
 		buf->ops = &default_pipe_buf_ops;
+		buf->flags = 0;
 		buf->page = page;
 		buf->offset = 0;
 		buf->len = min_t(ssize_t, left, PAGE_SIZE);
Signature · 1 line
2.34.0