Skip to contentSkip to conversation

gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

PATCH Superseded Prathamesh Shete 5 participants 9 messages Feb 24, 2022 – Jan 11, 2023

Subsystems (2)
GPIO Tegra architecture support
lore
Share & tools
lore

Prathamesh Shete

author
#0 lore raw

PATCH 1/1 gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

From: Manish Bhardwaj <[email protected]>

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the irq hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-tegra186.c +1 -0
index d38980b9923a..c1e9dd8c78f8 100644
@@ -563,6 +563,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
 static const struct of_device_id tegra186_pmc_of_match[] = {
 	{ .compatible = "nvidia,tegra186-pmc" },
 	{ .compatible = "nvidia,tegra194-pmc" },
+	{ .compatible = "nvidia,tegra234-pmc" },
 	{ /* sentinel */ }
 };
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH v2 1/1 gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-tegra186.c +1 -0
index 54d9fa7da9c1..824a355ff27a 100644
@@ -669,6 +669,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
 static const struct of_device_id tegra186_pmc_of_match[] = {
 	{ .compatible = "nvidia,tegra186-pmc" },
 	{ .compatible = "nvidia,tegra194-pmc" },
+	{ .compatible = "nvidia,tegra234-pmc" },
 	{ /* sentinel */ }
 };
Signature · 1 line
2.17.1
author
#3 lore raw

Hi
Can you please help review this patch

Thanks
Prathamesh.

Quoted 36 lines

-----Original Message-----
From: Prathamesh Shete <[email protected]>
Sent: Tuesday, August 16, 2022 3:57 PM
To: [email protected]; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]; Jonathan Hunter <[email protected]>; [email protected]
Cc: Suresh Mangipudi <[email protected]>; Prathamesh Shete <[email protected]>; Manish Bhardwaj <[email protected]>
Subject: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-tegra186.c index renamed from drivers/gpio/gpio-tegra186.c +0 -0

54d9fa7da9c1..824a355ff27a 100644

drivers/gpio/gpio-tegra186.c +0 -0
@@ -669,6 +669,7 @@ static unsigned int

tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip, static const struct of_device_id tegra186_pmc_of_match[] = {

drivers/gpio/gpio-tegra186.c +1 -1
 	{ .compatible = "nvidia,tegra186-pmc" },
 	{ .compatible = "nvidia,tegra194-pmc" },
+	{ .compatible = "nvidia,tegra234-pmc" },
 	{ /* sentinel */ }
 };
 
--

2.17.1

maintainer Reviewed-by Tested-by
#5 lore raw

Hi Linus,

Quoted 8 lines · Linus Walleij
Quoted 5 lines · Prathamesh Shete

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
Quoted 6 lines
Reviewed-by Linus Walleij <[email protected]>

It also has Thierry's ACK from v1.

Yours,
Linus Walleij

I don't see this one in -next. Are you able to pick this up?

Reviewed-by Jon Hunter <[email protected]>
Tested-by Jon Hunter <[email protected]>

Thanks!
Jon

#6 lore raw
Quoted 13 lines · Jon Hunter
Quoted 12 lines · Linus Walleij
Quoted 5 lines · Prathamesh Shete

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
Reviewed-by Linus Walleij <[email protected]>

It also has Thierry's ACK from v1.

Quoted 8 lines
Quoted 2 lines

Yours,
Linus Walleij

I don't see this one in -next. Are you able to pick this up?

Reviewed-by Jon Hunter <[email protected]>
Tested-by Jon Hunter <[email protected]>

Bartosz is queueing GPIO patches right now, but the mail has the wrong address for him.

I put the new mail address in To, so he can pick it up.

Yours,
Linus Walleij

#7 lore raw
Quoted 21 lines · Linus Walleij
Quoted 19 lines · Jon Hunter
Quoted 8 lines · Linus Walleij
Quoted 5 lines · Prathamesh Shete

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
Quoted 6 lines
Reviewed-by Linus Walleij <[email protected]>

It also has Thierry's ACK from v1.

Yours,
Linus Walleij

I don't see this one in -next. Are you able to pick this up?

Quoted 8 lines
Quoted 2 lines
Reviewed-by Jon Hunter <[email protected]>
Tested-by Jon Hunter <[email protected]>

Bartosz is queueing GPIO patches right now, but the mail has the wrong address for him.

I put the new mail address in To, so he can pick it up.

Come on, my address changed 18 months ago, re-run get_maintainers.pl from time to time. :)

Now applied, thanks!

Bart

Acked-by on v2 1/1
#8 lore raw
In reply to Prathamesh Shete
Quoted 8 lines · Prathamesh Shete

Using this patch we are adding PMC compatible string for Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by Manish Bhardwaj <[email protected]>
Signed-off-by Prathamesh Shete <[email protected]>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)

I already acked this on v1, but here goes again, for patchwork:

Acked-by Thierry Reding <[email protected]>