Skip to contentSkip to conversation

dt-bindings: leds: Document mmc trigger

PATCH Applied Marek Vasut 3 participants 5 messages Feb 17, 2022 – Sep 21, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: leds: Document mmc trigger

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]
---
V2: Rebase on next-20220217

---
 .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +21 -18
index 328952d7acbbc..3c14a98430e19 100644
@@ -79,24 +79,27 @@ properties:
       the LED.
     $ref: /schemas/types.yaml#/definitions/string
 
-    enum:
-        # LED will act as a back-light, controlled by the framebuffer system
-      - backlight
-        # LED will turn on (but for leds-gpio see "default-state" property in
-        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
-      - default-on
-        # LED "double" flashes at a load average based rate
-      - heartbeat
-        # LED indicates disk activity
-      - disk-activity
-        # LED indicates IDE disk activity (deprecated), in new implementations
-        # use "disk-activity"
-      - ide-disk
-        # LED flashes at a fixed, configurable rate
-      - timer
-        # LED alters the brightness for the specified duration with one software
-        # timer (requires "led-pattern" property)
-      - pattern
+    oneOf:
+      - enum:
+            # LED will act as a back-light, controlled by the framebuffer system
+          - backlight
+            # LED will turn on (but for leds-gpio see "default-state" property in
+            # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
+          - default-on
+            # LED "double" flashes at a load average based rate
+          - heartbeat
+            # LED indicates disk activity
+          - disk-activity
+            # LED indicates IDE disk activity (deprecated), in new implementations
+            # use "disk-activity"
+          - ide-disk
+            # LED flashes at a fixed, configurable rate
+          - timer
+            # LED alters the brightness for the specified duration with one software
+            # timer (requires "led-pattern" property)
+          - pattern
+        # LED is triggered by SD/MMC activity
+      - pattern: "^mmc[0-9]+$"
 
   led-pattern:
     description: |
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 11 lines · Marek Vasut

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]
---
V2: Rebase on next-20220217

Why? Nobody can apply patches to linux-next. Is there something in next you are dependent on that you didn't tell us about?

Quoted 58 lines
---
 .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +21 -18
index 328952d7acbbc..3c14a98430e19 100644
@@ -79,24 +79,27 @@ properties:
       the LED.
     $ref: /schemas/types.yaml#/definitions/string
 
-    enum:
-        # LED will act as a back-light, controlled by the framebuffer system
-      - backlight
-        # LED will turn on (but for leds-gpio see "default-state" property in
-        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
-      - default-on
-        # LED "double" flashes at a load average based rate
-      - heartbeat
-        # LED indicates disk activity
-      - disk-activity
-        # LED indicates IDE disk activity (deprecated), in new implementations
-        # use "disk-activity"
-      - ide-disk
-        # LED flashes at a fixed, configurable rate
-      - timer
-        # LED alters the brightness for the specified duration with one software
-        # timer (requires "led-pattern" property)
-      - pattern
+    oneOf:
+      - enum:
+            # LED will act as a back-light, controlled by the framebuffer system
+          - backlight
+            # LED will turn on (but for leds-gpio see "default-state" property in
+            # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
+          - default-on
+            # LED "double" flashes at a load average based rate
+          - heartbeat
+            # LED indicates disk activity
+          - disk-activity
+            # LED indicates IDE disk activity (deprecated), in new implementations
+            # use "disk-activity"
+          - ide-disk
+            # LED flashes at a fixed, configurable rate
+          - timer
+            # LED alters the brightness for the specified duration with one software
+            # timer (requires "led-pattern" property)
+          - pattern
+        # LED is triggered by SD/MMC activity
+      - pattern: "^mmc[0-9]+$"
 
   led-pattern:
     description: |
Signature · 1 line
2.34.1
#2 lore raw
Quoted 13 lines · Rob Herring
Quoted 11 lines · Marek Vasut

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]
---
V2: Rebase on next-20220217

Quoted 2 lines

Why? Nobody can apply patches to linux-next. Is there something in next you are dependent on that you didn't tell us about?

It is just a convenience really, it is where the commits for all the mostly latest development exist in one place, so I can be reasonably sure the maintainer won't have trouble applying the patch on their tree due to some missing patch, and if I work also on driver stuff, I can be sure those drivers are also up-to-date-ish.

No, I don't think this patch specifically depends on anything in latest next.

maintainer Reviewed-by on v2 1/1
#3 lore raw
In reply to Marek Vasut
Quoted 8 lines · Marek Vasut

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>
Quoted 7 lines

To: [email protected]
---
V2: Rebase on next-20220217

---
 .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)
Applied
#4 lore raw
Quoted 17 lines · Rob Herring
Quoted 8 lines · Marek Vasut

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>
Quoted 7 lines

To: [email protected]
---
V2: Rebase on next-20220217

---
 .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)
Quoted 1 line

Thanks, applied.

best regards,
Pavel

Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.