5.15.27-rc1 review
Subsystems (5)
Greg Kroah-Hartman
maintainerPATCH 260/262 Revert "xfrm: xfrm_state_mtu should return at least 1280 for ipv6"
In reply to Greg Kroah-HartmanFrom: Jiri Bohac <[email protected]>
commit a6d95c5a628a09be129f25d5663a7e9db8261f51 upstream.
This reverts commit b515d2637276a3810d6595e10ab02c13bfd0b63a.
Commit b515d2637276a3810d6595e10ab02c13bfd0b63a ("xfrm: xfrm_state_mtu should return at least 1280 for ipv6") in v5.14 breaks the TCP MSS calculation in ipsec transport mode, resulting complete stalls of TCP connections. This happens when the (P)MTU is 1280 or slighly larger.
The desired formula for the MSS is:
MSS = (MTU - ESP_overhead) - IP header - TCP header
However, the above commit clamps the (MTU - ESP_overhead) to a minimum of 1280, turning the formula into
MSS = max(MTU - ESP overhead, 1280) - IP header - TCP header
With the (P)MTU near 1280, the calculated MSS is too large and the resulting TCP packets never make it to the destination because they are over the actual PMTU.
The above commit also causes suboptimal double fragmentation in xfrm tunnel mode, as described in
https://lore.kernel.org/netdev/[email protected]/
The original problem the above commit was trying to fix is now fixed by commit 6596a0229541270fb8d38d989f91b78838e5e9da ("xfrm: fix MTU regression").
--- include/net/xfrm.h | 1 - net/ipv4/esp4.c | 2 +- net/ipv6/esp6.c | 2 +- net/xfrm/xfrm_state.c | 14 ++------------ 4 files changed, 4 insertions(+), 15 deletions(-)
include/net/xfrm.h +0 -1
@@ -1567,7 +1567,6 @@ void xfrm_sad_getinfo(struct net *net, svoid xfrm_spd_getinfo (struct net *net,struct xfrmk_spdinfo *si);u32 xfrm_replay_seqhi (struct xfrm_state *x,__be32 net_seq);int xfrm_init_replay (struct xfrm_state *x); -u32 __xfrm_state_mtu (struct xfrm_state *x,int mtu);u32 xfrm_state_mtu (struct xfrm_state *x,int mtu);int __xfrm_init_state (struct xfrm_state *x,bool init_replay,bool offload);int xfrm_init_state (struct xfrm_state *x);
net/ipv4/esp4.c +1 -1
@@ -671,7 +671,7 @@ static int esp_output(struct xfrm_statestruct xfrm_dst *dst = (struct xfrm_dst *)skb_dst (skb);u32 padto; - padto =min (x->tfcpad,__xfrm_state_mtu (x, dst->child_mtu_cached)); + padto =min (x->tfcpad,xfrm_state_mtu (x, dst->child_mtu_cached));if (skb->len < padto) esp.tfclen = padto - skb->len; }
net/ipv6/esp6.c +1 -1
@@ -708,7 +708,7 @@ static int esp6_output(struct xfrm_statestruct xfrm_dst *dst = (struct xfrm_dst *)skb_dst (skb);u32 padto; - padto =min (x->tfcpad,__xfrm_state_mtu (x, dst->child_mtu_cached)); + padto =min (x->tfcpad,xfrm_state_mtu (x, dst->child_mtu_cached));if (skb->len < padto) esp.tfclen = padto - skb->len; }
net/xfrm/xfrm_state.c +2 -12
@@ -2571,7 +2571,7 @@ void xfrm_state_delete_tunnel(struct xfr }EXPORT_SYMBOL (xfrm_state_delete_tunnel); -u32 __xfrm_state_mtu (struct xfrm_state *x,int mtu) +u32 xfrm_state_mtu (struct xfrm_state *x,int mtu) {const struct xfrm_type *type =READ_ONCE (x->type);struct crypto_aead *aead;
@@ -2602,17 +2602,7 @@ u32 __xfrm_state_mtu(struct xfrm_state *return ((mtu - x->props.header_len -crypto_aead_authsize (aead) - net_adj) & ~(blksize -1 )) + net_adj -2 ; } -EXPORT_SYMBOL_GPL (__xfrm_state_mtu); - -u32 xfrm_state_mtu (struct xfrm_state *x,int mtu) -{ - mtu =__xfrm_state_mtu (x, mtu); - -if (x->props.family ==AF_INET6 && mtu <IPV6_MIN_MTU ) -return IPV6_MIN_MTU ; - -return mtu; -} +EXPORT_SYMBOL_GPL (xfrm_state_mtu);int __xfrm_init_state (struct xfrm_state *x,bool init_replay,bool offload) {
Greg Kroah-Hartman
maintainerPATCH 261/262 proc: fix documentation and description of pagemap
In reply to Greg Kroah-HartmanFrom: Yun Zhou <[email protected]>
commit dd21bfa425c098b95ca86845f8e7d1ec1ddf6e4a upstream.
Since bit 57 was exported for uffd-wp write-protected (commitfb8e37f35a2f: "mm/pagemap: export uffd-wp protection information"), fixing it can reduce some unnecessary confusion.
--- Documentation/admin-guide/mm/pagemap.rst | 2 +- fs/proc/task_mmu.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/admin-guide/mm/pagemap.rst +1 -1
@@ -23,7 +23,7 @@ There are four components to pagemap: * Bit 56 page exclusively mapped (since 4.2) * Bit 57 pte is uffd-wp write-protected (since 5.13) (see :ref:`Documentation/admin-guide/mm/userfaultfd.rst <userfaultfd>`) - * Bits 57-60 zero + * Bits 58-60 zero * Bit 61 page is file-page or shared-anon (since 3.5) * Bit 62 page swapped * Bit 63 page present
fs/proc/task_mmu.c +2 -1
@@ -1582,7 +1582,8 @@ static const struct mm_walk_ops pagemap_* Bits 5-54 swap offset if swapped * Bit 55 pte is soft-dirty (see Documentation/admin-guide/mm/soft-dirty.rst) * Bit 56 page exclusively mapped -* Bits 57-60 zero +* Bit 57 pte is uffd-wp write-protected +* Bits 58-60 zero * Bit 61 page is file-page or shared-anon * Bit 62 page swapped * Bit 63 page present
Greg Kroah-Hartman
maintainerPATCH 262/262 KVM: x86/mmu: Passing up the error state of mmu_alloc_shadow_roots()
In reply to Greg Kroah-HartmanFrom: Like Xu <[email protected]>
commit c6c937d673aaa1d603f62f134e1ca9c173eeeed3 upstream.
Just like on the optional mmu_alloc_direct_roots() path, once shadow path reaches "r = -EIO" somewhere, the caller needs to know the actual state in order to enter error handling and avoid something worse.
Message-Id: <[email protected]>
--- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu/mmu.c +1 -1
@@ -3579,7 +3579,7 @@ set_root_pgd: out_unlock:write_unlock (&vcpu->kvm->mmu_lock); -return 0 ; +return r; }static int mmu_alloc_special_roots (struct kvm_vcpu *vcpu)
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.o drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:30:10: fatal error: dml/dcn20/dcn20_fpu.h: No such file or directory
30 | #include "dml/dcn20/dcn20_fpu.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Culprit is "drm-amd-display-move-fpu-associated-dcn301-code-to-d.patch"
Looking over the git history of the dml/dnc20 directory I think the correct fix would be to also apply upstream commit ee37341199c61558b73113659695c90bf4736eb2 aka "drm/amd/display: Re-arrange FPU code structure for dcn2x"
CC'ing Qingqing Zhuo for confirmation.
cheers
Holger
Quoted 12 lines · Holger Hoffstätte
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CC [M]
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.odrivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:30:10: fatal error:dml/dcn20/dcn20_fpu.h: No such file or directory
30 | #include "dml/dcn20/dcn20_fpu.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Quoted 7 lines
Culprit is "drm-amd-display-move-fpu-associated-dcn301-code-to-d.patch"
Looking over the git history of the dml/dnc20 directory I think the correct fix would be to also apply upstream commit
ee37341199c61558b73113659695c90bf4736eb2aka "drm/amd/display: Re-arrange FPU code structure for dcn2x"CC'ing Qingqing Zhuo for confirmation.
I can confirm that applying a modified ee37341199c6 fixes the issue. \o/ The hunk that refers to drivers/gpu/drm/amd/display/dc/dcn201 needs to be removed, since that directory (support for "cyan_skillfish") does not exist in 5.15.x.
cheers
Holger
Greg Kroah-Hartman
maintainerQuoted 19 lines · Holger Hoffstätte
Quoted 18 lines · Holger Hoffstätte
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CC [M]
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.odrivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:30:10: fatal error:dml/dcn20/dcn20_fpu.h: No such file or directory
30 | #include "dml/dcn20/dcn20_fpu.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.Culprit is "drm-amd-display-move-fpu-associated-dcn301-code-to-d.patch"
Looking over the git history of the dml/dnc20 directory I think the correct fix would be to also apply upstream commit
ee37341199c61558b73113659695c90bf4736eb2aka "drm/amd/display: Re-arrange FPU code structure for dcn2x"
Quoted 5 lines
Quoted 1 line
CC'ing Qingqing Zhuo for confirmation.
I can confirm that applying a modified
ee37341199c6fixes the issue. \o/ The hunk that refers todrivers/gpu/drm/amd/display/dc/dcn201needs to be removed, since that directory (support for "cyan_skillfish") does not exist in 5.15.x.
I'll let you submit a working version, dropping chunks in the middle of patches is not exactly obvious at times :)
thanks,
greg k-h
Greg Kroah-Hartman
maintainerQuoted 9 lines · Holger Hoffstätte
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CC [M]
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.odrivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:30:10: fatal error:dml/dcn20/dcn20_fpu.h: No such file or directory
30 | #include "dml/dcn20/dcn20_fpu.h"
Quoted 8 lines
| ^~~~~~~~~~~~~~~~~~~~~~~compilation terminated.
Culprit is "drm-amd-display-move-fpu-associated-dcn301-code-to-d.patch"
Looking over the git history of the dml/dnc20 directory I think the correct fix would be to also apply upstream commit
ee37341199c61558b73113659695c90bf4736eb2aka "drm/amd/display: Re-arrange FPU code structure for dcn2x"
I have dropped 25f1488bdbba ("drm/amd/display: Wrap dcn301_calculate_wm_and_dlg for FPU.") and from the 5.15 stable queue now. If these should go back in, please provide some working backports.
thanks,
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.27-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Following build errors/warnings noticed on arm64.
arch/arm64/net/bpf_jit_comp.c: In function 'build_insn':arch/arm64/net/bpf_jit_comp.c:791:21: error: implicit declaration of function 'bpf_pseudo_func' [-Werror=implicit-function-declaration]
791 | if (bpf_pseudo_func(insn))
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
drivers/gpu/drm/mediatek/mtk_dsi.c: In function 'mtk_dsi_host_attach':drivers/gpu/drm/mediatek/mtk_dsi.c:858:28: error: implicit declaration of function 'devm_drm_of_get_bridge'; did you mean 'devm_drm_panel_bridge_add'? [-Werror=implicit-function-declaration]
858 | dsi->next_bridge = devm_drm_of_get_bridge(dev,
dev->of_node, 0, 0);
| ^~~~~~~~~~~~~~~~~~~~~~
| devm_drm_panel_bridge_adddrivers/gpu/drm/mediatek/mtk_dsi.c:858:26: warning: assignment to 'struct drm_bridge *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
858 | dsi->next_bridge = devm_drm_of_get_bridge(dev,dev->of_node, 0, 0);
| ^
cc1: some warnings being treated as errors
Build log [1].
--
Linaro LKFT
https://lkft.linaro.org
[1] https://builds.tuxbuild.com/263ZKyWWLLcPGRbiZwIEZw3wvXX/
Greg Kroah-Hartman
maintainerQuoted 25 lines · Naresh Kamboju
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.27-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Following build errors/warnings noticed on arm64.
Quoted 6 lines
arch/arm64/net/bpf_jit_comp.c: In function 'build_insn':arch/arm64/net/bpf_jit_comp.c:791:21: error: implicit declaration of function 'bpf_pseudo_func' [-Werror=implicit-function-declaration]
791 | if (bpf_pseudo_func(insn))| ^~~~~~~~~~~~~~~cc1: some warnings being treated as errors
Found this one, now dropped.
Greg Kroah-Hartman
maintainerQuoted 8 lines · Naresh Kamboju
drivers/gpu/drm/mediatek/mtk_dsi.c: In function 'mtk_dsi_host_attach':drivers/gpu/drm/mediatek/mtk_dsi.c:858:28: error: implicit declaration of function 'devm_drm_of_get_bridge'; did you mean 'devm_drm_panel_bridge_add'? [-Werror=implicit-function-declaration]
858 |dsi->next_bridge= devm_drm_of_get_bridge(dev,dev->of_node, 0, 0); | ^~~~~~~~~~~~~~~~~~~~~~ | devm_drm_panel_bridge_add
Quoted 7 lines
drivers/gpu/drm/mediatek/mtk_dsi.c:858:26: warning: assignment to 'structdrm_bridge*' from 'int' makes pointer from integer without a cast [-Wint-conversion]
858 |dsi->next_bridge= devm_drm_of_get_bridge(dev,dev->of_node, 0, 0);
| ^
cc1: some warnings being treated as errors
Offending commit now dropped, thanks.
greg k-h
Hi Greg,
Quoted 20 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fpub%2Flinux%2Fkernel%2Fv5.x%2Fstable-review%2Fpatch-5.15.27-rc1.gz&data=04%7C01%7Cjonathanh%40nvidia.com%7C52f7666efdc24e35cbc708da001e0bcc%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637822426962400608%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7OrqXqRl71%2FAG4A1q5lIuWzCpA0r7uul3XpgJIfyVuA%3D&reserved=0or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
...
Quoted 2 lines
Hou Tao <[email protected]>
bpf, arm64: Useemit_addr_mov_i64()forBPF_PSEUDO_FUNC
The above commit is causing a build break for ARM64 ...
arch/arm64/net/bpf_jit_comp.c: In function ‘build_insn’:arch/arm64/net/bpf_jit_comp.c:791:7: error: implicit declaration of function ‘bpf_pseudo_func’ [-Werror=implicit-function-declaration]
if (bpf_pseudo_func(insn))
^~~~~~~~~~~~~~~
Jon
Signature · 1 line
nvpublic
Greg Kroah-Hartman
maintainerQuoted 29 lines · Jon Hunter
Hi Greg,
Quoted 20 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fpub%2Flinux%2Fkernel%2Fv5.x%2Fstable-review%2Fpatch-5.15.27-rc1.gz&data=04%7C01%7Cjonathanh%40nvidia.com%7C52f7666efdc24e35cbc708da001e0bcc%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637822426962400608%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7OrqXqRl71%2FAG4A1q5lIuWzCpA0r7uul3XpgJIfyVuA%3D&reserved=0or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:...
Quoted 2 lines
Hou Tao <[email protected]>
bpf, arm64: Useemit_addr_mov_i64()forBPF_PSEUDO_FUNC
Quoted 6 lines
The above commit is causing a build break for ARM64 ...
arch/arm64/net/bpf_jit_comp.c: In function ‘build_insn’:arch/arm64/net/bpf_jit_comp.c:791:7: error: implicit declaration of function ‘bpf_pseudo_func’ [-Werror=implicit-function-declaration]
if (bpf_pseudo_func(insn))^~~~~~~~~~~~~~~
Thanks, I'll go drop that offending patch.
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
In addition to other reported build errors:
Building mips:allmodconfig ... failed
--------------
Error log:drivers/net/hamradio/mkiss.c:35: error: "END" redefined
Guenter
Greg Kroah-Hartman
maintainerQuoted 10 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
Quoted 6 lines
In addition to other reported build errors:
Building mips:allmodconfig ... failed
--------------
Error log:drivers/net/hamradio/mkiss.c:35: error: "END" redefined
That is odd, I don't see any changes to that driver, nor any MIPS changes that touch "END".
I don't even see "END" in the diff anywhere.
Any chance you can bisect?
I'll go push out -rc2 versions with everything else fixed up (hopefully).
thanks,
greg k-h
Quoted 18 lines · Greg Kroah-Hartman
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
Quoted 6 lines
In addition to other reported build errors:
Building mips:allmodconfig ... failed
--------------
Error log:drivers/net/hamradio/mkiss.c:35: error: "END" redefined
Quoted 7 lines
That is odd, I don't see any changes to that driver, nor any MIPS changes that touch "END".
I don't even see "END" in the diff anywhere.
Any chance you can bisect?
git bisect start 'HEAD' 'v5.15.26'
# bad: [20ab3ebe56f306d821cf1c6858cf29f4d2e0075a] drm/amd/display: Fix stream->link_enc unassigned during stream removal git bisect bad 20ab3ebe56f306d821cf1c6858cf29f4d2e0075a
# bad: [2f01eec30992529350bae197f73d71136b35e3b1] Input: ti_am335x_tsc - fix STEPCONFIG setup for Z2
git bisect bad 2f01eec30992529350bae197f73d71136b35e3b1
# good: [d369b344b4fb5a6ab9f72bacece674526761b885] arm64: Mark start_backtrace() notrace and NOKPROBE_SYMBOL git bisect good d369b344b4fb5a6ab9f72bacece674526761b885
# good: [46f46f14bd45acdabcfb1d9f3b648f4a27d18c08] bpf, arm64: Use emit_addr_mov_i64() for BPF_PSEUDO_FUNC git bisect good 46f46f14bd45acdabcfb1d9f3b648f4a27d18c08
# bad: [5b0c543b875e976e74c347b2d009c6519a6d2939] KVM: s390: Ensure kvm_arch_no_poll() is read once when blocking vCPU git bisect bad 5b0c543b875e976e74c347b2d009c6519a6d2939
# bad: [58452f46ddb11fbe5b5f31d93a979d57efdad4b1] PCI: rcar: Check if device is runtime suspended instead of __clk_is_enabled() git bisect bad 58452f46ddb11fbe5b5f31d93a979d57efdad4b1
# bad: [d6ab8da0cb6234fbc4fd240b9d7470b4c03d5df9] signal: In get_signal test for signal_group_exit every time through the loop git bisect bad d6ab8da0cb6234fbc4fd240b9d7470b4c03d5df9
# bad: [53863a048566989e87f8bb306e835f940a10ed73] MIPS: fix local_{add,sub}_return on MIPS64
git bisect bad 53863a048566989e87f8bb306e835f940a10ed73
# first bad commit: [53863a048566989e87f8bb306e835f940a10ed73] MIPS: fix local_{add,sub}_return on MIPS64The problem is the innocent looking
#include <linux/atomic.h>
+#include <asm/asm.h>
#include <asm/cmpxchg.h>
in that patch. Reverting it fixes the problem. Alternatively, you could apply commit 16517829f2e0 ("hamradio: fix macro redefine warning").
Guenter
Greg Kroah-Hartman
maintainerQuoted 46 lines · Guenter Roeck
Quoted 18 lines · Greg Kroah-Hartman
Quoted 10 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.27 release. There are 262 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
Quoted 6 lines
In addition to other reported build errors:
Building mips:allmodconfig ... failed
--------------
Error log:drivers/net/hamradio/mkiss.c:35: error: "END" redefinedQuoted 7 lines
That is odd, I don't see any changes to that driver, nor any MIPS changes that touch "END".
I don't even see "END" in the diff anywhere.
Any chance you can bisect?
git bisect start 'HEAD' 'v5.15.26'
# bad: [20ab3ebe56f306d821cf1c6858cf29f4d2e0075a] drm/amd/display: Fixstream->link_encunassigned during stream removal git bisect bad20ab3ebe56f306d821cf1c6858cf29f4d2e0075a
# bad: [2f01eec30992529350bae197f73d71136b35e3b1] Input:ti_am335x_tsc- fix STEPCONFIG setup for Z2
git bisect bad2f01eec30992529350bae197f73d71136b35e3b1
# good: [d369b344b4fb5a6ab9f72bacece674526761b885] arm64: Markstart_backtrace()notrace andNOKPROBE_SYMBOLgit bisect goodd369b344b4fb5a6ab9f72bacece674526761b885
# good: [46f46f14bd45acdabcfb1d9f3b648f4a27d18c08] bpf, arm64: Useemit_addr_mov_i64()forBPF_PSEUDO_FUNCgit bisect good46f46f14bd45acdabcfb1d9f3b648f4a27d18c08
# bad: [5b0c543b875e976e74c347b2d009c6519a6d2939] KVM: s390: Ensurekvm_arch_no_poll()is read once when blocking vCPU git bisect bad5b0c543b875e976e74c347b2d009c6519a6d2939
# bad: [58452f46ddb11fbe5b5f31d93a979d57efdad4b1] PCI: rcar: Check if device is runtime suspended instead of__clk_is_enabled()git bisect bad58452f46ddb11fbe5b5f31d93a979d57efdad4b1
# bad: [d6ab8da0cb6234fbc4fd240b9d7470b4c03d5df9] signal: Inget_signaltest forsignal_group_exitevery time through the loop git bisect badd6ab8da0cb6234fbc4fd240b9d7470b4c03d5df9
# bad: [53863a048566989e87f8bb306e835f940a10ed73] MIPS: fix local_{add,sub}_return on MIPS64
git bisect bad53863a048566989e87f8bb306e835f940a10ed73# first bad commit: [53863a048566989e87f8bb306e835f940a10ed73] MIPS: fix local_{add,sub}_return on MIPS64
Quoted 8 lines
The problem is the innocent looking
#include <
linux/atomic.h>
+#include <asm/asm.h>
#include <asm/cmpxchg.h>in that patch. Reverting it fixes the problem. Alternatively, you could apply commit
16517829f2e0("hamradio: fix macro redefine warning").
Ah, that works better, I'll go queue that one up, thanks!
greg k-h