Skip to contentSkip to conversation

mm/vmalloc: fix comments about vmap_area struct

PATCH Applied Bang Li 2 participants 2 messages Mar 5, 2022 – Mar 7, 2022

Subsystems (2)
lore
Share & tools
lore

Bang Li

author
#0 lore raw

PATCH 1/1 mm/vmalloc: fix comments about vmap_area struct

the vmap_area_root should be in the "busy" tree and the free_vmap_area_root should be in the "free" tree.

Fixes 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size")
---
 include/linux/vmalloc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/vmalloc.h +2 -2
index 880227b9f044..05065915edd7 100644
@@ -80,8 +80,8 @@ struct vmap_area {
 	/*
 	 * The following two variables can be packed, because
 	 * a vmap_area object can be either:
-	 *    1) in "free" tree (root is vmap_area_root)
-	 *    2) or "busy" tree (root is free_vmap_area_root)
+	 *    1) in "free" tree (root is free_vmap_area_root)
+	 *    2) or "busy" tree (root is vmap_area_root)
 	 */
 	union {
 		unsigned long subtree_max_size; /* in "free" tree */
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Bang Li

the vmap_area_root should be in the "busy" tree and the free_vmap_area_root should be in the "free" tree.

Fixes 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size")
---
 include/linux/vmalloc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/vmalloc.h +2 -2
index 880227b9f044..05065915edd7 100644
@@ -80,8 +80,8 @@ struct vmap_area {
 	/*
 	 * The following two variables can be packed, because
 	 * a vmap_area object can be either:
-	 *    1) in "free" tree (root is vmap_area_root)
-	 *    2) or "busy" tree (root is free_vmap_area_root)
+	 *    1) in "free" tree (root is free_vmap_area_root)
+	 *    2) or "busy" tree (root is vmap_area_root)
 	 */
 	union {
 		unsigned long subtree_max_size; /* in "free" tree */
Signature · 1 line
2.25.1

Agree, those comments were messed up.

--
Vlad Rezki