sign-file: Use OpenSSL provided define to compile out deprecated APIs
Subsystems (2)
PATCH 1/1 sign-file: Use OpenSSL provided define to compile out deprecated APIs
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use OPENSSL_NO_ENGINE to disallow its use and fall back on the BIO API.
--- scripts/sign-file.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
scripts/sign-file.c +10 -9
@@ -135,7 +135,9 @@ static int pem_pw_cb(char *buf, int len, int w, void *v)static EVP_PKEY *read_private_key (const char *private_key_name) {EVP_PKEY *private_key; +BIO *b; +#ifndef OPENSSL_NO_ENGINE if (!strncmp (private_key_name,"pkcs11:" ,7 )) {ENGINE *e;
@@ -153,17 +155,16 @@ static EVP_PKEY *read_private_key(const char *private_key_name) private_key =ENGINE_load_private_key (e, private_key_name,NULL ,NULL );ERR (!private_key,"%s" , private_key_name); - }else { -BIO *b; - - b =BIO_new_file (private_key_name,"rb" ); -ERR (!b,"%s" , private_key_name); - private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, -NULL ); -ERR (!private_key,"%s" , private_key_name); -BIO_free (b); + return private_key; } +#endif + b =BIO_new_file (private_key_name,"rb" ); +ERR (!b,"%s" , private_key_name); + private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, +NULL ); +ERR (!private_key,"%s" , private_key_name); +BIO_free (b);return private_key; }
Signature · 1 line
2.33.0.800.g4c38ced690-goog
Quoted 42 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto disallow its use and fall back on the BIO API.Cc David Howells <[email protected]>Cc David Woodhouse <[email protected]>Co-developed-by Adam Langley <[email protected]>Signed-off-by Lee Jones <[email protected]>--- scripts/sign-file.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)scripts/sign-file.c +3
-9@@ -135,7 +135,9 @@ static int pem_pw_cb(char *buf, int len, int w, void *v)static EVP_PKEY *read_private_key (const char *private_key_name) {EVP_PKEY *private_key; +BIO *b; +#ifndef OPENSSL_NO_ENGINE if (!strncmp (private_key_name,"pkcs11:" ,7 )) {ENGINE *e;@@ -153,17 +155,16 @@ static EVP_PKEY *read_private_key(const char *private_key_name) private_key =ENGINE_load_private_key (e, private_key_name,NULL ,NULL );ERR (!private_key,"%s" , private_key_name); - }else { -BIO *b; - - b =BIO_new_file (private_key_name,"rb" ); -ERR (!b,"%s" , private_key_name); - private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, -NULL ); -ERR (!private_key,"%s" , private_key_name); -BIO_free (b); +return private_key; }
scripts/sign-file.c static EVP_PKEY *read_private_key(const char *private_key_name) · line 169
Quoted 10 lines
scripts/sign-file.c +7
-0+#endif + b =BIO_new_file (private_key_name,"rb" ); +ERR (!b,"%s" , private_key_name); + private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, +NULL ); +ERR (!private_key,"%s" , private_key_name); +BIO_free (b);return private_key; }
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
- Eric
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
The patch removes support when OPENSSL_NO_ENGINE is defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)
When OPENSSL_NO_ENGINE is defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.
Cheers
AGL
Quoted 10 lines · Adam Langley
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
Quoted 8 lines
The patch removes support when
OPENSSL_NO_ENGINEis defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)When
OPENSSL_NO_ENGINEis defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.
Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support? Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
- Eric
Quoted 2 lines · Eric Biggers
Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support?
Correct.
Quoted 2 lines
Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
The ENGINE API is deprecated in OpenSSL 3.0 but that change doesn't remove support unless it has already been compiled out of OpenSSL first.
Cheers
AGL
Quoted 15 lines · Eric Biggers
Quoted 14 lines · Adam Langley
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
The patch removes support when
OPENSSL_NO_ENGINEis defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)
Quoted 7 lines
Quoted 4 lines
When
OPENSSL_NO_ENGINEis defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support?
Correct.
Quoted 2 lines
Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
I see your point.
Happy to rejig the commit message if that would help.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 25 lines · Lee Jones
Quoted 15 lines · Eric Biggers
Quoted 14 lines · Adam Langley
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
The patch removes support when
OPENSSL_NO_ENGINEis defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)Quoted 7 lines
Quoted 4 lines
When
OPENSSL_NO_ENGINEis defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support?
Quoted 8 lines
Correct.
Quoted 2 lines
Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
I see your point.
Happy to rejig the commit message if that would help.
*thread necromancy*
Hi,
These warnings are quite noisy on Fedora rawhide and other distros that have moved to OpenSSL 3.0. It's not clear to me from this thread if this patch is actually the correct fix?
-Kees
Signature · 1 line
Kees Cook
Quoted 35 lines · Kees Cook
Quoted 25 lines · Lee Jones
Quoted 15 lines · Eric Biggers
Quoted 14 lines · Adam Langley
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
The patch removes support when
OPENSSL_NO_ENGINEis defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)Quoted 7 lines
Quoted 4 lines
When
OPENSSL_NO_ENGINEis defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support?
Quoted 8 lines
Correct.
Quoted 2 lines
Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
I see your point.
Happy to rejig the commit message if that would help.
Quoted 7 lines
*thread necromancy*
Hi,
These warnings are quite noisy on Fedora rawhide and other distros that have moved to OpenSSL 3.0. It's not clear to me from this thread if this patch is actually the correct fix?
I believe it is the correct fix.
However the commit message seemed to cause Eric some confusion.
Would you like me to resubmit?
It would be nice to get some input from the maintainers at one point.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 45 lines · Lee Jones
Quoted 35 lines · Kees Cook
Quoted 25 lines · Lee Jones
Quoted 15 lines · Eric Biggers
Quoted 14 lines · Adam Langley
Quoted 8 lines · Eric Biggers
I ran into these same -Wdeprecated-declarations compiler warnings on another project that uses the ENGINE API to access OpenSSL's support for PKCS#11 tokens. The conclusion was that in OpenSSL 3.0, the new API for PKCS#11 support isn't actually ready yet, so we had to keep using the ENGINE API and just add -Wno-deprecated-declarations to the compiler flags.
Your patch just removes support for PKCS#11 in that case, which seems undesirable. (Unless no one is actually using it?)
The patch removes support when
OPENSSL_NO_ENGINEis defined, but that's not defined by default in OpenSSL 3.0. (Unless something changed recently.)Quoted 7 lines
Quoted 4 lines
When
OPENSSL_NO_ENGINEis defined, ENGINE support is not compiled into OpenSSL and the headers don't include the functions:
https://github.com/openssl/openssl/blob/master/include/openssl/engine.h
.Okay so this patch is actually a build fix for when OpenSSL doesn't include ENGINE support?
Quoted 8 lines
Correct.
Quoted 2 lines
Currently this patch claims that it's removing the use of a "deprecated" API, which is something entirely different.
I see your point.
Happy to rejig the commit message if that would help.
Quoted 7 lines
*thread necromancy*
Hi,
These warnings are quite noisy on Fedora rawhide and other distros that have moved to OpenSSL 3.0. It's not clear to me from this thread if this patch is actually the correct fix?
Quoted 5 lines
I believe it is the correct fix.
However the commit message seemed to cause Eric some confusion.
Would you like me to resubmit?
Yes, please. :)
Quoted 1 line
It would be nice to get some input from the maintainers at one point.
David, do you have an opinion on this? I'd like to see this fixed so that rawhide builds stop spewing warnings.
Thanks!
-Kees
Signature · 1 line
Kees Cook
PATCH v2 1/1 sign-file: Do not attempt to use the ENGINE_* API if it's not available
In reply to Lee JonesOpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use OPENSSL_NO_ENGINE to ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.
---
v2: Clear up subject and patch description to avoid confusion
scripts/sign-file.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
scripts/sign-file.c +10 -9
@@ -135,7 +135,9 @@ static int pem_pw_cb(char *buf, int len, int w, void *v)static EVP_PKEY *read_private_key (const char *private_key_name) {EVP_PKEY *private_key; +BIO *b; +#ifndef OPENSSL_NO_ENGINE if (!strncmp (private_key_name,"pkcs11:" ,7 )) {ENGINE *e;
@@ -153,17 +155,16 @@ static EVP_PKEY *read_private_key(const char *private_key_name) private_key =ENGINE_load_private_key (e, private_key_name,NULL ,NULL );ERR (!private_key,"%s" , private_key_name); - }else { -BIO *b; - - b =BIO_new_file (private_key_name,"rb" ); -ERR (!b,"%s" , private_key_name); - private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, -NULL ); -ERR (!private_key,"%s" , private_key_name); -BIO_free (b); + return private_key; } +#endif + b =BIO_new_file (private_key_name,"rb" ); +ERR (!b,"%s" , private_key_name); + private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, +NULL ); +ERR (!private_key,"%s" , private_key_name); +BIO_free (b);return private_key; }
Re: [PATCH v2 1/1] sign-file: Do not attempt to use the ENGINE_* API if it's not available
Quoted 5 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.
On Fedora rawhide, I'm still seeing a bunch of warnings:
scripts/sign-file.c: In function 'display_openssl_errors':scripts/sign-file.c:89:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdeprecat ed-declarations]
89 | while ((e = ERR_get_error_line(&file, &line))) {
| ^~~~~
In file included from scripts/sign-file.c:29:
/usr/include/openssl/err.h:411:15: note: declared here
411 | unsigned long ERR_get_error_line(const char **file, int *line);
| ^~~~~~~~~~~~~~~~~~
scripts/sign-file.c: In function 'drain_openssl_errors':
scripts/sign-file.c:102:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdepreca
ted-declarations]
102 | while (ERR_get_error_line(&file, &line)) {}
| ^~~~~
/usr/include/openssl/err.h:411:15: note: declared here
411 | unsigned long ERR_get_error_line(const char **file, int *line);
| ^~~~~~~~~~~~~~~~~~...
Quoted 43 lines
Cc David Howells <[email protected]>Cc David Woodhouse <[email protected]>Cc Eric Biggers <[email protected]>Cc Kees Cook <[email protected]>Co-developed-by Adam Langley <[email protected]>Signed-off-by Lee Jones <[email protected]>---
v2: Clear up subject and patch description to avoid confusion
scripts/sign-file.c| 19 ++++++++++---------1 file changed, 10 insertions(+), 9 deletions(-)scripts/sign-file.c +3
-9@@ -135,7 +135,9 @@ static int pem_pw_cb(char *buf, int len, int w, void *v)static EVP_PKEY *read_private_key (const char *private_key_name) {EVP_PKEY *private_key; +BIO *b; +#ifndef OPENSSL_NO_ENGINE if (!strncmp (private_key_name,"pkcs11:" ,7 )) {ENGINE *e;@@ -153,17 +155,16 @@ static EVP_PKEY *read_private_key(const char *private_key_name) private_key =ENGINE_load_private_key (e, private_key_name,NULL ,NULL );ERR (!private_key,"%s" , private_key_name); - }else { -BIO *b; - - b =BIO_new_file (private_key_name,"rb" ); -ERR (!b,"%s" , private_key_name); - private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, -NULL ); -ERR (!private_key,"%s" , private_key_name); -BIO_free (b); +return private_key; }
scripts/sign-file.c static EVP_PKEY *read_private_key(const char *private_key_name) · line 169
Quoted 10 lines
scripts/sign-file.c +7
-0+#endif + b =BIO_new_file (private_key_name,"rb" ); +ERR (!b,"%s" , private_key_name); + private_key =PEM_read_bio_PrivateKey (b,NULL , pem_pw_cb, +NULL ); +ERR (!private_key,"%s" , private_key_name); +BIO_free (b);return private_key; }
--
Kees Cook
Re: [PATCH v2 1/1] sign-file: Do not attempt to use the ENGINE_* API if it's not available
Quoted 8 lines · Kees Cook
Quoted 5 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.
Quoted 5 lines
On Fedora rawhide, I'm still seeing a bunch of warnings:
scripts/sign-file.c: In function 'display_openssl_errors':scripts/sign-file.c:89:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdeprecat ed-declarations]
The display_openssl_errors function should probably just call ERR_print_errors_fp:
https://www.openssl.org/docs/man1.0.2/man3/ERR_print_errors_fp.html
The drain_openssl_errors function should probably just call ERR_clear_error:
https://www.openssl.org/docs/man3.0/man3/ERR_clear_error.html
Cheers
AGL
Re: [PATCH v2 1/1] sign-file: Do not attempt to use the ENGINE_* API if it's not available
In reply to Kees CookHi,
Quoted 12 lines · Kees Cook
Quoted 5 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.On Fedora rawhide, I'm still seeing a bunch of warnings:
scripts/sign-file.c: In function 'display_openssl_errors':scripts/sign-file.c:89:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdeprecat ed-declarations]
Quoted 14 lines
89 | while ((e = ERR_get_error_line(&file, &line))) {
| ^~~~~
In file included from scripts/sign-file.c:29:
/usr/include/openssl/err.h:411:15: note: declared here
411 | unsigned long ERR_get_error_line(const char **file, int *line);
| ^~~~~~~~~~~~~~~~~~
scripts/sign-file.c: In function 'drain_openssl_errors':
scripts/sign-file.c:102:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdepreca
ted-declarations]
102 | while (ERR_get_error_line(&file, &line)) {}
| ^~~~~
/usr/include/openssl/err.h:411:15: note: declared here
411 | unsigned long ERR_get_error_line(const char **file, int *line);
| ^~~~~~~~~~~~~~~~~~FWIW, we are seeing the same now on Debian as Debian unstable is moving to OpenSSL 3.0.
https://lists.debian.org/debian-release/2022/05/msg00070.html
Regards,
Salvatore
Re: [PATCH v2 1/1] sign-file: Do not attempt to use the ENGINE_* API if it's not available
Quoted 30 lines · Salvatore Bonaccorso
Hi,
Quoted 12 lines · Kees Cook
Quoted 5 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.On Fedora rawhide, I'm still seeing a bunch of warnings:
scripts/sign-file.c: In function 'display_openssl_errors':scripts/sign-file.c:89:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdeprecat ed-declarations]Quoted 14 lines
89 | while ((e = ERR_get_error_line(&file, &line))) { | ^~~~~ In file included from scripts/sign-file.c:29: /usr/include/openssl/err.h:411:15: note: declared here 411 | unsigned long ERR_get_error_line(const char **file, int *line); | ^~~~~~~~~~~~~~~~~~ scripts/sign-file.c: In function 'drain_openssl_errors': scripts/sign-file.c:102:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdepreca ted-declarations] 102 | while (ERR_get_error_line(&file, &line)) {} | ^~~~~ /usr/include/openssl/err.h:411:15: note: declared here 411 | unsigned long ERR_get_error_line(const char **file, int *line); | ^~~~~~~~~~~~~~~~~~
Quoted 4 lines
FWIW, we are seeing the same now on Debian as Debian unstable is moving to OpenSSL 3.0.
https://lists.debian.org/debian-release/2022/05/msg00070.html
Did this patch help?
We've had a few confirmed reports now.
My guess is the maintainers are not currently monitoring.
With some more {Reviewed,Tested}-bys I'd be prepared to submit this via other means. Either via my own repository or via Greg's.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 1/1] sign-file: Do not attempt to use the ENGINE_* API if it's not available
Quoted 37 lines · Lee Jones
Quoted 30 lines · Salvatore Bonaccorso
Hi,
Quoted 12 lines · Kees Cook
Quoted 5 lines · Lee Jones
OpenSSL's ENGINE API is deprecated in OpenSSL v3.0.
Use
OPENSSL_NO_ENGINEto ensure the ENGINE API is only used if it is present. This will safeguard against compile errors when using SSL implementations which lack support for this deprecated API.On Fedora rawhide, I'm still seeing a bunch of warnings:
scripts/sign-file.c: In function 'display_openssl_errors':scripts/sign-file.c:89:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdeprecat ed-declarations]Quoted 14 lines
89 | while ((e = ERR_get_error_line(&file, &line))) { | ^~~~~ In file included from scripts/sign-file.c:29: /usr/include/openssl/err.h:411:15: note: declared here 411 | unsigned long ERR_get_error_line(const char **file, int *line); | ^~~~~~~~~~~~~~~~~~ scripts/sign-file.c: In function 'drain_openssl_errors': scripts/sign-file.c:102:9: warning: 'ERR_get_error_line' is deprecated: Since OpenSSL 3.0 [-Wdepreca ted-declarations] 102 | while (ERR_get_error_line(&file, &line)) {} | ^~~~~ /usr/include/openssl/err.h:411:15: note: declared here 411 | unsigned long ERR_get_error_line(const char **file, int *line); | ^~~~~~~~~~~~~~~~~~Quoted 4 lines
FWIW, we are seeing the same now on Debian as Debian unstable is moving to OpenSSL 3.0.
https://lists.debian.org/debian-release/2022/05/msg00070.html
Quoted 9 lines
Did this patch help?
We've had a few confirmed reports now.
My guess is the maintainers are not currently monitoring.
With some more {Reviewed,Tested}-bys I'd be prepared to submit this via other means. Either via my own repository or via Greg's.
I am seeing the same issue on my test system after upgrading to Ubuntu 22.04 LTS. This patch didn't fix the problem.
Please cc me on your future patches and I can test them.
thanks,
-- Shuah