Skip to contentSkip to conversation

net: phy: DP83822: clear MISR2 register to disable interrupts

PATCH Applied Clément Léger 4 participants 4 messages Mar 9, 2022 – Mar 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: DP83822: clear MISR2 register to disable interrupts

MISR1 was cleared twice but the original author intention was probably to clear MISR1 & MISR2 to completely disable interrupts. Fix it to clear MISR2.

Fixes 87461f7a58ab ("net: phy: DP83822 initial driver submission")
---
 drivers/net/phy/dp83822.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/dp83822.c +1 -1
index 211b5476a6f5..ce17b2af3218 100644
@@ -274,7 +274,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
 		if (err < 0)
 			return err;
 
-		err = phy_write(phydev, MII_DP83822_MISR1, 0);
+		err = phy_write(phydev, MII_DP83822_MISR2, 0);
 		if (err < 0)
 			return err;
 
Signature · 1 line
2.34.1
#3 lore raw
In reply to Clément Léger
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Wed, 9 Mar 2022 15:22:28 +0100 you wrote:

MISR1 was cleared twice but the original author intention was probably to clear MISR1 & MISR2 to completely disable interrupts. Fix it to clear MISR2.

Fixes 87461f7a58ab ("net: phy: DP83822 initial driver submission")

[...]

Here is the summary with links:
- net: phy: DP83822: clear MISR2 register to disable interrupts

    https://git.kernel.org/netdev/net/c/37c9d66c9556

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html