Skip to contentSkip to conversation

Patch "ARM: Do not use NOCROSSREFS directive with ld.lld" has been added to the 4.19-stable tree

DISCUSSION Nathan Chancellor 3 participants 3 messages Mar 9, 2022 – Mar 10, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Greg,

Quoted 7 lines · On Wed, Mar 09, 2022 at 11:32:58PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

ARM: Do not use NOCROSSREFS directive with ld.lld

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

<snip>

Review

Quoted 5 lines
(quoted diff) +5 -0
+/*
+ * ld.lld does not support NOCROSSREFS:
+ * https://github.com/ClangBuiltLinux/linux/issues/1609
+ */
+#ifdef CONFIG_LD_IS_LLD

Please cherry-pick commit b744b43f79cc ("kbuild: add CONFIG_LD_IS_LLD") to 4.19 so that this patch works as intended.

We do not link with ld.lld on 4.9 or 4.14 so the NOCROSSREFS patch is not technically needed there but it does no harm if it is.

Cheers,
Nathan

#2 lore raw
Quoted 13 lines · Nathan Chancellor

Hi Greg,

Quoted 7 lines · On Wed, Mar 09, 2022 at 11:32:58PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

ARM: Do not use NOCROSSREFS directive with ld.lld

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

<snip>

Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+/*
+ * ld.lld does not support NOCROSSREFS:
+ * https://github.com/ClangBuiltLinux/linux/issues/1609
+ */
+#ifdef CONFIG_LD_IS_LLD

Please cherry-pick commit b744b43f79cc ("kbuild: add CONFIG_LD_IS_LLD") to 4.19 so that this patch works as intended.

Now queued up, thanks.

Quoted 2 lines

We do not link with ld.lld on 4.9 or 4.14 so the NOCROSSREFS patch is not technically needed there but it does no harm if it is.

I'll leave it as I'm sure there might be others out there that do that (Android or ChromeOS?) I already did the backport-by-hand work, might as not waste it :)

thanks,

greg k-h

#3 lore raw
Quoted 24 lines · Greg KH
Quoted 13 lines · Nathan Chancellor

Hi Greg,

Quoted 7 lines · On Wed, Mar 09, 2022 at 11:32:58PM +0100, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

ARM: Do not use NOCROSSREFS directive with ld.lld

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

<snip>

Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+/*
+ * ld.lld does not support NOCROSSREFS:
+ * https://github.com/ClangBuiltLinux/linux/issues/1609
+ */
+#ifdef CONFIG_LD_IS_LLD

Please cherry-pick commit b744b43f79cc ("kbuild: add CONFIG_LD_IS_LLD") to 4.19 so that this patch works as intended.

Quoted 8 lines

Now queued up, thanks.

Quoted 2 lines

We do not link with ld.lld on 4.9 or 4.14 so the NOCROSSREFS patch is not technically needed there but it does no harm if it is.

I'll leave it as I'm sure there might be others out there that do that (Android or ChromeOS?) I already did the backport-by-hand work, might as not waste it :)

FWIW, ld.lld support in 4.14 exists only for ARCH=arm64 and ARCH=x86_64. The NOCROSSREFS patch is specific to ARCH=arm. I agree with GKH that it won't hurt to backport b744b43f79cc.

Signature · 2 lines
Thanks,
~Nick Desaulniers