4.19.235-rc2 review

This is the start of the stable review cycle for the 4.19.235 release. There are 29 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed, 16 Mar 2022 14:59:12 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.235-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.19.235-rc2

Valentin Schneider <[email protected]>
ia64: ensure proper NUMA distance and possible map initialization

Dietmar Eggemann <[email protected]>
sched/topology: Fix sched_domain_topology_level alloc in sched_init_numa()

Valentin Schneider <[email protected]>
sched/topology: Make sched_init_numa() use a set for the deduplicating sort

Qu Wenruo <[email protected]>
btrfs: unlock newly allocated extent buffer after error

Josh Triplett <[email protected]>
ext4: add check to prevent attempting to resize an fs with sparse_super2

Russell King (Oracle) <[email protected]>
ARM: fix Thumb2 regression with Spectre BHB

Michael S. Tsirkin <[email protected]>
virtio: acknowledge all features before access

Michael S. Tsirkin <[email protected]>
virtio: unexport virtio_finalize_features

Emil Renner Berthing <[email protected]>
riscv: Fix auipc+jalr relocation range checks

Robert Hancock <[email protected]>
net: macb: Fix lost RX packet wakeup race in NAPI receive

Dan Carpenter <[email protected]>
staging: gdm724x: fix use after free in gdm_lte_rx()

Randy Dunlap <[email protected]>
ARM: Spectre-BHB: provide empty stub for non-config

Mike Kravetz <[email protected]>
selftests/memfd: clean up mapping in mfd_fail_write

Sven Schnelle <[email protected]>
tracing: Ensure trace buffer is at least 4096 bytes large

Marek Marczykowski-Górecki <[email protected]>
Revert "xen-netback: Check for hotplug-status existence before watching"

Marek Marczykowski-Górecki <[email protected]>
Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"

suresh kumar <[email protected]>
net-sysfs: add check for netdevice being present to speed_show

Eric Dumazet <[email protected]>
sctp: fix kernel-infoleak for SCTP sockets

Clément Léger <[email protected]>
net: phy: DP83822: clear MISR2 register to disable interrupts

Miaoqian Lin <[email protected]>
gianfar: ethtool: Fix refcount leak in gfar_get_ts_info

Mark Featherston <[email protected]>
gpio: ts4900: Do not set DAT and OE together

Pavel Skripkin <[email protected]>
NFC: port100: fix use-after-free in port100_send_complete

Mohammad Kabat <[email protected]>
net/mlx5: Fix size field in bufferx_reg struct

Duoming Zhou <[email protected]>
ax25: Fix NULL pointer dereference in ax25_kill_by_device

Jiasheng Jiang <[email protected]>
net: ethernet: lpc_eth: Handle error for clk_enable

Jiasheng Jiang <[email protected]>
net: ethernet: ti: cpts: Handle error for clk_enable

Miaoqian Lin <[email protected]>
ethernet: Fix error handling in xemaclite_of_probe

Tom Rix <[email protected]>
qed: return status of qed_iov_get_link

Jia-Ju Bai <[email protected]>
net: qlogic: check the return value of dma_alloc_coherent() in qed_vf_hw_prepare()

-------------

Diffstat:

 Makefile                                         |  4 +-
 arch/arm/include/asm/spectre.h                   |  6 ++
 arch/arm/kernel/entry-armv.S                     |  4 +-
 arch/ia64/kernel/acpi.c                          |  7 +-
 arch/riscv/kernel/module.c                       | 21 +++--
 drivers/gpio/gpio-ts4900.c                       | 24 ++++--
 drivers/net/ethernet/cadence/macb_main.c         | 25 +++++-
 drivers/net/ethernet/freescale/gianfar_ethtool.c |  1 +
 drivers/net/ethernet/nxp/lpc_eth.c               |  5 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.c      | 18 +++--
 drivers/net/ethernet/qlogic/qed/qed_vf.c         |  7 ++
 drivers/net/ethernet/ti/cpts.c                   |  4 +-
 drivers/net/ethernet/xilinx/xilinx_emaclite.c    |  4 +-
 drivers/net/phy/dp83822.c                        |  2 +-
 drivers/net/xen-netback/xenbus.c                 | 13 ++--
 drivers/nfc/port100.c                            |  2 +
 drivers/staging/gdm724x/gdm_lte.c                |  5 +-
 drivers/virtio/virtio.c                          | 40 +++++-----
 fs/btrfs/extent-tree.c                           |  1 +
 fs/ext4/resize.c                                 |  5 ++
 include/linux/mlx5/mlx5_ifc.h                    |  4 +-
 include/linux/topology.h                         |  1 +
 include/linux/virtio.h                           |  1 -
 include/linux/virtio_config.h                    |  3 +-
 kernel/sched/topology.c                          | 99 ++++++++++++------------
 kernel/trace/trace.c                             | 10 ++-
 net/ax25/af_ax25.c                               |  7 ++
 net/core/net-sysfs.c                             |  2 +-
 net/sctp/diag.c                                  |  9 +--
 tools/testing/selftests/memfd/memfd_test.c       |  1 +
 30 files changed, 212 insertions(+), 123 deletions(-)

All ia64 builds:

kernel/fork.c:728:13: warning: 'task_struct_whitelist' defined but not used [-Wunused-function]
728 | static void task_struct_whitelist(unsigned long *offset, unsigned long *size)

      |             ^~~~~~~~~~~~~~~~~~~~~
arch/ia64/kernel/acpi.c: In function 'acpi_numa_fixup':
arch/ia64/kernel/acpi.c:540:17: error: implicit declaration of function 'slit_distance'; did you mean 'node_distance'? [-Werror=implicit-function-declaration]
  540 |                 slit_distance(0, 0) = LOCAL_DISTANCE;
      |                 ^~~~~~~~~~~~~
      |                 node_distance

arch/ia64/kernel/acpi.c:540:37: error: lvalue required as left operand of assignment
540 | slit_distance(0, 0) = LOCAL_DISTANCE;
| ^

Guenter

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y

Best regards,
Pavel

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Build results:

	total: 156 pass: 153 fail: 3

Failed builds:
ia64:defconfig
ia64:allnoconfig
ia64:tinyconfig
Qemu test results:

	total: 425 pass: 425 fail: 0

Build failures as already reported.

arch/ia64/kernel/acpi.c: In function 'acpi_numa_fixup':
arch/ia64/kernel/acpi.c:540:17: error: implicit declaration of function 'slit_distance'; did you mean 'node_distance'? [-Werror=implicit-function-declaration]

  540 |                 slit_distance(0, 0) = LOCAL_DISTANCE;
      |                 ^~~~~~~~~~~~~
      |                 node_distance

arch/ia64/kernel/acpi.c:540:37: error: lvalue required as left operand of assignment
540 | slit_distance(0, 0) = LOCAL_DISTANCE;
| ^

Guenter

Crap, ok, I'll go drop the 3 patches that this change came from. Odds are someone still uses ia64...

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v4.19:

    10 builds:	10 pass, 0 fail
    22 boots:	22 pass, 0 fail
    40 tests:	40 pass, 0 fail

Linux version: 4.19.235-rc2-g4401d649cac2
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra30-cardhu-a04

Jon

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

## Build
* kernel: 4.19.235-rc2
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git branch: linux-4.19.y
* git commit: 4401d649cac2c3bf2cca0caf51a27f17b4f8bc26
* git describe: v4.19.234-30-g4401d649cac2
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19.234-30-g4401d649cac2

## Test Regressions (compared to v4.19.233-19-g83f8068e02bc) No test regressions found.

## Metric Regressions (compared to v4.19.233-19-g83f8068e02bc) No metric regressions found.

## Test Fixes (compared to v4.19.233-19-g83f8068e02bc) No test fixes found.

## Metric Fixes (compared to v4.19.233-19-g83f8068e02bc) No metric fixes found.

## Test result summary
total: 73008, pass: 60870, fail: 357, skip: 10332, xfail: 1449

## Build Summary
* arm: 281 total, 275 passed, 6 failed
* arm64: 39 total, 39 passed, 0 failed
* dragonboard-410c: 1 total, 1 passed, 0 failed
* hi6220-hikey: 1 total, 1 passed, 0 failed
* i386: 19 total, 19 passed, 0 failed
* juno-r2: 1 total, 1 passed, 0 failed
* mips: 27 total, 27 passed, 0 failed
* powerpc: 60 total, 49 passed, 11 failed
* s390: 12 total, 12 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x15: 1 total, 1 passed, 0 failed
* x86: 1 total, 1 passed, 0 failed
* x86_64: 38 total, 38 passed, 0 failed

## Test suites summary
* fwts
* kselftest-android
* kselftest-bpf
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kvm-unit-tests
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* perf
* rcutorture
* ssuite
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org

Hi Greg,

Build test:
mips (gcc version 11.2.1 20220301): 63 configs -> no failure arm (gcc version 11.2.1 20220301): 116 configs -> no new failure arm64 (gcc version 11.2.1 20220301): 2 configs -> no failure x86_64 (gcc version 11.2.1 20220301): 4 configs -> no failure

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]

[1]. https://openqa.qa.codethink.co.uk/tests/880

--
Regards
Sudip

hello,

Compiled and booted 4.19.235-rc2+ on ...

Processor Information
Socket Designation: FM2
Type: Central Processor
Family: A-Series
Manufacturer: AuthenticAMD
ID: 31 0F 61 00 FF FB 8B 17
Signature: Family 21, Model 19, Stepping 1

I think No major new regression or regressions from dmesg. Some error related stuff has happened.
Please see the attachment for build issues related.

software engineer
rajagiri school of engineering and technology  -  autonomous

------------------------<error related clipping 1>--------------------------
In function 'memcpy',
inlined from memcpy_fromio at ./include/asm-generic/io.h:1117:2,
inlined from ghes_copy_tofrom_phys at drivers/acpi/apei/ghes.c:311:4:
./include/linux/string.h:261:33: warning: __builtin_memcpy reading between 1 and 4096 bytes from a region of size 0 [-Wstringop-overread]

  261 | #define __underlying_memcpy     __builtin_memcpy
      |                                 ^

./include/linux/string.h:377:16: note: in expansion of macro __underlying_memcpy
377 | return __underlying_memcpy(p, q, size);

------------------------<error related clipping >--------------------------

------------------------<error related clipping 2>--------------------------

drivers/crypto/ccp/sp-platform.c:37:34: warning: array sp_of_match assumed to have one element
37 | static const struct of_device_id sp_of_match[];
------------------------<error related clipping>--------------------------

------------------------<error related clipping 3>--------------------------
ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text'
ld: warning: creating DT_TEXTREL in a PIE
------------------------<error related clipping>--------------------------

hello,
did you get my previous email?

i am forwarding it .

---------- Forwarded message ---------
From: Jeffrin Thalakkottoor <[email protected]>
Date: Tue, Mar 15, 2022 at 11:04 PM
Subject: Re: [PATCH 4.19 00/29] 4.19.235-rc2 review
To: Greg Kroah-Hartman <[email protected]>
Cc: lkml <[email protected]>, Greg Kroah-Hartman <[email protected]>, <[email protected]>, <[email protected]>, Andrew Morton <[email protected]>, Guenter Roeck <[email protected]>, Shuah Khan <[email protected]>, <[email protected]>, <[email protected]>, Pavel Machek <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>

hello,

Compiled and booted 4.19.235-rc2+ on ...

Processor Information
Socket Designation: FM2
Type: Central Processor
Family: A-Series
Manufacturer: AuthenticAMD
ID: 31 0F 61 00 FF FB 8B 17
Signature: Family 21, Model 19, Stepping 1

I think No major new regression or regressions from dmesg. Some error related stuff has happened.
Please see the attachment for build issues related.

--
software engineer
rajagiri school of engineering and technology - autonomous

software engineer
rajagiri school of engineering and technology

------------------------<error related clipping 1>--------------------------
In function 'memcpy',
inlined from memcpy_fromio at ./include/asm-generic/io.h:1117:2,
inlined from ghes_copy_tofrom_phys at drivers/acpi/apei/ghes.c:311:4:
./include/linux/string.h:261:33: warning: __builtin_memcpy reading between 1 and 4096 bytes from a region of size 0 [-Wstringop-overread]

  261 | #define __underlying_memcpy     __builtin_memcpy
      |                                 ^

./include/linux/string.h:377:16: note: in expansion of macro __underlying_memcpy
377 | return __underlying_memcpy(p, q, size);

------------------------<error related clipping >--------------------------

------------------------<error related clipping 2>--------------------------

drivers/crypto/ccp/sp-platform.c:37:34: warning: array sp_of_match assumed to have one element
37 | static const struct of_device_id sp_of_match[];
------------------------<error related clipping>--------------------------

------------------------<error related clipping 3>--------------------------
ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text'
ld: warning: creating DT_TEXTREL in a PIE
------------------------<error related clipping>--------------------------

Hi!

...

Are the build issues new in 4.19.235?

In that case you probably should not be giving Tested-by: tag, and we probably should figure out which patch causes them...

Best regards,
Pavel

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Tested on arm64 and x86 for 4.19.235-rc2,

Kernel repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-4.19.y
Version: 4.19.235-rc2
Commit: 4401d649cac2c3bf2cca0caf51a27f17b4f8bc26
Compiler: gcc version 7.3.0 (GCC)

arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8938
passed: 8938
failed: 0
timeout: 0
--------------------------------------------------------------------

x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8938
passed: 8938
failed: 0
timeout: 0
--------------------------------------------------------------------