fix typos in comments
Subsystems (46)
cover fix typos in comments
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
---
drivers/base/devres.c | 4 ++-- drivers/clk/qcom/gcc-sm6125.c | 2 +- drivers/clk/ti/clkctrl.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 6 +++--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- drivers/gpu/drm/sti/sti_gdp.c | 2 +- drivers/infiniband/hw/qib/qib_iba7220.c | 4 ++-- drivers/leds/leds-pca963x.c | 2 +- drivers/media/i2c/ov5695.c | 2 +- drivers/mfd/rohm-bd9576.c | 2 +- drivers/mtd/ubi/block.c | 2 +- drivers/net/can/usb/ucan.c | 4 ++-- drivers/net/ethernet/packetengines/yellowfin.c | 2 +- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 2 +- drivers/net/wireless/cisco/airo.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++--- drivers/platform/x86/uv_sysfs.c | 2 +- drivers/s390/crypto/pkey_api.c | 2 +- drivers/scsi/aic7xxx/aicasm/aicasm.c | 2 +- drivers/scsi/elx/libefc_sli/sli4.c | 2 +- drivers/scsi/lpfc/lpfc_mbox.c | 2 +- drivers/scsi/qla2xxx/qla_gs.c | 2 +- drivers/spi/spi-sun4i.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/usb/gadget/udc/snps_udc_core.c | 2 +- fs/kernfs/file.c | 2 +- kernel/events/core.c | 2 +- 30 files changed, 39 insertions(+), 39 deletions(-)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
PATCH 1/30 drm/amd/pm: fix typos in comments
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -1
@@ -1870,7 +1870,7 @@ static ssize_t amdgpu_set_smartshift_bias(struct device *dev, amdgpu_smartshift_bias = bias; r = count; -/* TODO: upadte bias level with SMU message */ +/* TODO: update bias level with SMU message */ out:pm_runtime_mark_last_busy (ddev->dev);
Alex Deucher
AppliedRe: [PATCH 01/30] drm/amd/pm: fix typos in comments
Applied. Thanks!
Quoted 24 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/amdgpu_pm.c +1
-1@@ -1870,7 +1870,7 @@ static ssize_t amdgpu_set_smartshift_bias(struct device *dev, amdgpu_smartshift_bias = bias; r = count; -/* TODO: upadte bias level with SMU message */ +/* TODO: update bias level with SMU message */ out:pm_runtime_mark_last_busy (ddev->dev);
PATCH 2/30 scsi: lpfc: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/scsi/lpfc/lpfc_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_mbox.c +1 -1
@@ -429,7 +429,7 @@ lpfc_config_msi(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)memset (pmb,0 ,sizeof (LPFC_MBOXQ_t));/* -* SLI-3, Message Signaled Interrupt Fearure. +* SLI-3, Message Signaled Interrupt Feature. */ /* Multi-message attention configuration */
PATCH 3/30 ath6kl: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath6kl/htc_mbox.c +1 -1
@@ -1538,7 +1538,7 @@ static int ath6kl_htc_rx_alloc(struct htc_target *target, queue, n_msg);/* -* This is due to unavailabilty of buffers to rx entire data. +* This is due to unavailability of buffers to rx entire data. * Return no error so that free buffers from queue can be used * to receive partial data. */
Re: [PATCH 03/30] ath6kl: fix typos in comments
Quoted 5 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
b7d174479c8a ath6kl: fix typos in comments
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 4/30 kernfs: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- fs/kernfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/kernfs/file.c +1 -1
@@ -997,7 +997,7 @@ struct kernfs_node *__kernfs_create_file(struct kernfs_node *parent,#endif /* -* kn->attr.ops is accesible only while holding active ref. We +* kn->attr.ops is accessible only while holding active ref. We * need to know whether some ops are implemented outside active * ref. Cache their existence in flags. */
PATCH 5/30 x86/platform/uv: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/platform/x86/uv_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/uv_sysfs.c +1 -1
@@ -555,7 +555,7 @@ static int init_pci_top_obj(struct uv_pci_top_obj *top_obj, char *line)*/ line[6 ] ='_' ; -/* Null terminate after the concatencated name tokens +/* Null terminate after the concatenated name tokens * to produce kobj name string. */ line[14 ] ='\0' ;
RE: [PATCH 05/30] x86/platform/uv: fix typos in comments
Hi Julia,
Thanks for the patch. I appreciate the time spent finding this.
-Justin
Quoted 22 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/platform/x86/uv_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/uv_sysfs.c +1
-1@@ -555,7 +555,7 @@ static int init_pci_top_obj(struct uv_pci_top_obj *top_obj, char *line)*/ line[6 ] ='_' ; -/* Null terminate after the concatencated name tokens +/* Null terminate after the concatenated name tokens * to produce kobj name string. */ line[14 ] ='\0' ;
PATCH 6/30 drm/bridge: analogix_dp: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +2 -2
@@ -567,7 +567,7 @@ static int analogix_dp_process_equalizer_training(struct analogix_dp_device *dp)analogix_dp_get_adjust_training_lane (dp, adjust_request);if (!analogix_dp_channel_eq_ok (link_status, link_align, lane_count)) { -/* traing pattern Set to Normal */ +/* training pattern Set to Normal */ retval =analogix_dp_training_pattern_dis (dp);if (retval <0 )return retval;
@@ -1254,7 +1254,7 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge,/* * NOTE: the connector registration is implemented in analogix * platform driver, that to say connector would be exist after -* plat_data->attch return, that's why we record the connector +* plat_data->attach return, that's why we record the connector * point after plat attached. */ if (dp->plat_data->attach) {
Re: [PATCH 06/30] drm/bridge: analogix_dp: fix typos in comments
Quoted 34 lines · On Mon, Mar 14, 2022, 12:53 Julia Lawall <[email protected]> wrote:
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +1
-1@@ -567,7 +567,7 @@ static int analogix_dp_process_equalizer_training(struct analogix_dp_device *dp)analogix_dp_get_adjust_training_lane (dp, adjust_request);if (!analogix_dp_channel_eq_ok (link_status, link_align, lane_count)) { -/* traing pattern Set to Normal */ +/* training pattern Set to Normal */ retval =analogix_dp_training_pattern_dis (dp);if (retval < 0) return retval;drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +1
-1@@ -1254,7 +1254,7 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge,/* * NOTE: the connector registration is implemented in analogix * platform driver, that to say connector would be exist after -* plat_data->attch return, that's why we record the connector +* plat_data->attach return, that's why we record the connector * point after plat attached. */
Quoted 2 lines
if (dp->plat_data->attach) {Quoted 1 line
PATCH 7/30 staging: rtl8723bs: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +1 -1
@@ -24,7 +24,7 @@ int rtw_init_mlme_priv(struct adapter *padapter) pmlmepriv->fw_state =WIFI_STATION_STATE ;/* Must sync with rtw_wdev_alloc() */ /* wdev->iftype = NL80211_IFTYPE_STATION */ pmlmepriv->cur_network.network.infrastructure_mode = Ndis802_11AutoUnknown; - pmlmepriv->scan_mode =SCAN_ACTIVE ;/* 1: active, 0: pasive. Maybe someday we should rename this varable to "active_mode" (Jeff) */ + pmlmepriv->scan_mode =SCAN_ACTIVE ;/* 1: active, 0: passive. Maybe someday we should rename this varable to "active_mode" (Jeff) */ spin_lock_init (&pmlmepriv->lock);INIT_LIST_HEAD (&pmlmepriv->free_bss_pool.queue);
PATCH 8/30 leds: pca963x: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/leds/leds-pca963x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-pca963x.c +1 -1
@@ -249,7 +249,7 @@ static int pca963x_blink_set(struct led_classdev *led_cdev, period =pca963x_period_scale (led, time_on + time_off); -/* If period not supported by hardware, default to someting sane. */ +/* If period not supported by hardware, default to something sane. */ if ((period <PCA963X_BLINK_PERIOD_MIN ) || (period >PCA963X_BLINK_PERIOD_MAX )) { time_on =500 ;
PATCH 9/30 media: i2c: ov5695: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/media/i2c/ov5695.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/ov5695.c +1 -1
@@ -1122,7 +1122,7 @@ static int ov5695_set_ctrl(struct v4l2_ctrl *ctrl)switch (ctrl->id) {case V4L2_CID_EXPOSURE : -/* 4 least significant bits of expsoure are fractional part */ +/* 4 least significant bits of exposure are fractional part */ ret =ov5695_write_reg (ov5695->client,OV5695_REG_EXPOSURE ,OV5695_REG_VALUE_24BIT , ctrl->val <<4 );break ;
Sakari Ailus
AppliedRe: [PATCH 09/30] media: i2c: ov5695: fix typos in comments
Quoted 14 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/media/i2c/ov5695.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/ov5695.c +0
-0
drivers/media/i2c/ov5695.c static int ov5695_set_ctrl(struct v4l2_ctrl *ctrl) · line 1128
Quoted 8 lines
drivers/media/i2c/ov5695.c +1
-1@@ -1122,7 +1122,7 @@ static int ov5695_set_ctrl(struct v4l2_ctrl *ctrl)switch (ctrl->id) {case V4L2_CID_EXPOSURE : -/* 4 least significant bits of expsoure are fractional part */ +/* 4 least significant bits of exposure are fractional part */ ret =ov5695_write_reg (ov5695->client,OV5695_REG_EXPOSURE ,OV5695_REG_VALUE_24BIT , ctrl->val <<4 );break ;
Applied, thanks!
Signature · 1 line
Sakari Ailus
PATCH 10/30 mt76: mt7915: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7915/init.c +1 -1
@@ -579,7 +579,7 @@ static void mt7915_wfsys_reset(struct mt7915_dev *dev) val &= ~MT_TOP_PWR_SW_RST ;mt76_wr (dev,MT_TOP_PWR_CTRL , val); -/* release wfsys then mcu re-excutes romcode */ +/* release wfsys then mcu re-executes romcode */ val |=MT_TOP_PWR_SW_RST ;mt76_wr (dev,MT_TOP_PWR_CTRL , val);
PATCH 11/30 usb: gadget: udc: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/usb/gadget/udc/snps_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/snps_udc_core.c +1 -1
@@ -80,7 +80,7 @@ static int stop_timer;* This cannot be solved by letting the RX DMA disabled until a * request gets queued because there may be other OUT packets * in the FIFO (important for not blocking control traffic). -* The value of set_rde controls the correspondig timer. +* The value of set_rde controls the corresponding timer. * * set_rde -1 == not used, means it is alloed to be set to 0 or 1 * set_rde 0 == do not touch RDE, do no start the RDE timer
PATCH 12/30 drivers: net: packetengines: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/ethernet/packetengines/yellowfin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/packetengines/yellowfin.c +1 -1
@@ -191,7 +191,7 @@ IV. Notes Thanks to Kim Stearns of Packet Engines for providing a pair of G-NIC boards. Thanks to Bruce Faust of Digitalscape for providing both their SYM53C885 board -and an AlphaStation to verifty the Alpha port! +and an AlphaStation to verify the Alpha port! IVb. References
Jakub Kicinski
maintainerRe: [PATCH 12/30] drivers: net: packetengines: fix typos in comments
Quoted 2 lines · On Mon, 14 Mar 2022 12:53:36 +0100 Julia Lawall wrote:
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
FWIW it would be easier to process the patches if they were posted individually, there are no dependencies here.
Re: [PATCH 12/30] drivers: net: packetengines: fix typos in comments
Quoted 6 lines · Jakub Kicinski
Quoted 2 lines · On Mon, 14 Mar 2022 12:53:36 +0100 Julia Lawall wrote:
Various spelling mistakes in comments.
Detected with the help of Coccinelle.FWIW it would be easier to process the patches if they were posted individually, there are no dependencies here.
OK, I hesitated between different options. If I send more, I will do as you suggest.
thanks,
julia
PATCH 13/30 UBI: block: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/mtd/ubi/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/block.c +1 -1
@@ -441,7 +441,7 @@ int ubiblock_create(struct ubi_volume_info *vi)/* * Create one workqueue per volume (per registered block device). -* Rembember workqueues are cheap, they're not threads. +* Remember workqueues are cheap, they're not threads. */ dev->wq =alloc_workqueue ("%s" ,0 ,0 , gd->disk_name);if (!dev->wq) {
PATCH 14/30 clk: ti: clkctrl: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/clk/ti/clkctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/ti/clkctrl.c +1 -1
@@ -603,7 +603,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)/* * The code below can be removed when all clkctrl nodes use domain -* specific compatible proprerty and standard clock node naming +* specific compatible property and standard clock node naming */ if (legacy_naming) { provider->clkdm_name =kasprintf (GFP_KERNEL ,"%pOFnxxx" , node->parent);
Re: [PATCH 14/30] clk: ti: clkctrl: fix typos in comments
Quoting Julia Lawall (2022-03-14 04:53:38)
Quoted 6 lines
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>---
Applied to clk-next
PATCH 15/30 clk: qcom: sm6125-gcc: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/clk/qcom/gcc-sm6125.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/gcc-sm6125.c +1 -1
@@ -4151,7 +4151,7 @@ static int gcc_sm6125_probe(struct platform_device *pdev)/* * Enable DUAL_EDGE mode for MCLK RCGs -* This is requierd to enable MND divider mode +* This is required to enable MND divider mode */ regmap_update_bits (regmap,0x51004 ,0x3000 ,0x2000 );regmap_update_bits (regmap,0x51020 ,0x3000 ,0x2000 );
Re: [PATCH 15/30] clk: qcom: sm6125-gcc: fix typos in comments
Quoting Julia Lawall (2022-03-14 04:53:39)
Quoted 6 lines
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>---
Applied to clk-next
PATCH 16/30 drm/sti: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/gpu/drm/sti/sti_gdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sti/sti_gdp.c +1 -1
@@ -406,7 +406,7 @@ static struct sti_gdp_node_list *sti_gdp_get_free_nodes(struct sti_gdp *gdp) (hw_nvn != gdp->node_list[i].top_field_paddr))return &gdp->node_list[i]; -/* in hazardious cases restart with the first node */ +/* in hazardous cases restart with the first node */ DRM_ERROR ("inconsistent NVN for %s: 0x%08X\n" ,sti_plane_to_str (&gdp->plane), hw_nvn);
Re: [PATCH 16/30] drm/sti: fix typos in comments
Hi Julia
thanks for the patch.
Alain
Quoted 23 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/gpu/drm/sti/sti_gdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/sti/sti_gdp.c +1
-1@@ -406,7 +406,7 @@ static struct sti_gdp_node_list *sti_gdp_get_free_nodes(struct sti_gdp *gdp) (hw_nvn != gdp->node_list[i].top_field_paddr))return &gdp->node_list[i]; -/* in hazardious cases restart with the first node */ +/* in hazardous cases restart with the first node */ DRM_ERROR ("inconsistent NVN for %s: 0x%08X\n" ,sti_plane_to_str (&gdp->plane), hw_nvn);
PATCH 17/30 scsi: elx: libefc_sli: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/scsi/elx/libefc_sli/sli4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/elx/libefc_sli/sli4.c +1 -1
@@ -4127,7 +4127,7 @@ sli_calc_max_qentries(struct sli4 *sli4) sli4->qinfo.count_mask[q]); } -/* single, continguous DMA allocations will be called for each queue +/* single, contiguous DMA allocations will be called for each queue * of size (max_qentries * queue entry size); since these can be large, * check against the OS max DMA allocation size */
PATCH 18/30 devres: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/base/devres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/devres.c +2 -2
@@ -692,7 +692,7 @@ EXPORT_SYMBOL_GPL(devres_release_group);/* * Custom devres actions allow inserting a simple function call -* into the teadown sequence. +* into the teardown sequence. */ struct action_devres {
@@ -916,7 +916,7 @@ void *devm_krealloc(struct device *dev, void *ptr, size_t new_size, gfp_t gfp)/* * We can copy the memory contents after releasing the lock as we're -* no longer modyfing the list links. +* no longer modifying the list links. */ memcpy (new_dr->data, old_dr->data, total_old_size - offsetof(struct devres , data));
PATCH 19/30 rtlwifi: rtl8821ae: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c +3 -3
@@ -872,7 +872,7 @@ static void rtl8821ae_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)else falsealm_cnt->cnt_all = falsealm_cnt->cnt_ofdm_fail; -/*reset OFDM FA coutner*/ +/*reset OFDM FA counter*/ rtl_set_bbreg (hw,ODM_REG_OFDM_FA_RST_11AC ,BIT (17 ),1 );rtl_set_bbreg (hw,ODM_REG_OFDM_FA_RST_11AC ,BIT (17 ),0 );/* reset CCK FA counter*/
@@ -1464,7 +1464,7 @@ void rtl8812ae_dm_txpower_tracking_callback_thermalmeter(const u8 *delta_swing_table_idx_tup_b;const u8 *delta_swing_table_idx_tdown_b; -/*2. Initilization ( 7 steps in total )*/ +/*2. Initialization ( 7 steps in total )*/ rtl8812ae_get_delta_swing_table(hw, &delta_swing_table_idx_tup_a, &delta_swing_table_idx_tdown_a,
@@ -2502,7 +2502,7 @@ static void rtl8821ae_dm_check_edca_turbo(struct ieee80211_hw *hw) rtlpriv->dm.dbginfo.num_non_be_pkt =0 ;/*=============================== -* list paramter for different platform +* list parameter for different platform *=============================== */ pb_is_cur_rdl_state = &rtlpriv->dm.is_cur_rdlstate;
RE: [PATCH 19/30] rtlwifi: rtl8821ae: fix typos in comments
Quoted 10 lines
-----Original Message-----
From: Julia Lawall <[email protected]>
Sent: Monday, March 14, 2022 7:54 PM
To: Pkshih <[email protected]>
Cc: [email protected]; Kalle Valo <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: [PATCH 19/30] rtlwifi: rtl8821ae: fix typos in comments
Quoted 4 lines
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>
Thank you.
[...]
Re: [PATCH 19/30] rtlwifi: rtl8821ae: fix typos in comments
In reply to Julia LawallQuoted 5 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>Acked-by Ping-Ke Shih <[email protected]>
2 patches applied to wireless-next.git, thanks.
31f8bef8acab rtlwifi: rtl8821ae: fix typos in comments bfbd78cfdd62 airo: fix typos in comments
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 20/30 airo: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/wireless/cisco/airo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/cisco/airo.c +1 -1
@@ -545,7 +545,7 @@ struct ConfigRid {#define MODE_CFG_MASK cpu_to_le16(0xff)#define MODE_ETHERNET_HOST cpu_to_le16(0<<8)/* rx payloads converted */ #define MODE_LLC_HOST cpu_to_le16(1<<8)/* rx payloads left as is */ -#define MODE_AIRONET_EXTEND cpu_to_le16(1<<9)/* enable Aironet extenstions */ +#define MODE_AIRONET_EXTEND cpu_to_le16(1<<9)/* enable Aironet extensions */ #define MODE_AP_INTERFACE cpu_to_le16(1<<10)/* enable ap interface extensions */ #define MODE_ANTENNA_ALIGN cpu_to_le16(1<<11)/* enable antenna alignment */ #define MODE_ETHER_LLC cpu_to_le16(1<<12)/* enable ethernet LLC */
PATCH 21/30 spi: sun4i: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-sun4i.c +1 -1
@@ -280,7 +280,7 @@ static int sun4i_spi_transfer_one(struct spi_master *master,* SPI_CLK = MOD_CLK / (2 ^ (cdr + 1)) * Or we can use CDR2, which is calculated with the formula: * SPI_CLK = MOD_CLK / (2 * (cdr + 1)) -* Wether we use the former or the latter is set through the +* Whether we use the former or the latter is set through the * DRS bit. * * First try CDR2, and if we can't reach the expected
Re: [PATCH 21/30] spi: sun4i: fix typos in comments
Quoted 5 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>
PATCH 22/30 RDMA/hw/qib/qib_iba7220: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/infiniband/hw/qib/qib_iba7220.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/qib/qib_iba7220.c +2 -2
@@ -634,7 +634,7 @@ static const struct qib_hwerror_msgs qib_7220_hwerror_msgs[] = {QLOGIC_IB_HWE_MSG (QLOGIC_IB_HWE_PCIECPLTIMEOUT , "PCIe completion timeout"),/* -* In practice, it's unlikely wthat we'll see PCIe PLL, or bus +* In practice, it's unlikely that we'll see PCIe PLL, or bus * parity or memory parity error failures, because most likely we * won't be able to talk to the core of the chip. Nonetheless, we * might see them, if they are in parts of the PCIe core that aren't
@@ -2988,7 +2988,7 @@ static u64 qib_portcntr_7220(struct qib_pportdata *ppd, u32 reg)* the utility. Names need to be 12 chars or less (w/o newline), for proper * display by utility. * Non-error counters are first. -* Start of "error" conters is indicated by a leading "E " on the first +* Start of "error" counters is indicated by a leading "E " on the first * "error" counter, and doesn't count in label length. * The EgrOvfl list needs to be last so we truncate them at the configured * context count for the device.
Re: [PATCH 22/30] RDMA/hw/qib/qib_iba7220: fix typos in comments
Quoted 7 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/infiniband/hw/qib/qib_iba7220.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to rdma for-next, thanks
Jason
PATCH 23/30 drm/amdgpu/dc: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/command_table.c +3 -3
@@ -456,7 +456,7 @@ static enum bp_result transmitter_control_v2(if ((CONNECTOR_ID_DUAL_LINK_DVII == connector_id) || (CONNECTOR_ID_DUAL_LINK_DVID == connector_id))/* on INIT this bit should be set according to the -* phisycal connector +* physical connector * Bit0: dual link connector flag * =0 connector is single link connector * =1 connector is dual link connector
@@ -468,7 +468,7 @@ static enum bp_result transmitter_control_v2(cpu_to_le16 ((uint8_t )cntl->connector_obj_id.id);break ;case TRANSMITTER_CONTROL_SET_VOLTAGE_AND_PREEMPASIS : -/* votage swing and pre-emphsis */ +/* voltage swing and pre-emphsis */ params.asMode.ucLaneSel = (uint8_t )cntl->lane_select; params.asMode.ucLaneSet = (uint8_t )cntl->lane_settings;break ;
@@ -2120,7 +2120,7 @@ static enum bp_result program_clock_v5(memset (¶ms,0 ,sizeof (params));if (!bp->cmd_helper->clock_source_id_to_atom ( bp_params->pll_id, &atom_pll_id)) { -BREAK_TO_DEBUGGER ();/* Invalid Inpute!! */ +BREAK_TO_DEBUGGER ();/* Invalid Input!! */ return BP_RESULT_BADINPUT ; }
Alex Deucher
AppliedRe: [PATCH 23/30] drm/amdgpu/dc: fix typos in comments
Applied. Thanks!
Quoted 42 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/dc/bios/command_table.c +3
-3@@ -456,7 +456,7 @@ static enum bp_result transmitter_control_v2(if ((CONNECTOR_ID_DUAL_LINK_DVII == connector_id) || (CONNECTOR_ID_DUAL_LINK_DVID == connector_id))/* on INIT this bit should be set according to the -* phisycal connector +* physical connector * Bit0: dual link connector flag * =0 connector is single link connector * =1 connector is dual link connector @@ -468,7 +468,7 @@ static enum bp_result transmitter_control_v2(cpu_to_le16 ((uint8_t )cntl->connector_obj_id.id);break ;case TRANSMITTER_CONTROL_SET_VOLTAGE_AND_PREEMPASIS : -/* votage swing and pre-emphsis */ +/* voltage swing and pre-emphsis */ params.asMode.ucLaneSel = (uint8_t )cntl->lane_select; params.asMode.ucLaneSet = (uint8_t )cntl->lane_settings;break ;@@ -2120,7 +2120,7 @@ static enum bp_result program_clock_v5(memset (¶ms,0 ,sizeof (params));if (!bp->cmd_helper->clock_source_id_to_atom ( bp_params->pll_id, &atom_pll_id)) { -BREAK_TO_DEBUGGER ();/* Invalid Inpute!! */ +BREAK_TO_DEBUGGER ();/* Invalid Input!! */ return BP_RESULT_BADINPUT ; }
PATCH 24/30 scsi: qla2xxx: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/scsi/qla2xxx/qla_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_gs.c +1 -1
@@ -1767,7 +1767,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries, size += alen;ql_dbg (ql_dbg_disc, vha,0x20aa ,"CT PAYLOAD LENGTH = 0x%x.\n" ,be32_to_cpu (eiter->a.max_ct_len)); -/* Node Sybolic Name */ +/* Node Symbolic Name */ eiter = entries + size; eiter->type =cpu_to_be16 (FDMI_HBA_NODE_SYMBOLIC_NAME ); alen = qla2x00_get_sym_node_name(vha, eiter->a.sym_name,
PATCH 25/30 treewide: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/scsi/aic7xxx/aicasm/aicasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/aic7xxx/aicasm/aicasm.c +1 -1
@@ -283,7 +283,7 @@ main(int argc, char *argv[])/* * Decend the tree of scopes and insert/emit * patches as appropriate. We perform a depth first -* tranversal, recursively handling each scope. +* traversal, recursively handling each scope. */ /* start at the root scope */ dump_scope (SLIST_FIRST (&scope_stack));
PATCH 26/30 s390/pkey: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/s390/crypto/pkey_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/crypto/pkey_api.c +1 -1
@@ -155,7 +155,7 @@ static int pkey_skey2pkey(const u8 *key, struct pkey_protkey *pkey)/* * The cca_xxx2protkey call may fail when a card has been * addressed where the master key was changed after last fetch -* of the mkvp into the cache. Try 3 times: First witout verify +* of the mkvp into the cache. Try 3 times: First without verify * then with verify and last round with verify and old master * key verification pattern match not ignored. */
PATCH 27/30 can: ucan: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/net/can/usb/ucan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/can/usb/ucan.c +2 -2
@@ -1392,7 +1392,7 @@ static int ucan_probe(struct usb_interface *intf,* Stage 3 for the final driver initialisation. */ -/* Prepare Memory for control transferes */ +/* Prepare Memory for control transfers */ ctl_msg_buffer =devm_kzalloc (&udev->dev,sizeof (union ucan_ctl_payload ),GFP_KERNEL );
@@ -1526,7 +1526,7 @@ static int ucan_probe(struct usb_interface *intf, ret =ucan_device_request_in (up,UCAN_DEVICE_GET_FW_STRING ,0 ,sizeof (union ucan_ctl_payload ));if (ret >0 ) { -/* copy string while ensuring zero terminiation */ +/* copy string while ensuring zero termination */ strncpy (firmware_str, up->ctl_msg_buffer->raw,sizeof (union ucan_ctl_payload )); firmware_str[sizeof (union ucan_ctl_payload )] ='\0' ;
Re: [PATCH 27/30] can: ucan: fix typos in comments
Quoted 4 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>
Should I take this, or are you going to upstream this?
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Re: [PATCH 27/30] can: ucan: fix typos in comments
Quoted 9 lines · Marc Kleine-Budde
Quoted 4 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>Should I take this, or are you going to upstream this?
You can take it.
thanks,
julia
Quoted 9 lines
Marc
--
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Marc Kleine-Budde
maintainerRe: [PATCH 27/30] can: ucan: fix typos in comments
Quoted 8 lines · Julia Lawall
Quoted 4 lines · Marc Kleine-Budde
Quoted 3 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Julia Lawall <[email protected]>Should I take this, or are you going to upstream this?
You can take it.
Added to linux-can-next/testing.
Thanks,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 28/30 mfd: bd9576: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/mfd/rohm-bd9576.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/rohm-bd9576.c +1 -1
@@ -23,7 +23,7 @@ enum { };/* -* Due to the BD9576MUF nasty IRQ behaiour we don't always populate IRQs. +* Due to the BD9576MUF nasty IRQ behaviour we don't always populate IRQs. * These will be added to regulator resources only if IRQ information for the * PMIC is populated in device-tree. */
Re: [PATCH 28/30] mfd: bd9576: fix typos in comments
Thanks!
Quoted 4 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>
Quoted 19 lines
--- drivers/mfd/rohm-bd9576.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mfd/rohm-bd9576.c +1
-1@@ -23,7 +23,7 @@ enum { };/* -* Due to the BD9576MUF nasty IRQ behaiour we don't always populate IRQs. +* Due to the BD9576MUF nasty IRQ behaviour we don't always populate IRQs. * These will be added to regulator resources only if IRQ information for the * PMIC is populated in device-tree. */
Signature · 9 lines
The Linux Kernel guy at ROHM Semiconductors Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~ this year is the year of a signature writers block ~~
Lee Jones
AppliedRe: [PATCH 28/30] mfd: bd9576: fix typos in comments
In reply to Julia LawallQuoted 8 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/mfd/rohm-bd9576.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 29/30 drm/amdgpu: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2 -2
@@ -340,7 +340,7 @@ static void amdgpu_cs_get_threshold_for_moves(struct amdgpu_device *adev,if (free_vram >=128 *1024 *1024 || free_vram >= total_vram /8 ) {s64 min_us; -/* Be more aggresive on dGPUs. Try to fill a portion of free +/* Be more aggressive on dGPUs. Try to fill a portion of free * VRAM now. */ if (!(adev->flags &AMD_IS_APU ))
@@ -1280,7 +1280,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,continue ;/* -* Work around dma_resv shortcommings by wrapping up the +* Work around dma_resv shortcomings by wrapping up the * submission in a dma_fence_chain and add it as exclusive * fence. */
Alex Deucher
AppliedRe: [PATCH 29/30] drm/amdgpu: fix typos in comments
Applied. Thanks!
Alex
Quoted 33 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2
-2@@ -340,7 +340,7 @@ static void amdgpu_cs_get_threshold_for_moves(struct amdgpu_device *adev,if (free_vram >=128 *1024 *1024 || free_vram >= total_vram /8 ) {s64 min_us; -/* Be more aggresive on dGPUs. Try to fill a portion of free +/* Be more aggressive on dGPUs. Try to fill a portion of free * VRAM now. */ if (!(adev->flags &AMD_IS_APU ))@@ -1280,7 +1280,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,continue ;/* -* Work around dma_resv shortcommings by wrapping up the +* Work around dma_resv shortcomings by wrapping up the * submission in a dma_fence_chain and add it as exclusive * fence. */
PATCH 30/30 perf/core: fix typos in comments
In reply to Julia LawallVarious spelling mistakes in comments.
Detected with the help of Coccinelle.
--- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -1
@@ -872,7 +872,7 @@ static void perf_cgroup_switch(struct task_struct *task, int mode)* event_filter_match() to not have to pass * task around * we pass the cpuctx->ctx to perf_cgroup_from_task() -* because cgorup events are only per-cpu +* because cgroup events are only per-cpu */ cpuctx->cgrp =perf_cgroup_from_task (task, &cpuctx->ctx);
Re: [PATCH 30/30] perf/core: fix typos in comments
Quoted 5 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.Signed-off-by Julia Lawall <[email protected]>
Thanks,
Ian
Quoted 18 lines
--- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/events/core.c +1
-1@@ -872,7 +872,7 @@ static void perf_cgroup_switch(struct task_struct *task, int mode)* event_filter_match() to not have to pass * task around * we pass the cpuctx->ctx to perf_cgroup_from_task() -* because cgorup events are only per-cpu +* because cgroup events are only per-cpu */ cpuctx->cgrp =perf_cgroup_from_task (task, &cpuctx->ctx);
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 28 lines · On Mon, 14 Mar 2022 12:53:24 +0100 you wrote:
Various spelling mistakes in comments.
Detected with the help of Coccinelle.---
drivers/base/devres.c | 4 ++-- drivers/clk/qcom/gcc-sm6125.c | 2 +- drivers/clk/ti/clkctrl.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 6 +++--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- drivers/gpu/drm/sti/sti_gdp.c | 2 +- drivers/infiniband/hw/qib/qib_iba7220.c | 4 ++-- drivers/leds/leds-pca963x.c | 2 +- drivers/media/i2c/ov5695.c | 2 +- drivers/mfd/rohm-bd9576.c | 2 +- drivers/mtd/ubi/block.c | 2 +- drivers/net/can/usb/ucan.c | 4 ++-- drivers/net/ethernet/packetengines/yellowfin.c | 2 +- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 2 +- drivers/net/wireless/cisco/airo.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++--- drivers/platform/x86/uv_sysfs.c | 2 +- drivers/s390/crypto/pkey_api.c | 2 +- drivers/scsi/aic7xxx/aicasm/aicasm.c | 2 +- drivers/scsi/elx/libefc_sli/sli4.c | 2 +-
Quoted 8 lines
drivers/scsi/lpfc/lpfc_mbox.c | 2 +- drivers/scsi/qla2xxx/qla_gs.c | 2 +- drivers/spi/spi-sun4i.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/usb/gadget/udc/snps_udc_core.c | 2 +- fs/kernfs/file.c | 2 +- kernel/events/core.c | 2 +- 30 files changed, 39 insertions(+), 39 deletions(-)
Here is the summary with links:
- [03/30] ath6kl: fix typos in comments
(no matching commit)
- [10/30] mt76: mt7915: fix typos in comments
(no matching commit)
- [12/30] drivers: net: packetengines: fix typos in comments
https://git.kernel.org/netdev/net-next/c/ebc0b8b5374e
- [19/30] rtlwifi: rtl8821ae: fix typos in comments (no matching commit)
- [20/30] airo: fix typos in comments
(no matching commit)
- [27/30] can: ucan: fix typos in comments (no matching commit)
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Martin K. Petersen
AppliedJulia,
Quoted 4 lines
drivers/scsi/aic7xxx/aicasm/aicasm.c | 2 +- drivers/scsi/elx/libefc_sli/sli4.c | 2 +- drivers/scsi/lpfc/lpfc_mbox.c | 2 +- drivers/scsi/qla2xxx/qla_gs.c | 2 +-
Applied patches 2, 17, 24, and 25 to 5.18/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Care to describe _how_ coccinelle was helpful in finding these typos in comments?
Quoted 2 lines · Joe Perches
Care to describe _how_ coccinelle was helpful in finding these typos in comments?
First, Coccinelle can bind a metavariable to the comments before, within and after anohter kind of term. So I collected the comments before, within, and after statements and declarations.
Second, I also used Coccinelle to collect all of the identifiers referenced in the same file, and discarded all of these words from consideration.
Otherwise, it's the python library enchant for a dictionary, and some hacks to reduce the number of false positives, including dropping words that occur multiple times. The results are still maybe 90% false positives, though.
The semantic patch is attached. It gives around 30K results for the current linux-next.
julia
from __future__ import print_function
from nltk.stem import *
from sys import argv
import enchant
d = enchant.Dict("en_US")
with open(argv[1]) as f:
for line in f:
word = line.split()[0]
if not(d.check(word)):
print(word)@initialize:ocaml@
@@
let seen = Hashtbl.create 101
let bseen = Hashtbl.create 101
let wseen = Hashtbl.create 101
let ids = Hashtbl.create 101
exception NotOK
let okw = ["aren";"isn";"wasn";"doesn";"didn";"weren";"shouldn";"couldn";"wouldn";"hasn";"haven";"linux";"hotplug";"cpu";"ifdef";"ifndef";"endif";"struct"]
let add i =
(if not (Hashtbl.mem ids i) then Hashtbl.add ids i ()); let pieces = Str.split (Str.regexp "_") i in List.iter
(fun i -> if not (Hashtbl.mem ids i) then Hashtbl.add ids i ())
pieces;false
let hasvowel s =
let vowels = ['a';'e';'i';'o';'u';'y';'A';'E';'I';'O';'U';'Y'] in try
String.iter
(fun c ->
if List.mem c vowels
then raise NotOK)
s;
false
with NotOK -> true
let only_letters s =
let islower c = 'a' <= c && c <= 'z' in
let isupper c = 'A' <= c && c <= 'Z' in
try
String.iteri
(fun i c ->
let ok =
if i = 0
then islower c || isupper c
else islower c in
if not ok
then raise NotOK)
s;
true
with NotOK -> false
let check bad loc p c =
if not(Hashtbl.mem seen c)
then
begin
Hashtbl.add seen c ();
let pieces = Str.split (Str.regexp "\\b") c in
List.iter
(fun word ->
if String.length word <= 2 || not(only_letters word) || Hashtbl.mem ids word || List.mem word !bad || not(hasvowel word) then ()
else
let word = String.uncapitalize_ascii word in
if List.mem word okw
then ()
else
let res =
try Hashtbl.find wseen word
with Not_found ->
let cmd =
Printf.sprintf "python spell.py %s" word in
let v = Common.cmd_to_list cmd in
Hashtbl.add wseen word v;
v in
List.iter
(fun wd ->
bad := word :: !bad;
Common.hashadd bseen word (loc,word,p))
res)
pieces
end
@script:ocaml@
@@
Hashtbl.clear seen
@identifier@
identifier i : script:ocaml() { add i };
@@
i
@r1@
comments c;
statement S;
position p;
@@
S@c@p
@script:ocaml@
c << r1.c;
p << r1.p;
@@
let bad = ref [] in
List.iter
(function c->
let (cb,ci,ca) = c in
List.iter (check bad "before" p) cb;
List.iter (check bad "within" p) ci;
List.iter (check bad "after" p) ca)
c
@r2@
comments c;
declaration d;
position p;
@@
d@c@p
@script:ocaml@
c << r2.c;
p << r2.p;
@@
let bad = ref [] in
List.iter
(function c->
let (cb,ci,ca) = c in
List.iter (check bad "before" p) cb;
List.iter (check bad "within" p) ci;
List.iter (check bad "after" p) ca)
c
@finalize:ocaml@
bseen << merge.bseen;
@@
List.iter
(fun bseen ->
Hashtbl.iter
(fun word l ->
match !l with
[(loc,word,p)] ->
Coccilib.print_main
(Printf.sprintf "problem with %s comment word: %s" loc word)
p
| _ -> ())
bseen)bseen
Mark Brown
maintainerRe: (subset) [PATCH 00/30] fix typos in comments
In reply to Julia LawallQuoted 3 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[21/30] spi: sun4i: fix typos in comments
commit: 2002c13243d595e211c0dad6b8e2e87f906f474b
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Martin K. Petersen
AppliedQuoted 3 lines · Julia Lawall
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Applied to 5.18/scsi-queue, thanks!
[02/30] scsi: lpfc: fix typos in comments
https://git.kernel.org/mkp/scsi/c/9a866e6aaf4e [17/30] scsi: elx: libefc_sli: fix typos in comments https://git.kernel.org/mkp/scsi/c/8037185d1ad8 [24/30] scsi: qla2xxx: fix typos in comments https://git.kernel.org/mkp/scsi/c/5419e0f15622 [25/30] treewide: fix typos in comments https://git.kernel.org/mkp/scsi/c/9d05790f5187
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering