Skip to contentSkip to conversation

FAILED: patch "[PATCH] staging: fbtft: fb_st7789v: reset display before" failed to apply to 5.10-stable tree

PATCH [email protected] 2 participants 3 messages Feb 28, 2022 – Mar 24, 2022

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From b6821b0d9b56386d2bf14806f90ec401468c799f Mon Sep 17 00:00:00 2001
From: Oliver Graute <[email protected]>
Date: Thu, 10 Feb 2022 09:53:22 +0100
Subject: [PATCH] staging: fbtft: fb_st7789v: reset display before
initialization

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

Fixes ef8f317795da (staging: fbtft: use init function instead of init sequence)
drivers/staging/fbtft/fb_st7789v.c +2 -0
index abe9395a0aef..861a154144e6 100644
@@ -144,6 +144,8 @@ static int init_display(struct fbtft_par *par)
 {
 	int rc;
 
+	par->fbtftops.reset(par);
+
 	rc = init_tearing_effect_line(par);
 	if (rc)
 		return rc;
#1 lore raw

Hi Greg,

Quoted 5 lines · On Mon, Feb 28, 2022 at 08:02:21AM +0100, [email protected] wrote:

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Here is the backport. Will also apply to all other stable trees.

--
Regards
Sudip

From dbe34d547c408290155c305f2cbd4a266c062391 Mon Sep 17 00:00:00 2001
From: Oliver Graute <[email protected]>
Date: Thu, 10 Feb 2022 09:53:22 +0100
Subject: [PATCH] staging: fbtft: fb_st7789v: reset display before
initialization

commit b6821b0d9b56386d2bf14806f90ec401468c799f upstream.

In rare cases the display is flipped or mirrored. This was observed more often in a low temperature environment. A clean reset on init_display() should help to get registers in a sane state.

Fixes ef8f317795da (staging: fbtft: use init function instead of init sequence)
[sudip: adjust context]
---
 drivers/staging/fbtft/fb_st7789v.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/staging/fbtft/fb_st7789v.c +2 -0
index 3a280cc1892c..0a2dbed9ffc7 100644
@@ -82,6 +82,8 @@ enum st7789v_command {
  */
 static int init_display(struct fbtft_par *par)
 {
+	par->fbtftops.reset(par);
+
 	/* turn off sleep mode */
 	write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
 	mdelay(120);
Signature · 1 line
2.30.2
author maintainer
#2 lore raw
Quoted 10 lines · Sudip Mukherjee

Hi Greg,

Quoted 5 lines · On Mon, Feb 28, 2022 at 08:02:21AM +0100, [email protected] wrote:

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Here is the backport. Will also apply to all other stable trees.

All now queued up, thanks!

greg k-h