5.10.110-rc1 review
Subsystems (9)
Greg Kroah-Hartman
maintainerQuoted 15 lines · Greg Kroah-Hartman
Quoted 14 lines · Greg Kroah-Hartman
Quoted 12 lines · Steven Rostedt
Quoted 3 lines · On Tue, 5 Apr 2022 23:08:12 -0400 Steven Rostedt <[email protected]> wrote:
Here's a thought, if you decide to backport a patch to stable, and you see that there's another commit with a "Fixes" tag to the automatically selected commit. DO NOT BACKPORT IF THE FIXES PATCH FAILS TO GO BACK TOO!
Seriously. This should be the case for *all* backported patches, not just the AUTOSEL ones.
Otherwise you are backporting a commit to "stable" that is KNOWN TO BE BROKEN!
Quoted 6 lines
Quoted 1 line
My scripts usually do catch this, let me go see what went wrong...
Ok, my fault, my scripts _did_ catch this, but I ignored it as it was filled with other noise. I've now queued this commit up.
thanks for catching this and sorry for missing it the first time around.
Wait, no, I did catch this! And I sent you a "FAILED" email about it, 4 of them:
https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected]
as the commit applied, but broke the build:
kernel/trace/trace_events.c: In function ‘update_event_fields’:kernel/trace/trace_events.c:2459:40: error: ‘TRACE_EVENT_FL_DYNAMIC’ undeclared (first use in this function); did you mean ‘FTRACE_OPS_FL_DYNAMIC’?
2459 | if (WARN_ON_ONCE(call->flags & TRACE_EVENT_FL_DYNAMIC))
| ^~~~~~~~~~~~~~~~~~~~~~
./include/asm-generic/bug.h:102:32: note: in definition of macro ‘WARN_ON_ONCE’
102 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~kernel/trace/trace_events.c:2459:40: note: each undeclared identifier is reported only once for each function it appears in
2459 | if (WARN_ON_ONCE(call->flags & TRACE_EVENT_FL_DYNAMIC))
| ^~~~~~~~~~~~~~~~~~~~~~
./include/asm-generic/bug.h:102:32: note: in definition of macro ‘WARN_ON_ONCE’
102 | int __ret_warn_on = !!(condition); \
| ^~~~~~~~~kernel/trace/trace_events.c:2491:25: error: ‘struct trace_event_call’ has no member named ‘module’
2491 | if (call->module)
| ^~kernel/trace/trace_events.c:2492:47: error: ‘struct trace_event_call’ has no member named ‘module’
2492 | add_str_to_module(call->module, str);
| ^~
But I didn't drop the offending commit, I should have done that.
I'll go and drop the offending commit here, if you could submit both of them as working backports to stable@vger if/when you want them queued up there, that would be great.
thanks,
greg k-h
Quoted 7 lines · On Wed, 6 Apr 2022 10:26:15 +0200 Greg Kroah-Hartman…
Wait, no, I did catch this! And I sent you a "FAILED" email about it, 4 of them:
https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected] https://lore.kernel.org/r/[email protected]as the commit applied, but broke the build:
Yes, I know, that's how I knew it was an issue ;-)
Quoted 2 lines
But I didn't drop the offending commit, I should have done that.
Correct.
Oh, so I guess it got in because it applied, but broke the build. Thus, your scripts catch when a Fixes does not apply, but doesn't handle the "broken build / boot" case?
Quoted 4 lines
I'll go and drop the offending commit here, if you could submit both of them as working backports to stable@vger if/when you want them queued up there, that would be great.
The patch that got backported only fixes an issue with new events (hence why I did not mark it for stable). If those events are not backported, there's no reason to backport this one.
-- Steve
Quoted 7 lines · Steven Rostedt
Quoted 3 lines · On Tue, 5 Apr 2022 23:08:12 -0400 Steven Rostedt <[email protected]> wrote:
Here's a thought, if you decide to backport a patch to stable, and you see that there's another commit with a "Fixes" tag to the automatically selected commit. DO NOT BACKPORT IF THE FIXES PATCH FAILS TO GO BACK TOO!
Quoted 6 lines
Seriously. This should be the case for *all* backported patches, not just the AUTOSEL ones.
Otherwise you are backporting a commit to "stable" that is KNOWN TO BE BROKEN!
Agreed.
Guenter
Quoted 5 lines · Steven Rostedt
Quoted 2 lines · On Tue, 5 Apr 2022 19:30:25 -0700 Guenter Roeck <[email protected]> wrote:
Quoted 1 line
s390 tests crashed. Other failed qemu tests did not compile.
Quoted 8 lines
Quoted 3 lines
Bisect points to commit
93fe2389e6fd("tracing: HaveTRACE_DEFINE_ENUMaffect trace event types as well"). Bisect log attached. Reverting the offending patch fixes the problem. Copying Steven for comments/input.Do you have this commit?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=795301d3c2899
No, It applies, but doesn't compile.
kernel/trace/trace_events.c: In function 'update_event_fields':kernel/trace/trace_events.c:2459:40: error: 'TRACE_EVENT_FL_DYNAMIC' undeclared
TRACE_EVENT_FL_DYNAMIC is not defined in v5.10.y.
Guenter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 07 Apr 2022 07:01:33 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.110-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
75 tests: 75 pass, 0 failLinux version: 5.10.110-rc1-g45fdcc9dc72a
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04Jon
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 07 Apr 2022 07:01:33 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.110-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
5.10.110-rc1 Successfully Compiled and booted on my Raspberry PI 4b (8g) (bcm2711)
Hi Greg,
Quoted 7 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 07 Apr 2022 07:01:33 +0000. Anything received after that time might be too late.
Build test:
mips (gcc version 11.2.1 20220314): 63 configs -> no failure arm (gcc version 11.2.1 20220314): 105 configs -> no new failure arm64 (gcc version 11.2.1 20220314): 3 configs -> no failure x86_64 (gcc version 11.2.1 20220314): 4 configs -> no failure
Boot test:x86_64: fails to boot on my test laptop. Detailed report at: https://lore.kernel.org/stable/Yky7RmYZnPp9HgzT@debian/x86_64: Booted on qemu. No regression. [1]
arm64: Booted on rpi4b (4GB model). No regression. [2]
[1]. https://openqa.qa.codethink.co.uk/tests/978
[2]. https://openqa.qa.codethink.co.uk/tests/981
--
Regards
Sudip
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 07 Apr 2022 07:01:33 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.110-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
## Build
* kernel: 5.10.110-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git branch: linux-5.10.y
* git commit: 45fdcc9dc72a44448666a2bcff4030a659e29e46
* git describe: v5.10.109-600-g45fdcc9dc72a
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.109-600-g45fdcc9dc72a
## Test Regressions (compared to v5.10.109-23-g09422778fc8c) No test regressions found.
## Metric Regressions (compared to v5.10.109-23-g09422778fc8c) No metric regressions found.
## Test Fixes (compared to v5.10.109-23-g09422778fc8c) No test fixes found.
## Metric Fixes (compared to v5.10.109-23-g09422778fc8c) No metric fixes found.
## Test result summary
total: 100719, pass: 84805, fail: 965, skip: 14009, xfail: 940
## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 291 total, 291 passed, 0 failed
* arm64: 41 total, 41 passed, 0 failed
* dragonboard-410c: 1 total, 1 passed, 0 failed
* hi6220-hikey: 1 total, 1 passed, 0 failed
* i386: 40 total, 40 passed, 0 failed
* juno-r2: 1 total, 1 passed, 0 failed
* mips: 37 total, 37 passed, 0 failed
* parisc: 12 total, 12 passed, 0 failed
* powerpc: 60 total, 51 passed, 9 failed
* riscv: 27 total, 27 passed, 0 failed
* s390: 21 total, 21 passed, 0 failed
* sh: 24 total, 24 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x15: 1 total, 1 passed, 0 failed
* x86: 1 total, 1 passed, 0 failed
* x86_64: 41 total, 41 passed, 0 failed
## Test suites summary
* fwts
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-bpf
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* perf
* perf/Zstd-perf.data-compression
* rcutorture
* ssuite
* v4l2-compliance
* vdso
--
Linaro LKFT
https://lkft.linaro.org
Quoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Successfully cross-compiled for arm64 (bcm2711_defconfig, gcc 10.2.0) and powerpc (ps3_defconfig, gcc 11.2.0).
Signature · 1 line
An old man doll... just what I always wanted! - Clara
Quoted 5 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.110 release. There are 599 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Successfully cross-compiled for arm64 (bcm2711_defconfig, gcc 10.2.0) and powerpc (ps3_defconfig, gcc 11.2.0).
Signature · 1 line
An old man doll... just what I always wanted! - Clara