Skip to contentSkip to conversation

soc/tegra: pmc: update Tegra234 reset sources

PATCH In review Sandipan Patra 3 participants 3 messages Apr 1, 2022 – Apr 6, 2022 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 soc/tegra: pmc: update Tegra234 reset sources

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

---
Update on V3 patch:
Added more frequent comments to specify every 8 offsets
Update on V2 patch:
space inside comment and
Changed decimal to hexadecimal notation in the comments.

 drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)
drivers/soc/tegra/pmc.c +25 -8
index fdf508e03400..c01db5309b5e 100644
@@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
 };
 
 static const char * const tegra234_reset_sources[] = {
-	"SYS_RESET_N",
+	"SYS_RESET_N",	/* 0x0 */
 	"AOWDT",
 	"BCCPLEXWDT",
 	"BPMPWDT",
@@ -3774,19 +3774,36 @@ static const char * const tegra234_reset_sources[] = {
 	"SPEWDT",
 	"APEWDT",
 	"LCCPLEXWDT",
-	"SENSOR",
-	"AOTAG",
-	"VFSENSOR",
+	"SENSOR",	/* 0x8 */
+	NULL,
+	NULL,
 	"MAINSWRST",
 	"SC7",
 	"HSM",
-	"CSITE",
+	NULL,
 	"RCEWDT",
-	"PVA0WDT",
-	"PVA1WDT",
-	"L1A_ASYNC",
+	NULL,		/* 0x10 */
+	NULL,
+	NULL,
 	"BPMPBOOT",
 	"FUSECRC",
+	"DCEWDT",
+	"PSCWDT",
+	"PSC",
+	"CSITE_SW",	/* 0x18 */
+	"POD",
+	"SCPM",
+	"VREFRO_POWERBAD",
+	"VMON",
+	"FMON",
+	"FSI_R5WDT",
+	"FSI_THERM",
+	"FSI_R52C0WDT",	/* 0x20 */
+	"FSI_R52C1WDT",
+	"FSI_R52C2WDT",
+	"FSI_R52C3WDT",
+	"FSI_FMON",
+	"FSI_VMON",	/* 0x25 */
 };
 
 static const struct tegra_wake_event tegra234_wake_events[] = {
Signature · 1 line
2.17.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 2 lines · Sandipan Patra

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

This LGTM, but I am not a maintainer.
So, if it helps and FWIW,

Quoted 71 lines

---
Update on V3 patch:
Added more frequent comments to specify every 8 offsets
Update on V2 patch:
space inside comment and
Changed decimal to hexadecimal notation in the comments.

 drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)
drivers/soc/tegra/pmc.c +25 -8
index fdf508e03400..c01db5309b5e 100644
@@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
 };
 
 static const char * const tegra234_reset_sources[] = {
-	"SYS_RESET_N",
+	"SYS_RESET_N",	/* 0x0 */
 	"AOWDT",
 	"BCCPLEXWDT",
 	"BPMPWDT",
@@ -3774,19 +3774,36 @@ static const char * const tegra234_reset_sources[] = {
 	"SPEWDT",
 	"APEWDT",
 	"LCCPLEXWDT",
-	"SENSOR",
-	"AOTAG",
-	"VFSENSOR",
+	"SENSOR",	/* 0x8 */
+	NULL,
+	NULL,
 	"MAINSWRST",
 	"SC7",
 	"HSM",
-	"CSITE",
+	NULL,
 	"RCEWDT",
-	"PVA0WDT",
-	"PVA1WDT",
-	"L1A_ASYNC",
+	NULL,		/* 0x10 */
+	NULL,
+	NULL,
 	"BPMPBOOT",
 	"FUSECRC",
+	"DCEWDT",
+	"PSCWDT",
+	"PSC",
+	"CSITE_SW",	/* 0x18 */
+	"POD",
+	"SCPM",
+	"VREFRO_POWERBAD",
+	"VMON",
+	"FMON",
+	"FSI_R5WDT",
+	"FSI_THERM",
+	"FSI_R52C0WDT",	/* 0x20 */
+	"FSI_R52C1WDT",
+	"FSI_R52C2WDT",
+	"FSI_R52C3WDT",
+	"FSI_FMON",
+	"FSI_VMON",	/* 0x25 */
 };
 
 static const struct tegra_wake_event tegra234_wake_events[] = {
Signature · 1 line
2.17.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
In reply to Sandipan Patra
Quoted 11 lines · Sandipan Patra

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

---
Update on V3 patch:
Added more frequent comments to specify every 8 offsets
Update on V2 patch:
space inside comment and
Changed decimal to hexadecimal notation in the comments.

Quoted 2 lines
 drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

Applied with a slightly reworded commit message.

Thanks,
Thierry