modpost: restore the warning message for missing symbol versions
PATCH 1/1 modpost: restore the warning message for missing symbol versions
This log message was accidentally chopped off.
I was wondering why this happened, but checking the ML log, Mark precisely followed my suggestion [1].
I just used "..." because I was too lazy to type the sentence fully. Sorry for the confusion.
[1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/
---
scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mod/modpost.c +1 -1
@@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod,unsigned int crc;if (sym->st_shndx ==SHN_UNDEF ) { -warn ("EXPORT symbol \"%s\" [%s%s] version ...\n" +warn ("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n" , symname, mod->name, mod->is_vmlinux ?"" :".ko" , symname);
Signature · 1 line
2.32.0
Quoted 1 line · Masahiro Yamada
This log message was accidentally chopped off.
Quoted 6 lines · Masahiro Yamada
This log message was accidentally chopped off.
I was wondering why this happened, but checking the ML log, Mark precisely followed my suggestion [1].
Quoted 8 lines
I just used "..." because I was too lazy to type the sentence fully. Sorry for the confusion.
[1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/
Fixes 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols")Cc Mark Brown <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>
Quoted 21 lines
---
scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/mod/modpost.c +1
-2@@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod,unsigned int crc;if (sym->st_shndx ==SHN_UNDEF ) { -warn ("EXPORT symbol \"%s\" [%s%s] version ...\n" +warn ("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n" , symname, mod->name, mod->is_vmlinux ?"" :".ko" , symname); --2.32.0
Signature · 2 lines
Thanks, ~Nick Desaulniers