drm: mxsfb: Obtain bus flags from bridge state
Subsystems (4)
Marek Vasut
maintainerPATCH v2 1/1 drm: mxsfb: Obtain bus flags from bridge state
In case the MXSFB is connected to a bridge, attempt to obtain bus flags from that bridge state too. The bus flags may specify e.g. the DE signal polarity.
Acked-by Alexander Stein <[email protected]>
Signed-off-by Marek Vasut <[email protected]>
Cc Alexander Stein <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Lucas Stach <[email protected]>
Cc Peng Fan <[email protected]>
Cc Robby Cai <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Stefan Agner <[email protected]>
---
V2: Add AB from Alexander
--- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/mxsfb/mxsfb_kms.c +5 -2
@@ -275,6 +275,7 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb) }static void mxsfb_crtc_mode_set_nofb (struct mxsfb_drm_private *mxsfb, +struct drm_bridge_state *bridge_state,const u32 bus_format) {struct drm_device *drm = mxsfb->crtc.dev;
@@ -284,6 +285,8 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb,if (mxsfb->bridge && mxsfb->bridge->timings) bus_flags = mxsfb->bridge->timings->input_bus_flags; +else if (bridge_state) + bus_flags = bridge_state->input_bus_cfg.flags; DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m->crtc_clock,
@@ -345,7 +348,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,struct mxsfb_drm_private *mxsfb =to_mxsfb_drm_private (crtc->dev);struct drm_plane_state *new_pstate =drm_atomic_get_new_plane_state (state, crtc->primary); -struct drm_bridge_state *bridge_state; +struct drm_bridge_state *bridge_state =NULL ;struct drm_device *drm = mxsfb->drm;u32 bus_format =0 ;dma_addr_t paddr;
@@ -381,7 +384,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,if (!bus_format) bus_format =MEDIA_BUS_FMT_RGB888_1X24 ; -mxsfb_crtc_mode_set_nofb (mxsfb, bus_format); +mxsfb_crtc_mode_set_nofb (mxsfb, bridge_state, bus_format);/* Write cur_buf as well to avoid an initial corrupt frame */ paddr =drm_fb_cma_get_gem_addr (new_pstate->fb, new_pstate,0 );
Signature · 1 line
2.35.1
Am Sonntag, dem 17.04.2022 um 04:10 +0200 schrieb Marek Vasut:
Quoted 4 lines
In case the MXSFB is connected to a bridge, attempt to obtain bus flags from that bridge state too. The bus flags may specify e.g. the DE signal polarity.
Quoted 9 lines
Acked-by Alexander Stein <[email protected]>Signed-off-by Marek Vasut <[email protected]>Cc Alexander Stein <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Lucas Stach <[email protected]>Cc Peng Fan <[email protected]>Cc Robby Cai <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Stefan Agner <[email protected]>
Reviewed-by Lucas Stach <[email protected]>
Quoted 45 lines
---
V2: Add AB from Alexander--- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/mxsfb/mxsfb_kms.c +5
-2@@ -275,6 +275,7 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb) }static void mxsfb_crtc_mode_set_nofb (struct mxsfb_drm_private *mxsfb, +struct drm_bridge_state *bridge_state,const u32 bus_format) {struct drm_device *drm = mxsfb->crtc.dev;@@ -284,6 +285,8 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb,if (mxsfb->bridge && mxsfb->bridge->timings) bus_flags = mxsfb->bridge->timings->input_bus_flags; +else if (bridge_state) + bus_flags = bridge_state->input_bus_cfg.flags; DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m->crtc_clock,@@ -345,7 +348,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,struct mxsfb_drm_private *mxsfb =to_mxsfb_drm_private (crtc->dev);struct drm_plane_state *new_pstate =drm_atomic_get_new_plane_state (state, crtc->primary); -struct drm_bridge_state *bridge_state; +struct drm_bridge_state *bridge_state =NULL ;struct drm_device *drm = mxsfb->drm;u32 bus_format =0 ;dma_addr_t paddr;@@ -381,7 +384,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,if (!bus_format) bus_format =MEDIA_BUS_FMT_RGB888_1X24 ; -mxsfb_crtc_mode_set_nofb (mxsfb, bus_format); +mxsfb_crtc_mode_set_nofb (mxsfb, bridge_state, bus_format);/* Write cur_buf as well to avoid an initial corrupt frame */ paddr =drm_fb_cma_get_gem_addr (new_pstate->fb, new_pstate,0 );
Hi Marek,
Thank you for the patch.
Quoted 4 lines · Marek Vasut
In case the MXSFB is connected to a bridge, attempt to obtain bus flags from that bridge state too. The bus flags may specify e.g. the DE signal polarity.
Quoted 9 lines
Acked-by Alexander Stein <[email protected]>Signed-off-by Marek Vasut <[email protected]>Cc Alexander Stein <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Lucas Stach <[email protected]>Cc Peng Fan <[email protected]>Cc Robby Cai <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Stefan Agner <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 45 lines
---
V2: Add AB from Alexander--- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/mxsfb/mxsfb_kms.c +5
-2@@ -275,6 +275,7 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb) }static void mxsfb_crtc_mode_set_nofb (struct mxsfb_drm_private *mxsfb, +struct drm_bridge_state *bridge_state,const u32 bus_format) {struct drm_device *drm = mxsfb->crtc.dev;@@ -284,6 +285,8 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb,if (mxsfb->bridge && mxsfb->bridge->timings) bus_flags = mxsfb->bridge->timings->input_bus_flags; +else if (bridge_state) + bus_flags = bridge_state->input_bus_cfg.flags; DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m->crtc_clock,@@ -345,7 +348,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,struct mxsfb_drm_private *mxsfb =to_mxsfb_drm_private (crtc->dev);struct drm_plane_state *new_pstate =drm_atomic_get_new_plane_state (state, crtc->primary); -struct drm_bridge_state *bridge_state; +struct drm_bridge_state *bridge_state =NULL ;struct drm_device *drm = mxsfb->drm;u32 bus_format =0 ;dma_addr_t paddr;@@ -381,7 +384,7 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,if (!bus_format) bus_format =MEDIA_BUS_FMT_RGB888_1X24 ; -mxsfb_crtc_mode_set_nofb (mxsfb, bus_format); +mxsfb_crtc_mode_set_nofb (mxsfb, bridge_state, bus_format);/* Write cur_buf as well to avoid an initial corrupt frame */ paddr =drm_fb_cma_get_gem_addr (new_pstate->fb, new_pstate,0 );
Signature · 3 lines
Regards, Laurent Pinchart