Skip to contentSkip to conversation

dt-bindings: rcc: Add common clock properties

PATCH In review Marek Vasut 2 participants 3 messages Apr 8, 2022 – Apr 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: rcc: Add common clock properties

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Cc Alexandre Torgue <[email protected]>
Cc Gabriel Fernandez <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]

---
V2: Add AB from Gabriel

---
 .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +6 -0
index a0ae4867ed27e..9bcf198bae170 100644
@@ -62,6 +62,12 @@ properties:
   reg:
     maxItems: 1
 
+  clocks: true
+  clock-names: true
+  assigned-clocks: true
+  assigned-clock-parents: true
+  assigned-clock-rates: true
+
 required:
   - "#clock-cells"
   - "#reset-cells"
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 22 lines · Marek Vasut

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Cc Alexandre Torgue <[email protected]>
Cc Gabriel Fernandez <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]

---
V2: Add AB from Gabriel

---
 .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +0 -0
index a0ae4867ed27e..9bcf198bae170 100644

Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml properties: · line 65

Quoted 4 lines
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +1 -0
@@ -62,6 +62,12 @@ properties:
   reg:
     maxItems: 1
 
+  clocks: true

How many and what are they?

Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml properties: · line 66

Quoted 1 line
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +1 -0
+  clock-names: true

Needs exact names.

Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml properties: · line 69

Quoted 3 lines
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +3 -0
+  assigned-clocks: true
+  assigned-clock-parents: true
+  assigned-clock-rates: true

These are automatically added when 'clocks' is present.

Quoted 8 lines
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +1 -0
+
 required:
   - "#clock-cells"
   - "#reset-cells"
Signature · 1 line
2.35.1
#2 lore raw
Quoted 26 lines · Rob Herring
Quoted 25 lines · Marek Vasut

Add common properties appearing in DTSes (assigned-clocks and similar) to fix dtbs_check warnings like:

arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Cc Alexandre Torgue <[email protected]>
Cc Gabriel Fernandez <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]

---
V2: Add AB from Gabriel

---
  .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml          | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +0 -0
index a0ae4867ed27e..9bcf198bae170 100644
@@ -62,6 +62,12 @@ properties:
    reg:
      maxItems: 1
 
Quoted 3 lines

Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml properties: · line 65

Quoted 1 line
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +1 -0
+  clocks: true

How many and what are they?

0 or 1

Quoted 3 lines

Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml properties: · line 66

Quoted 1 line
Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +1 -0
+  clock-names: true

Needs exact names.

I'll send V3 soon.