Skip to contentSkip to conversation

usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

PATCH In review Surong Pang 2 participants 4 messages Apr 12, 2022 – Apr 22, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

From: Surong Pang <[email protected]>

To set xhci->quirks value according to "usb3-slow-suspend" property

---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/xhci-plat.c +3 -0
index 649ffd861b44..6bc456bc6468 100644
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
 			xhci->quirks |= XHCI_LPM_SUPPORT;
 
+		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+			xhci->quirks |= XHCI_SLOW_SUSPEND;
+
 		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
 			xhci->quirks |= XHCI_BROKEN_PORT_PED;
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · Surong Pang

From: Surong Pang <[email protected]>

To set xhci->quirks value according to "usb3-slow-suspend" property

---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/xhci-plat.c +0 -0
index 649ffd861b44..6bc456bc6468 100644

drivers/usb/host/xhci-plat.c static int xhci_plat_probe(struct platform_device *pdev) · line 306

Quoted 5 lines
drivers/usb/host/xhci-plat.c +2 -0
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
 			xhci->quirks |= XHCI_LPM_SUPPORT;
 
+		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+			xhci->quirks |= XHCI_SLOW_SUSPEND;

Where is that property documented?

maintainer
#2 lore raw
In reply to Surong Pang
Quoted 14 lines · Surong Pang

From: Surong Pang <[email protected]>

To set xhci->quirks value according to "usb3-slow-suspend" property

---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/xhci-plat.c +0 -0
index 649ffd861b44..6bc456bc6468 100644

drivers/usb/host/xhci-plat.c static int xhci_plat_probe(struct platform_device *pdev) · line 306

Quoted 5 lines
drivers/usb/host/xhci-plat.c +2 -0
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
 			xhci->quirks |= XHCI_LPM_SUPPORT;
 
+		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+			xhci->quirks |= XHCI_SLOW_SUSPEND;

Device properties need to be documented somewhere.

#3 lore raw

We need to abandon this patch.

Quoted 24 lines · Greg KH <[email protected]> 于2022年4月22日周五 00:41写道:
Quoted 14 lines · Surong Pang

From: Surong Pang <[email protected]>

To set xhci->quirks value according to "usb3-slow-suspend" property

---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/xhci-plat.c +0 -0
index 649ffd861b44..6bc456bc6468 100644

drivers/usb/host/xhci-plat.c static int xhci_plat_probe(struct platform_device *pdev) · line 306

Quoted 5 lines
drivers/usb/host/xhci-plat.c +2 -0
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
              if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
                      xhci->quirks |= XHCI_LPM_SUPPORT;
 
+             if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+                     xhci->quirks |= XHCI_SLOW_SUSPEND;

Device properties need to be documented somewhere.