staging: Remove the drivers for the Unisys s-Par
PATCH v2 1/1 staging: Remove the drivers for the Unisys s-Par
The Unisys sub-tree contains three drivers for the "Unisys Secure Partition" (s-Par(R)): visorhba, visorinput, visornic.
They have no maintainers, in fact the only one that is listed in MAINTAINERS has an unreacheable email address. During 2021 and 2022 several patches have been submitted to these drivers but nobody at Unisys cared of reviewing the changes. Probably, also the "sparmaintainer" internal list of unisys.com is not anymore read by interested Unisys' engineers.
Therefore, remove the ./unisys subdirectory and delete the relevant entries in the MAINTAINERS, Kconfig, Makefile files.
---
v1->v2: Add two "Cc:" lines, one to David Kershner and the second to the "sparmaintainer" list at unisys.com, as requested by Greg Kroah-Hartman.
MAINTAINERS | 8 - drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - .../ABI/sysfs-platform-visorchipset | 89 - .../staging/unisys/Documentation/overview.txt | 337 --- drivers/staging/unisys/Kconfig | 16 - drivers/staging/unisys/MAINTAINERS | 5 - drivers/staging/unisys/Makefile | 7 - drivers/staging/unisys/TODO | 16 - drivers/staging/unisys/include/iochannel.h | 571 ----- drivers/staging/unisys/visorhba/Kconfig | 15 - drivers/staging/unisys/visorhba/Makefile | 10 - .../staging/unisys/visorhba/visorhba_main.c | 1142 --------- drivers/staging/unisys/visorinput/Kconfig | 16 - drivers/staging/unisys/visorinput/Makefile | 7 - .../staging/unisys/visorinput/visorinput.c | 788 ------ drivers/staging/unisys/visornic/Kconfig | 16 - drivers/staging/unisys/visornic/Makefile | 10 - .../staging/unisys/visornic/visornic_main.c | 2131 ----------------- 19 files changed, 5187 deletions(-) delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset delete mode 100644 drivers/staging/unisys/Documentation/overview.txt delete mode 100644 drivers/staging/unisys/Kconfig delete mode 100644 drivers/staging/unisys/MAINTAINERS delete mode 100644 drivers/staging/unisys/Makefile delete mode 100644 drivers/staging/unisys/TODO delete mode 100644 drivers/staging/unisys/include/iochannel.h delete mode 100644 drivers/staging/unisys/visorhba/Kconfig delete mode 100644 drivers/staging/unisys/visorhba/Makefile delete mode 100644 drivers/staging/unisys/visorhba/visorhba_main.c delete mode 100644 drivers/staging/unisys/visorinput/Kconfig delete mode 100644 drivers/staging/unisys/visorinput/Makefile delete mode 100644 drivers/staging/unisys/visorinput/visorinput.c delete mode 100644 drivers/staging/unisys/visornic/Kconfig delete mode 100644 drivers/staging/unisys/visornic/Makefile delete mode 100644 drivers/staging/unisys/visornic/visornic_main.c
MAINTAINERS +0 -8
@@ -20183,14 +20183,6 @@ F: drivers/cdrom/cdrom.c F: include/linux/cdrom.h F: include/uapi/linux/cdrom.h -UNISYS S-PAR DRIVERS -M: David Kershner <[email protected]> -L: [email protected] (Unisys internal) -S: Supported -F: drivers/staging/unisys/ -F: drivers/visorbus/ -F: include/linux/visorbus.h - UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER R: Alim Akhtar <[email protected]> R: Avri Altman <[email protected]>
drivers/staging/Kconfig +0 -2
@@ -64,8 +64,6 @@ source "drivers/staging/gdm724x/Kconfig" source "drivers/staging/fwserial/Kconfig" -source "drivers/staging/unisys/Kconfig" - source "drivers/staging/clocking-wizard/Kconfig" source "drivers/staging/fbtft/Kconfig"
drivers/staging/Makefile +0 -1
@@ -22,7 +22,6 @@ obj-$(CONFIG_MFD_NVEC) += nvec/ obj-$(CONFIG_STAGING_BOARD) += board/ obj-$(CONFIG_LTE_GDM724X) += gdm724x/ obj-$(CONFIG_FIREWIRE_SERIAL) += fwserial/ -obj-$(CONFIG_UNISYSSPAR) += unisys/ obj-$(CONFIG_COMMON_CLK_XLNX_CLKWZRD) += clocking-wizard/ obj-$(CONFIG_FB_TFT) += fbtft/ obj-$(CONFIG_MOST) += most/
drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset deleted +0 -89
89 lines not on this page · raw message
drivers/staging/unisys/Documentation/overview.txt deleted +0 -337
337 lines not on this page · raw message
drivers/staging/unisys/Kconfig deleted +0 -16
@@ -1,16 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Unisys SPAR driver configuration -# -menuconfig UNISYSSPAR - bool "Unisys SPAR driver support" - help - Support for the Unisys SPAR drivers - -if UNISYSSPAR - -source "drivers/staging/unisys/visornic/Kconfig" -source "drivers/staging/unisys/visorinput/Kconfig" -source "drivers/staging/unisys/visorhba/Kconfig" - -endif # UNISYSSPAR
drivers/staging/unisys/MAINTAINERS deleted +0 -5
@@ -1,5 +0,0 @@ -Unisys s-Par drivers -M: David Kershner <[email protected]> -S: Maintained -F: drivers/staging/unisys/Documentation/overview.txt -F: drivers/staging/unisys/
drivers/staging/unisys/Makefile deleted +0 -7
@@ -1,7 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Makefile for Unisys SPAR drivers -# -obj-$(CONFIG_UNISYS_VISORNIC) += visornic/ -obj-$(CONFIG_UNISYS_VISORINPUT) += visorinput/ -obj-$(CONFIG_UNISYS_VISORHBA) += visorhba/
drivers/staging/unisys/TODO deleted +0 -16
@@ -1,16 +0,0 @@ -TODO: - - enhance visornic to use channel_interrupt() hook instead of a - kernel thread - - enhance visorhba to use channel_interrupt() hook instead of a - kernel thread - - teach visorbus to handle virtual interrupts triggered by s-Par - back-end, and call function driver's channel_interrupt() function - when they occur - - enhance debugfs interfaces (e.g., per device, etc.) - - upgrade/remove deprecated workqueue operations - - move individual drivers into proper driver subsystems - -Patches to: - Greg Kroah-Hartman <[email protected]> - Ken Cox <[email protected]> - Unisys s-Par maintainer mailing list <[email protected]>
drivers/staging/unisys/include/iochannel.h deleted +0 -571
571 lines not on this page · raw message
drivers/staging/unisys/visorhba/Kconfig deleted +0 -15
@@ -1,15 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Unisys visorhba configuration -# - -config UNISYS_VISORHBA - tristate "Unisys visorhba driver" - depends on UNISYSSPAR && UNISYS_VISORBUS && SCSI - help - The Unisys visorhba driver provides support for s-Par HBA - devices exposed on the s-Par visorbus. When a message is sent - to visorbus to create a HBA device, the probe function of - visorhba is called to create the scsi device. - If you say Y here, you will enable the Unisys visorhba driver. -
drivers/staging/unisys/visorhba/Makefile deleted +0 -10
@@ -1,10 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Makefile for Unisys channel -# - -obj-$(CONFIG_UNISYS_VISORHBA) += visorhba.o - -visorhba-y := visorhba_main.o - -ccflags-y += -I $(srctree)/$(src)/../include
drivers/staging/unisys/visorhba/visorhba_main.c deleted +0 -1142
1,142 lines not on this page · raw message
drivers/staging/unisys/visorinput/Kconfig deleted +0 -16
@@ -1,16 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Unisys visorinput configuration -# - -config UNISYS_VISORINPUT - tristate "Unisys visorinput driver" - depends on UNISYSSPAR && UNISYS_VISORBUS && INPUT - help - The Unisys s-Par visorinput driver provides a virtualized system - console (keyboard and mouse) that is accessible through the - s-Par firmware's user interface. s-Par provides video using the EFI - GOP protocol, so If this driver is not present, the Linux guest should - still boot with visible output in the partition desktop, but keyboard - and mouse interaction will not be available. -
drivers/staging/unisys/visorinput/Makefile deleted +0 -7
@@ -1,7 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -# -# Makefile for Unisys visorinput -# - -obj-$(CONFIG_UNISYS_VISORINPUT) += visorinput.o -
drivers/staging/unisys/visorinput/visorinput.c deleted +0 -788
740 lines not on this page · raw message
drivers/staging/unisys/visornic/Kconfig deleted +0 -16
Lines of this file are not shown. View the raw message.
drivers/staging/unisys/visornic/Makefile deleted +0 -10
Lines of this file are not shown. View the raw message.
drivers/staging/unisys/visornic/visornic_main.c deleted +0 -2131
2,131 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.34.1
Part of the diff is not shown here. View the raw message.
Greg Kroah-Hartman
maintainerQuoted 66 lines · Fabio M. De Francesco
The Unisys sub-tree contains three drivers for the "Unisys Secure Partition" (s-Par(R)): visorhba, visorinput, visornic.
They have no maintainers, in fact the only one that is listed in
MAINTAINERShas an unreacheable email address. During 2021 and 2022 several patches have been submitted to these drivers but nobody at Unisys cared of reviewing the changes. Probably, also the "sparmaintainer" internal list of unisys.com is not anymore read by interested Unisys' engineers.Therefore, remove the ./unisys subdirectory and delete the relevant entries in the
MAINTAINERS,Kconfig,Makefilefiles.Cc David Kershner <[email protected]>Suggested-by Greg Kroah-Hartman <[email protected]>Signed-off-by Fabio M. De Francesco <[email protected]>---
v1->v2: Add two "Cc:" lines, one to David Kershner and the second to the "sparmaintainer" list at unisys.com, as requested by Greg Kroah-Hartman.MAINTAINERS | 8 - drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - .../ABI/sysfs-platform-visorchipset | 89 - .../staging/unisys/Documentation/overview.txt | 337 --- drivers/staging/unisys/Kconfig | 16 - drivers/staging/unisys/MAINTAINERS | 5 - drivers/staging/unisys/Makefile | 7 - drivers/staging/unisys/TODO | 16 - drivers/staging/unisys/include/iochannel.h | 571 ----- drivers/staging/unisys/visorhba/Kconfig | 15 - drivers/staging/unisys/visorhba/Makefile | 10 - .../staging/unisys/visorhba/visorhba_main.c | 1142 --------- drivers/staging/unisys/visorinput/Kconfig | 16 - drivers/staging/unisys/visorinput/Makefile | 7 - .../staging/unisys/visorinput/visorinput.c | 788 ------ drivers/staging/unisys/visornic/Kconfig | 16 - drivers/staging/unisys/visornic/Makefile | 10 - .../staging/unisys/visornic/visornic_main.c | 2131 -----------------19 files changed, 5187 deletions(-) delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset delete mode 100644 drivers/staging/unisys/Documentation/overview.txt delete mode 100644 drivers/staging/unisys/Kconfig delete mode 100644 drivers/staging/unisys/MAINTAINERS delete mode 100644 drivers/staging/unisys/Makefile delete mode 100644 drivers/staging/unisys/TODO delete mode 100644 drivers/staging/unisys/include/iochannel.h delete mode 100644 drivers/staging/unisys/visorhba/Kconfig delete mode 100644 drivers/staging/unisys/visorhba/Makefile delete mode 100644 drivers/staging/unisys/visorhba/visorhba_main.c delete mode 100644 drivers/staging/unisys/visorinput/Kconfig delete mode 100644 drivers/staging/unisys/visorinput/Makefile delete mode 100644 drivers/staging/unisys/visorinput/visorinput.c delete mode 100644 drivers/staging/unisys/visornic/Kconfig delete mode 100644 drivers/staging/unisys/visornic/Makefile delete mode 100644 drivers/staging/unisys/visornic/visornic_main.cMAINTAINERS +0
-0
MAINTAINERS F: drivers/cdrom/cdrom.c · line 20191
Quoted 9 lines
MAINTAINERS +0
-6@@ -20183,14 +20183,6 @@ F: drivers/cdrom/cdrom.c F: include/linux/cdrom.h F: include/uapi/linux/cdrom.h -UNISYS S-PAR DRIVERS -M: David Kershner <[email protected]> -L: [email protected] (Unisys internal) -S: Supported -F: drivers/staging/unisys/ -F: drivers/visorbus/
You forgot to delete the files in this directory as well :(
thanks,
greg k-h
Quoted 2 lines · On gioved? 14 aprile 2022 09:14:29 CEST Greg Kroah-Hartman wrote:
Quoted 1 line · Fabio M. De Francesco
The Unisys sub-tree contains three drivers for the "Unisys Secure
Partition"
Quoted 3 lines
Quoted 3 lines
(s-Par(R)): visorhba, visorinput, visornic.
They have no maintainers, in fact the only one that is listed in
MAINTAINERS
Quoted 1 line
Quoted 1 line
has an unreacheable email address. During 2021 and 2022 several patches
have
Quoted 1 line
Quoted 1 line
been submitted to these drivers but nobody at Unisys cared of reviewing
the
Quoted 1 line
Quoted 1 line
changes. Probably, also the "sparmaintainer" internal list of
unisys.com is
Quoted 3 lines
Quoted 3 lines
not anymore read by interested Unisys' engineers.
Therefore, remove the ./unisys subdirectory and delete the relevant
entries
Quoted 9 lines
Quoted 9 lines
in the
MAINTAINERS,Kconfig,Makefilefiles.Cc David Kershner <[email protected]>Suggested-by Greg Kroah-Hartman <[email protected]>Signed-off-by Fabio M. De Francesco <[email protected]>---
v1->v2: Add two "Cc:" lines, one to David Kershner and the second to
the
Quoted 1 line
Quoted 1 line
"sparmaintainer" list at unisys.com, as requested by Greg Kroah-
Hartman.
Quoted 23 lines
Quoted 20 lines
MAINTAINERS | 8 - drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - .../ABI/sysfs-platform-visorchipset | 89 - .../staging/unisys/Documentation/overview.txt | 337 --- drivers/staging/unisys/Kconfig | 16 - drivers/staging/unisys/MAINTAINERS | 5 - drivers/staging/unisys/Makefile | 7 - drivers/staging/unisys/TODO | 16 - drivers/staging/unisys/include/iochannel.h | 571 ----- drivers/staging/unisys/visorhba/Kconfig | 15 - drivers/staging/unisys/visorhba/Makefile | 10 - .../staging/unisys/visorhba/visorhba_main.c | 1142 --------- drivers/staging/unisys/visorinput/Kconfig | 16 - drivers/staging/unisys/visorinput/Makefile | 7 - .../staging/unisys/visorinput/visorinput.c | 788 ------ drivers/staging/unisys/visornic/Kconfig | 16 - drivers/staging/unisys/visornic/Makefile | 10 - .../staging/unisys/visornic/visornic_main.c | 2131 -----------------
Quoted 2 lines
Quoted 2 lines
19 files changed, 5187 deletions(-) delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-
platform-visorchipset
Quoted 24 lines
Quoted 24 lines
delete mode 100644 drivers/staging/unisys/Documentation/overview.txt delete mode 100644 drivers/staging/unisys/Kconfig delete mode 100644 drivers/staging/unisys/MAINTAINERS delete mode 100644 drivers/staging/unisys/Makefile delete mode 100644 drivers/staging/unisys/TODO delete mode 100644 drivers/staging/unisys/include/iochannel.h delete mode 100644 drivers/staging/unisys/visorhba/Kconfig delete mode 100644 drivers/staging/unisys/visorhba/Makefile delete mode 100644 drivers/staging/unisys/visorhba/visorhba_main.c delete mode 100644 drivers/staging/unisys/visorinput/Kconfig delete mode 100644 drivers/staging/unisys/visorinput/Makefile delete mode 100644 drivers/staging/unisys/visorinput/visorinput.c delete mode 100644 drivers/staging/unisys/visornic/Kconfig delete mode 100644 drivers/staging/unisys/visornic/Makefile delete mode 100644 drivers/staging/unisys/visornic/visornic_main.cMAINTAINERS +0
-0@@ -20183,14 +20183,6 @@ F: drivers/cdrom/cdrom.c F: include/linux/cdrom.h F: include/uapi/linux/cdrom.h
Quoted 9 lines
MAINTAINERS F: drivers/cdrom/cdrom.c · line 20191
Quoted 6 lines
MAINTAINERS +0
-6-UNISYS S-PAR DRIVERS -M: David Kershner <[email protected]> -L: [email protected] (Unisys internal) -S: Supported -F: drivers/staging/unisys/ -F: drivers/visorbus/You forgot to delete the files in this directory as well :(
Sorry, that's worse than just being forgetful. I did not carefully read the lines I deleted in MAINTAINERS :(
I will post a v3 soon. In the meantime, I'll also add between the lines "Cc:" that other person that Alison found in drivers/staging/unisys/TODO.
Thanks,
Fabio M. De Francesco