Skip to contentSkip to conversation

spi: initialize status to success

PATCH In review Tom Rix 3 participants 3 messages Apr 16, 2022 – Apr 17, 2022 SPI

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 spi: initialize status to success

Clang static analysis reports this issue
spi.c:3583:2: warning: 2nd function call argument
is an uninitialized value
trace_spi_setup(spi, status);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~

It is possible that status is never set because
its function level setting was removed by the
commit listed in the Fixes: tag.

Assume that setting 8 bits-per-word is ok and
initialize the status to 0.

Fixes b3fe2e516741 ("spi: core: Only check bits_per_word validity when explicitly provided")
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi.c +1 -1
index 563a56ce34a0..890ff46c784a 100644
@@ -3475,7 +3475,7 @@ static int __spi_validate_bits_per_word(struct spi_controller *ctlr,
 int spi_setup(struct spi_device *spi)
 {
 	unsigned	bad_bits, ugly_bits;
-	int		status;
+	int		status = 0;
 
 	/*
 	 * Check mode to prevent that any two of DUAL, QUAD and NO_MOSI/MISO
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Tom Rix

Clang static analysis reports this issue
spi.c:3583:2: warning: 2nd function call argument
is an uninitialized value
trace_spi_setup(spi, status);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~

It is possible that status is never set because
its function level setting was removed by the
commit listed in the Fixes: tag.

Quoted 5 lines

Assume that setting 8 bits-per-word is ok and
initialize the status to 0.

Fixes b3fe2e516741 ("spi: core: Only check bits_per_word validity when explicitly provided")

I am very surprised that -Wsometimes-uninitialized does not trigger here, as this instance does not require interprocedural analysis, right? status is not passed by reference as far as I can tell and it is only initialized in if statements now but it is unconditionally used at the end of the function. Maybe it does not matter too much, given that auto-initialization is turned on by default when supported.

Regardless, this fix looks fine. I do not really like initializing variables at the top of the function as it can hide error codes but it is always a maintainer preference anyways so:

Quoted 20 lines
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi.c +1 -1
index 563a56ce34a0..890ff46c784a 100644
@@ -3475,7 +3475,7 @@ static int __spi_validate_bits_per_word(struct spi_controller *ctlr,
 int spi_setup(struct spi_device *spi)
 {
 	unsigned	bad_bits, ugly_bits;
-	int		status;
+	int		status = 0;
 
 	/*
 	 * Check mode to prevent that any two of DUAL, QUAD and NO_MOSI/MISO
Signature · 1 line
2.27.0
maintainer
#2 lore raw
In reply to Tom Rix
Quoted 2 lines · Tom Rix

Clang static analysis reports this issue
spi.c:3583:2: warning: 2nd function call argument

The same patch was sent and applied several days ago? 73f93db5c49b9f52c902e5dc6c750bf9832e0450