Skip to contentSkip to conversation

imx-mipi-csis improvements

GIT PULL Laurent Pinchart 2 participants 3 messages Apr 21, 2022 – Apr 23, 2022 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17:

Linux 5.18-rc1 (2022-04-03 14:08:21 -0700)

are available in the Git repository at:

git://linuxtv.org/pinchartl/media.git tags/v4l2-next-20220422

for you to fetch changes up to 90fddde6077ae9644b6765c2f8817977317265eb:

media: imx: imx-mipi-csis: Fix active format initialization on source pad (2022-04-22 00:49:22 +0300)

----------------------------------------------------------------
imx-mipi-csis driver improvements

----------------------------------------------------------------
Jacopo Mondi (3):
media: imx: imx-mipi-csis: Simplify mipi_csis_s_stream()
media: imx: imx-mipi-csis: Drop powered flag
media: imx: imx-mipi-csis: Protect mipi_csis_dump_regs()

Laurent Pinchart (6):
media: imx: imx-mipi-csis: Rename csi_state to mipi_csis_device
media: imx: imx-mipi-csis: Don't use .s_power()
media: imx: imx-mipi-csis: Drop unneeded system PM implementation
media: imx: imx-mipi-csis: Don't stop streaming at runtime suspend time
media: imx: imx-mipi-csis: Simplify runtime PM implementation
media: imx: imx-mipi-csis: Fix active format initialization on source pad

 drivers/media/platform/nxp/imx-mipi-csis.c | 677 +++++++++++++----------------
 1 file changed, 313 insertions(+), 364 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Re: [GIT PULL FOR v5.19] imx-mipi-csis improvements (#82601)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/201535/
Build time: 00:19:10

gpg: Signature made Thu 21 Apr 2022 09:54:33 PM UTC
gpg:                using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
gpg:                issuer "[email protected]"
gpg: Can't check signature: No public key

Summary: got 2/9 patches with issues, being 1 at build time

Error/warnings:

patches/0001-media-imx-imx-mipi-csis-Rename-csi_state-to-mipi_csi.patch:

allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr] ../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr] ../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

allyesconfig: return code #0:
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654) SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures ../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds ../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

checkpatch.pl:

	$ cat patches/0001-media-imx-imx-mipi-csis-Rename-csi_state-to-mipi_csi.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:279: CHECK: Alignment should match open parenthesis

patches/0009-media-imx-imx-mipi-csis-Fix-active-format-initializa.patch:

checkpatch.pl:

	$ cat patches/0009-media-imx-imx-mipi-csis-Fix-active-format-initializa.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:6: WARNING: Unknown commit id '52f69bc5f8c0', maybe rebased or not pulled?
	-:10: WARNING: Unknown commit id '52f69bc5f8c0', maybe rebased or not pulled?
#2 lore raw

Re: [GIT PULL FOR v5.19] imx-mipi-csis improvements (#82601)

Quoted 35 lines · Jenkins

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/201535/
Build time: 00:19:10

gpg: Signature made Thu 21 Apr 2022 09:54:33 PM UTC
gpg:                using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
gpg:                issuer "[email protected]"
gpg: Can't check signature: No public key

Summary: got 2/9 patches with issues, being 1 at build time

Error/warnings:

patches/0001-media-imx-imx-mipi-csis-Rename-csi_state-to-mipi_csi.patch:

allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr] ../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr] ../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

allyesconfig: return code #0:
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654) SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures ../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds ../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2868 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

checkpatch.pl:

	$ cat patches/0001-media-imx-imx-mipi-csis-Rename-csi_state-to-mipi_csi.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:279: CHECK: Alignment should match open parenthesis
Quoted 6 lines

patches/0009-media-imx-imx-mipi-csis-Fix-active-format-initializa.patch:

checkpatch.pl:

	$ cat patches/0009-media-imx-imx-mipi-csis-Fix-active-format-initializa.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:6: WARNING: Unknown commit id '52f69bc5f8c0', maybe rebased or not pulled?
	-:10: WARNING: Unknown commit id '52f69bc5f8c0', maybe rebased or not pulled?

I'll fix those and send a new pull request.

Signature · 3 lines
Regards,

Laurent Pinchart