Skip to contentSkip to conversation

workqueue: Restrict kworker in the offline CPU pool running on housekeeping CPUs

PATCH Applied Zqiang 2 participants 2 messages Mar 31, 2022 – Apr 21, 2022 Workqueue

lore
Share & tools
lore

Zqiang

author
#0 lore raw

PATCH v2 1/1 workqueue: Restrict kworker in the offline CPU pool running on housekeeping CPUs

When CPU going offline, all workers in this CPU pool will lose affinity to this CPU, and may run to isolated CPU. like kworker in unbound pool, set CPU affinity of these kworker is wq_unbound_cpumask.

---
v1->v2:
Replace housekeeping_cpumask(HK_TYPE_WQ) with wq_unbound_cpumask.

 kernel/workqueue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/workqueue.c +1 -1
index abcc9a2ac319..b447012df177 100644
@@ -5023,7 +5023,7 @@ static void unbind_workers(int cpu)
 
 		for_each_pool_worker(worker, pool) {
 			kthread_set_per_cpu(worker->task, -1);
-			WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, cpu_possible_mask) < 0);
+			WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, wq_unbound_cpumask) < 0);
 		}
 
 		mutex_unlock(&wq_pool_attach_mutex);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Zqiang

When CPU going offline, all workers in this CPU pool will lose affinity to this CPU, and may run to isolated CPU. like kworker in unbound pool, set CPU affinity of these kworker is wq_unbound_cpumask.

Applied to wq/for-5.18-fixes w/ patch description updated for clarity.

Thanks.

Signature · 1 line
tejun