Skip to contentSkip to conversation

rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

PATCH In review Kevin Lo 3 participants 3 messages Apr 22, 2022 – Apr 27, 2022 Realtek wireless driver (rtw88)

lore
Share & tools
lore

Kevin Lo

author
#0 lore raw

PATCH 1/1 rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.

---

drivers/net/wireless/realtek/rtw88/mac.c +1 -1
index d1678aed9d9c..caf2603da2d6 100644
@@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
 
 	switch (rtw_hci_type(rtwdev)) {
 	case RTW_HCI_TYPE_PCIE:
-		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
+		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
 		break;
 	case RTW_HCI_TYPE_USB:
 		break;
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Kevin Lo

Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.

Quoted 15 lines

---

drivers/net/wireless/realtek/rtw88/mac.c +1 -2
index d1678aed9d9c..caf2603da2d6 100644
@@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
 
 	switch (rtw_hci_type(rtwdev)) {
 	case RTW_HCI_TYPE_PCIE:
-		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
+		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
 		break;
 	case RTW_HCI_TYPE_USB:
 		break;
------Please consider the environment before printing this e-mail.
#2 lore raw
In reply to Kevin Lo
Quoted 11 lines · Kevin Lo

Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.

drivers/net/wireless/realtek/rtw88/mac.c +0 -0
index d1678aed9d9c..caf2603da2d6 100644

drivers/net/wireless/realtek/rtw88/mac.c static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev) · line 81

Quoted 8 lines
drivers/net/wireless/realtek/rtw88/mac.c +1 -1
@@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
 
 	switch (rtw_hci_type(rtwdev)) {
 	case RTW_HCI_TYPE_PCIE:
-		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
+		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
 		break;
 	case RTW_HCI_TYPE_USB:
 		break;

Patch applied to wireless-next.git, thanks.

fc6234d7e2e3 rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches