Skip to contentSkip to conversation

mtd_blkdevs: scan partitions on mtdblock if FIT_PARTITION is set

RFC PATCH In review Daniel Golle 3 participants 5 messages Apr 25, 2022 – Apr 26, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 4/5 mtd_blkdevs: scan partitions on mtdblock if FIT_PARTITION is set

Enable partition parsers on plain mtdblock devices in case of CONFIG_FIT_PARTITION being selected.

---
 drivers/mtd/mtd_blkdevs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/mtd_blkdevs.c +2 -0
index f7317211146550..e9759c4182f8d5 100644
@@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	} else {
 		snprintf(gd->disk_name, sizeof(gd->disk_name),
 			 "%s%d", tr->name, new->devnum);
+#ifndef CONFIG_FIT_PARTITION
 		gd->flags |= GENHD_FL_NO_PART;
+#endif
 	}
 
 	set_capacity(gd, ((u64)new->size * tr->blksize) >> 9);
Signature · 1 line
2.36.0
maintainer
#1 lore raw

Hi Daniel,

[email protected] wrote on Mon, 25 Apr 2022 16:00:02 +0100:

Quoted 13 lines

Enable partition parsers on plain mtdblock devices in case of CONFIG_FIT_PARTITION being selected.

---
 drivers/mtd/mtd_blkdevs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/mtd_blkdevs.c +0 -0
index f7317211146550..e9759c4182f8d5 100644

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 362

Quoted 4 lines
drivers/mtd/mtd_blkdevs.c +1 -0
@@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	} else {
 		snprintf(gd->disk_name, sizeof(gd->disk_name),
 			 "%s%d", tr->name, new->devnum);
+#ifndef CONFIG_FIT_PARTITION

Can we use a regular 'if' here?

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 367

Quoted 5 lines
drivers/mtd/mtd_blkdevs.c +1 -0
 		gd->flags |= GENHD_FL_NO_PART;
+#endif
 	}
 
 	set_capacity(gd, ((u64)new->size * tr->blksize) >> 9);

Thanks,
Miquèl

#2 lore raw
Quoted 12 lines · Miquel Raynal

Hi Daniel,

[email protected] wrote on Mon, 25 Apr 2022 16:00:02 +0100:

Quoted 8 lines

Enable partition parsers on plain mtdblock devices in case of CONFIG_FIT_PARTITION being selected.

---
 drivers/mtd/mtd_blkdevs.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 11 lines

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 362

Quoted 9 lines
drivers/mtd/mtd_blkdevs.c +1 -0
index f7317211146550..e9759c4182f8d5 100644
@@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	} else {
 		snprintf(gd->disk_name, sizeof(gd->disk_name),
 			 "%s%d", tr->name, new->devnum);
+#ifndef CONFIG_FIT_PARTITION

Can we use a regular 'if' here?

I'll introduce additional Kconfig options to enable scanning for (sub-)partitions on MTD block and UBI block devices as Christoph Hellwig correctly critizied that re-using this unrelated Kconfig option is misleading.

I'll also use
if (IS_ENABLED(...))
instead of
#ifdef ...
for better coverage testing.

Now going to wait a few more days for more comments and then re-send.

Thank you for the review!

Quoted 13 lines

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 367

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +1 -0
 		gd->flags |= GENHD_FL_NO_PART;
+#endif
 	}
 
 	set_capacity(gd, ((u64)new->size * tr->blksize) >> 9);

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#3 lore raw
In reply to Daniel Golle
Quoted 13 lines · Daniel Golle

Enable partition parsers on plain mtdblock devices in case of CONFIG_FIT_PARTITION being selected.

---
 drivers/mtd/mtd_blkdevs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/mtd_blkdevs.c +0 -0
index f7317211146550..e9759c4182f8d5 100644

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 364

Quoted 6 lines
drivers/mtd/mtd_blkdevs.c +2 -0
@@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	} else {
 		snprintf(gd->disk_name, sizeof(gd->disk_name),
 			 "%s%d", tr->name, new->devnum);
+#ifndef CONFIG_FIT_PARTITION
 		gd->flags |= GENHD_FL_NO_PART;
+#endif

This will just recreate the fixed regression, just with the extra twist of needіng a completely unrelted config option to trigger it.

#4 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 8 lines · Daniel Golle

Enable partition parsers on plain mtdblock devices in case of CONFIG_FIT_PARTITION being selected.

---
 drivers/mtd/mtd_blkdevs.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 14 lines

drivers/mtd/mtd_blkdevs.c int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) · line 364

Quoted 11 lines
drivers/mtd/mtd_blkdevs.c +2 -0
index f7317211146550..e9759c4182f8d5 100644
@@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	} else {
 		snprintf(gd->disk_name, sizeof(gd->disk_name),
 			 "%s%d", tr->name, new->devnum);
+#ifndef CONFIG_FIT_PARTITION
 		gd->flags |= GENHD_FL_NO_PART;
+#endif

This will just recreate the fixed regression, just with the extra twist of needіng a completely unrelted config option to trigger it.

Do have any alternative suggestion of how partition scanning could be (ideally selectively) enabled for mtdblock (and ubiblock) devices? And why it should be disabled in first place?