i2c: designware: Sort timing parameter ACPI method calls by the speed
Subsystems (3)
PATCH 1/1 i2c: designware: Sort timing parameter ACPI method calls by the speed
It's more logical to read these get timing parameters ACPI method calls sorted by speed categories in increasing order: Standard-mode, Fast-mode, Fast-mode Plus and High-speed mode.
Originally these were in order after commit a92ec1746f10 ("i2c: designware: get fast plus and high speed *CNT configuration") but got mixed up over the years.
--- drivers/i2c/busses/i2c-designware-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-designware-common.c +1 -1
@@ -266,9 +266,9 @@ int i2c_dw_acpi_configure(struct device *device)* selected speed modes. */ i2c_dw_acpi_params (device,"SSCN" , &dev->ss_hcnt, &dev->ss_lcnt, &ss_ht); +i2c_dw_acpi_params (device,"FMCN" , &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);i2c_dw_acpi_params (device,"FPCN" , &dev->fp_hcnt, &dev->fp_lcnt, &fp_ht);i2c_dw_acpi_params (device,"HSCN" , &dev->hs_hcnt, &dev->hs_lcnt, &hs_ht); -i2c_dw_acpi_params (device,"FMCN" , &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);switch (t->bus_freq_hz) {case I2C_MAX_STANDARD_MODE_FREQ :
Signature · 1 line
2.35.1
Quoted 7 lines · Jarkko Nikula
It's more logical to read these get timing parameters ACPI method calls sorted by speed categories in increasing order: Standard-mode, Fast-mode, Fast-mode Plus and High-speed mode.
Originally these were in order after commit
a92ec1746f10("i2c: designware: get fast plus and high speed *CNT configuration") but got mixed up over the years.
Quoted 23 lines
Signed-off-by Jarkko Nikula <[email protected]>--- drivers/i2c/busses/i2c-designware-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/busses/i2c-designware-common.c +1
-1@@ -266,9 +266,9 @@ int i2c_dw_acpi_configure(struct device *device)* selected speed modes. */ i2c_dw_acpi_params (device,"SSCN" , &dev->ss_hcnt, &dev->ss_lcnt, &ss_ht); +i2c_dw_acpi_params (device,"FMCN" , &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);i2c_dw_acpi_params (device,"FPCN" , &dev->fp_hcnt, &dev->fp_lcnt, &fp_ht);i2c_dw_acpi_params (device,"HSCN" , &dev->hs_hcnt, &dev->hs_lcnt, &hs_ht); -i2c_dw_acpi_params (device,"FMCN" , &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);switch (t->bus_freq_hz) {case I2C_MAX_STANDARD_MODE_FREQ :Signature · 1 line
2.35.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Wolfram Sang
AppliedQuoted 9 lines · Jarkko Nikula
It's more logical to read these get timing parameters ACPI method calls sorted by speed categories in increasing order: Standard-mode, Fast-mode, Fast-mode Plus and High-speed mode.
Originally these were in order after commit
a92ec1746f10("i2c: designware: get fast plus and high speed *CNT configuration") but got mixed up over the years.Signed-off-by Jarkko Nikula <[email protected]>
Applied to for-next, thanks!