Skip to contentSkip to conversation

dmaengine: ptdma: change pt_tx_status to static

PATCH In review Tom Rix 2 participants 2 messages Apr 23, 2022 – Apr 27, 2022 dmaengine

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 dmaengine: ptdma: change pt_tx_status to static

Sparse reports thise issue
ptdma-dmaengine.c:262:1: warning: symbol 'pt_tx_status' was not declared. Should it be static?

pt_tx_status, like other pt_* functions in ptdam-dmaengine.c, is assigned to a function pointer and is not used directly outside of this file. So change its storage-class specifier to static.

---
 drivers/dma/ptdma/ptdma-dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/ptdma/ptdma-dmaengine.c +1 -1
index ea07cc42f4d0..cc22d162ce25 100644
@@ -258,7 +258,7 @@ static void pt_issue_pending(struct dma_chan *dma_chan)
 		pt_cmd_callback(desc, 0);
 }
 
-enum dma_status
+static enum dma_status
 pt_tx_status(struct dma_chan *c, dma_cookie_t cookie,
 		struct dma_tx_state *txstate)
 {
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 6 lines · Tom Rix

Sparse reports thise issue
ptdma-dmaengine.c:262:1: warning: symbol 'pt_tx_status' was not declared. Should it be static?

pt_tx_status, like other pt_* functions in ptdam-dmaengine.c, is assigned to a function pointer and is not used directly outside of this file. So change its storage-class specifier to static.

Patch for this is already in next

Signature · 1 line
~Vinod