iommu: add null pointer check
PATCH 1/1 iommu: add null pointer check
From: Lv Ruyi <[email protected]>
kmem_cache_zalloc is a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid dereferencing null pointer.
Reported-by Zeal Robot <[email protected]>
Signed-off-by Lv Ruyi <[email protected]>
--- drivers/iommu/fsl_pamu_domain.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/iommu/fsl_pamu_domain.c +4 -0
@@ -152,6 +152,10 @@ static void attach_device(struct fsl_dma_domain *dma_domain, int liodn, struct d } info =kmem_cache_zalloc (iommu_devinfo_cache,GFP_ATOMIC ); +if (!info) { +spin_unlock_irqrestore (&device_domain_lock, flags); +return ; + } info->dev = dev; info->liodn = liodn;
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
maintainerQuoted 17 lines · On Tue, Mar 29, 2022 at 05:53:22AM +0000, [email protected] wrote:
From: Lv Ruyi <[email protected]>
kmem_cache_zallocis a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid dereferencing null pointer.Reported-by Zeal Robot <[email protected]>Signed-off-by Lv Ruyi <[email protected]>--- drivers/iommu/fsl_pamu_domain.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/iommu/fsl_pamu_domain.c +0
-0
drivers/iommu/fsl_pamu_domain.c static void attach_device(struct fsl_dma_domain *dma_domain, int liodn, struct d · line 158
Quoted 7 lines
drivers/iommu/fsl_pamu_domain.c +4
-0@@ -152,6 +152,10 @@ static void attach_device(struct fsl_dma_domain *dma_domain, int liodn, struct d } info =kmem_cache_zalloc (iommu_devinfo_cache,GFP_ATOMIC ); +if (!info) { +spin_unlock_irqrestore (&device_domain_lock, flags); +return ; + }
Such errors need to be propagated.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu