Skip to contentSkip to conversation

rpmsg: qcom_smd: fix error code if irq_of_parse_and_map()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpmsg: qcom_smd: fix error code if irq_of_parse_and_map()

The irq_of_parse_and_map() returns zero on failure but we want to return a negative error code.

Fixes 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
---
 drivers/rpmsg/qcom_smd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rpmsg/qcom_smd.c +1 -1
index 6ccfa12abd10..1957b27c4cf3 100644
@@ -1409,7 +1409,7 @@ static int qcom_smd_parse_edge(struct device *dev,
 	irq = irq_of_parse_and_map(node, 0);
 	if (!irq) {
 		dev_err(dev, "required smd interrupt missing\n");
-		ret = irq;
+		ret = -EINVAL;
 		goto put_node;
 	}
 
Signature · 1 line
2.35.1