scsi: mpi3mr: Return error if dma_alloc_coherent() fails
Subsystems (3)
PATCH 1/1 scsi: mpi3mr: Return error if dma_alloc_coherent() fails
Return -ENOMEM instead of success if dma_alloc_coherent() fails.
Fixes 43ca11005098 ("scsi: mpi3mr: Add support for PEL commands")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/mpi3mr/mpi3mr_fw.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/scsi/mpi3mr/mpi3mr_fw.c +6 -2
@@ -3754,8 +3754,10 @@ int mpi3mr_init_ioc(struct mpi3mr_ioc *mrioc) mrioc->pel_seqnum_virt =dma_alloc_coherent (&mrioc->pdev->dev, mrioc->pel_seqnum_sz, &mrioc->pel_seqnum_dma,GFP_KERNEL ); -if (!mrioc->pel_seqnum_virt) +if (!mrioc->pel_seqnum_virt) { + retval = -ENOMEM ; goto out_failed_noretry; + } } retval =mpi3mr_enable_events (mrioc);
@@ -3873,8 +3875,10 @@ int mpi3mr_reinit_ioc(struct mpi3mr_ioc *mrioc, u8 is_resume) mrioc->pel_seqnum_virt =dma_alloc_coherent (&mrioc->pdev->dev, mrioc->pel_seqnum_sz, &mrioc->pel_seqnum_dma,GFP_KERNEL ); -if (!mrioc->pel_seqnum_virt) +if (!mrioc->pel_seqnum_virt) { + retval = -ENOMEM ; goto out_failed_noretry; + } }if (mrioc->shost->nr_hw_queues > mrioc->num_op_reply_q) {
Signature · 1 line
2.35.1
Martin K. Petersen
AppliedDan,
Quoted 1 line
Return
-ENOMEMinstead of success ifdma_alloc_coherent()fails.
Applied to 5.19/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 3 lines · Dan Carpenter
Return
-ENOMEMinstead of success ifdma_alloc_coherent()fails.
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: mpi3mr: Return error if dma_alloc_coherent() fails
https://git.kernel.org/mkp/scsi/c/bc7896d31a92
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering