Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
PATCH 1/1 Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
From: Monish Kumar R <[email protected]>
--- drivers/usb/core/quirks.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/usb/core/quirks.c +3 -0
@@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {/* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /*DELL USB GEN2 */ + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM }, + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME }, { } /* terminating entry must be last */
};
Signature · 1 line
2.17.1
Quoted 12 lines · On 05.05.22 12:14, [email protected] wrote:
From: Monish Kumar R <[email protected]>
Signed-off-by Monish Kumar R <[email protected]>--- drivers/usb/core/quirks.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/usb/core/quirks.c +0
-0
drivers/usb/core/quirks.c static const struct usb_device_id usb_quirk_list[] = { · line 523
Quoted 9 lines
drivers/usb/core/quirks.c +3
-0@@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {/* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /*DELL USB GEN2 */ + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM }, + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
Hi,
could you please
1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or "reported on list"
Regards
Oliver
Greg KH
maintainerQuoted 12 lines · On Thu, May 05, 2022 at 03:44:59PM +0530, [email protected] wrote:
From: Monish Kumar R <[email protected]>
Signed-off-by Monish Kumar R <[email protected]>--- drivers/usb/core/quirks.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/usb/core/quirks.c +0
-0
drivers/usb/core/quirks.c static const struct usb_device_id usb_quirk_list[] = { · line 521
Quoted 7 lines
drivers/usb/core/quirks.c +3
-0@@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {/* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /*DELL USB GEN2 */ + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM }, + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
Are you sure you need both? How was this tested that both are actually set?
thanks,
greg k-h
Hi greg,
Are you sure you need both? How was this tested that both are actually set?
Quoted 1 line
Quoted 1 line
Yes, both
NO_LPMandRESET_RESUMEquirks were needed.
As the Dell usb gen2 device U1/U2 link states were failing when connected to type-C ports.
Disabling LPM helps to resolve U1/U2 link state failures. However, it leads to resetting the device multiple times. So, added with NO_LPM and RESET_RESUME usb quirks.
Tested multiple hotplug of Dell usb gen 2 device, it passed for all the cases.
Regards,
Monish Kumar R
-----Original Message-----
From: Greg KH <[email protected]>
Sent: 05 May 2022 17:47
To: R, Monish Kumar <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Rao, Abhijeet <[email protected]>
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
Quoted 12 lines · On Thu, May 05, 2022 at 03:44:59PM +0530, [email protected] wrote:
From: Monish Kumar R <[email protected]>
Signed-off-by Monish Kumar R <[email protected]>--- drivers/usb/core/quirks.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/usb/core/quirks.c +0
-0
drivers/usb/core/quirks.c static const struct usb_device_id · line 524
Quoted 10 lines
drivers/usb/core/quirks.c +4
-0@@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {/* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /*DELL USB GEN2 */ + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM }, + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME +},
Are you sure you need both? How was this tested that both are actually set?
thanks,
greg k-h