hte: fix off by one in hte_push_ts_ns()
Subsystems (2)
PATCH 1/2 hte: fix off by one in hte_push_ts_ns()
The &chip->gdev->ei[] array has chip->nlines elements so this > comparison needs to be >= to prevent an out of bounds access. The gdev->ei[] array is allocated in hte_register_chip().
--- drivers/hte/hte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hte/hte.c +1 -1
@@ -811,7 +811,7 @@ int hte_push_ts_ns(const struct hte_chip *chip, u32 xlated_id,if (!chip || !data || !chip->gdev)return -EINVAL ; -if (xlated_id > chip->nlines) +if (xlated_id >= chip->nlines)return -EINVAL ; ei = &chip->gdev->ei[xlated_id];
Signature · 1 line
2.35.1
PATCH 2/2 hte: uninitialized variable in hte_ts_get()
The "free_name" variable is sometimes used without being initialized.
31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem")
--- drivers/hte/hte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hte/hte.c +1 -1
@@ -572,7 +572,7 @@ int hte_ts_get(struct device *dev, struct hte_ts_desc *desc, int index)struct of_phandle_args args;u32 xlated_id;int ret; -bool free_name; +bool free_name = false;if (!desc)return -EINVAL ;
Signature · 1 line
2.35.1
Re: [PATCH 2/2] hte: uninitialized variable in hte_ts_get()
Quoted 21 lines · Dan Carpenter
The "
free_name" variable is sometimes used without being initialized.
31ab09b42188("drivers: Add hardware timestamp engine (HTE) subsystem")Signed-off-by Dan Carpenter <[email protected]>--- drivers/hte/hte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hte/hte.c +1
-1@@ -572,7 +572,7 @@ int hte_ts_get(struct device *dev, struct hte_ts_desc *desc, int index)struct of_phandle_args args;u32 xlated_id;int ret; -bool free_name; +bool free_name = false;if (!desc)return -EINVAL ;
good catch. Thanks.
Quoted 23 lines · Dan Carpenter
The &chip->gdev->ei[] array has
chip->nlineselements so this > comparison needs to be >= to prevent an out of bounds access. The gdev->ei[] array is allocated inhte_register_chip().Fixes 31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem")Signed-off-by Dan Carpenter <[email protected]>--- drivers/hte/hte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hte/hte.c +1
-1@@ -811,7 +811,7 @@ int hte_push_ts_ns(const struct hte_chip *chip, u32 xlated_id,if (!chip || !data || !chip->gdev)return -EINVAL ; -if (xlated_id > chip->nlines) +if (xlated_id >= chip->nlines)return -EINVAL ; ei = &chip->gdev->ei[xlated_id];