scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
Subsystems (3)
PATCH 1/1 scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
The bsg_setup_queue() function does not return NULL. It returns error pointers. Fix the check accordingly.
Fixes 4268fa751365 ("scsi: mpi3mr: Add bsg device support")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/mpi3mr/mpi3mr_app.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpi3mr/mpi3mr_app.c +1 -1
@@ -1540,7 +1540,7 @@ void mpi3mr_bsg_init(struct mpi3mr_ioc *mrioc) mrioc->bsg_queue =bsg_setup_queue (mrioc->bsg_dev,dev_name (mrioc->bsg_dev), mpi3mr_bsg_request,NULL ,0 ); -if (!mrioc->bsg_queue) { +if (IS_ERR (mrioc->bsg_queue)) {ioc_err (mrioc,"%s: bsg registration failed\n" ,dev_name (mrioc->bsg_dev)); goto err_setup_queue;
Signature · 1 line
2.35.1
Martin K. Petersen
AppliedDan,
Quoted 2 lines
The
bsg_setup_queue()function does not return NULL. It returns error pointers. Fix the check accordingly.
Applied to 5.19/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 4 lines · Dan Carpenter
The
bsg_setup_queue()function does not return NULL. It returns error pointers. Fix the check accordingly.
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
https://git.kernel.org/mkp/scsi/c/a25eafd13e5f
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering