Skip to contentSkip to conversation

ixgbe: correct SDP0 check of SFP cage for X550

PATCH New Skajewski 2 participants 2 messages May 10, 2022

lore
Share & tools
lore

Skajewski

NAK
#0 lore raw

PATCH v2 1/1 ixgbe: correct SDP0 check of SFP cage for X550

Hi Jeff,

Our analysis (using 0x15c4) showed that every time the cage is empty SDP indicates 0 and when cage is full it indicates 1. No matter what transceiver we used, from those we have.
The same happens even we don't use the device which fall into crosstalk fix e.g 0x15c2.

When proposed patch was applied, the devices are no longer able to negotiate speed. so basically this patch should not be accepted.

NACK

BR,
Piotr

#1 lore raw

PATCH v2 1/1 ixgbe: correct SDP0 check of SFP cage for X550

Quoted 4 lines · PiotrX

Hi Jeff,

Our analysis (using 0x15c4) showed that every time the cage is empty SDP indicates 0 and when cage is full it indicates 1. No matter what transceiver we used, from those we have.

Please wrap your sentences to 75 chars per line, people that read mailing lists will be grateful for that.

Quoted 4 lines

The same happens even we don't use the device which fall into crosstalk fix e.g 0x15c2.

When proposed patch was applied, the devices are no longer able to negotiate speed. so basically this patch should not be accepted.

We don't know what you're referring to. Please respond to the patch itself rather than carrying only the subject of the patch.

Quoted 9 lines

NACK

BR,
Piotr
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan