Skip to contentSkip to conversation

media: lirc: revert removal of unused feature flags

PATCH In review Sean Young 3 participants 3 messages May 25, 2022 – May 26, 2022

Subsystems (2)
lore
Share & tools
lore

Sean Young

author maintainer
#0 lore raw

PATCH 1/1 media: lirc: revert removal of unused feature flags

commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed feature flags which were never implemented, but they are still used by the lirc daemon went built from source.

Reinstate these symbols in order not to break the lirc build.

Cc Jiri Slaby <[email protected]>
Fixes b2a90f4fcb14 ("media: lirc: remove unused lirc features")
---
 include/uapi/linux/lirc.h | 7 +++++++
 1 file changed, 7 insertions(+)
include/uapi/linux/lirc.h +7 -0
index 23b0f2c8ba81..8d7ca7c6af42 100644
@@ -84,6 +84,13 @@
 #define LIRC_CAN_SEND(x) ((x)&LIRC_CAN_SEND_MASK)
 #define LIRC_CAN_REC(x) ((x)&LIRC_CAN_REC_MASK)
 
+/*
+ * Unused features. These features were never implemented, in tree or
+ * out of tree. These definitions are here so not to break the lircd build.
+ */
+#define LIRC_CAN_SET_REC_FILTER		0
+#define LIRC_CAN_NOTIFY_DECODE		0
+
 /*** IOCTL commands for lirc driver ***/
 
 #define LIRC_GET_FEATURES              _IOR('i', 0x00000000, __u32)
Signature · 1 line
2.36.1
#1 lore raw
Quoted 6 lines · Sean Young

commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed feature flags which were never implemented, but they are still used by the lirc daemon went built from source.

Reinstate these symbols in order not to break the lirc build.

Applied directly to my tree. Thanks,

Linus

#2 lore raw
Quoted 9 lines · Linus Torvalds
Quoted 6 lines · Sean Young

commit b2a90f4fcb14 ("media: lirc: remove unused lirc features") removed feature flags which were never implemented, but they are still used by the lirc daemon went built from source.

Reinstate these symbols in order not to break the lirc build.

Applied directly to my tree. Thanks,

Works for me, thanks.

Signature · 2 lines
js
suse labs