Skip to contentSkip to conversation

staging: rts5208: spi.c: prefer ftrace

PATCH In review Srivathsan Sivakumar 2 participants 2 messages May 17, 2022 – May 19, 2022 Staging

lore
Share & tools
lore

Srivathsan Sivakumar

author
#0 lore raw

PATCH 1/1 staging: rts5208: spi.c: prefer ftrace

fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by Srivathsan Sivakumar <[email protected]>
---
 drivers/staging/rts5208/spi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rts5208/spi.c +0 -1
index f1e9e80044ed..0d2d065508d3 100644
@@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 	spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
 	spi->write_en = srb->cmnd[6];
 
-	dev_dbg(rtsx_dev(chip), "%s: ", __func__);
 	dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
 	dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
 	dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 13 lines · Srivathsan Sivakumar

fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by Srivathsan Sivakumar <[email protected]>
---
 drivers/staging/rts5208/spi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rts5208/spi.c +0 -0
index f1e9e80044ed..0d2d065508d3 100644

drivers/staging/rts5208/spi.c int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) · line 465

Quoted 7 lines
drivers/staging/rts5208/spi.c +0 -1
@@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 	spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
 	spi->write_en = srb->cmnd[6];
 
-	dev_dbg(rtsx_dev(chip), "%s: ", __func__);
 	dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
 	dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
 	dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);

All three of the remaining ones should be on one line, right?

Can you fix this up and do that all at once?

thanks,

greg k-h