crypto: sun8i-ss - Fix error codes for dma_mapping_error()

PATCH In review Dan Carpenter 3 participants 3 messages May 18, 2022 – Jun 10, 2022

Subsystems (4)

Kernel janitors Crypto API Arm/Allwinner sunXi SoC support Allwinner crypto drivers

lore

Share & tools

lore

Dan Carpenter

author

2022-05-18 17:34 UTC #0 lore raw

PATCH 1/1 crypto: sun8i-ss - Fix error codes for dma_mapping_error()

If there is a dma_mapping_error() then return negative error codes. Currently this code returns success.

Fixes 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +4 -2

index ac417a6b39e5..845019bd9591 100644
@@ -586,7 +586,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
 			rctx->t_dst[k + 1].len = rctx->t_dst[k].len;
 		}
 		addr_xpad = dma_map_single(ss->dev, tfmctx->ipad, bs, DMA_TO_DEVICE);
-		if (dma_mapping_error(ss->dev, addr_xpad)) {
+		err = dma_mapping_error(ss->dev, addr_xpad);
+		if (err) {
 			dev_err(ss->dev, "Fail to create DMA mapping of ipad\n");
 			goto err_dma_xpad;
 		}

@@ -612,7 +613,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
 			goto err_dma_result;
 		}
 		addr_xpad = dma_map_single(ss->dev, tfmctx->opad, bs, DMA_TO_DEVICE);
-		if (dma_mapping_error(ss->dev, addr_xpad)) {
+		err = dma_mapping_error(ss->dev, addr_xpad);
+		if (err) {
 			dev_err(ss->dev, "Fail to create DMA mapping of opad\n");
 			goto err_dma_xpad;
 		}

Signature · 1 line

2.35.1

Corentin Labbe

maintainer Acked-by Tested-by on v1 1/1

2022-05-28 13:02 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

If there is a dma_mapping_error() then return negative error codes. Currently this code returns success.
Fixes 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Corentin Labbe <[email protected]>

Tested-by Corentin Labbe <[email protected]>

Tested-on: sun8i-a83t-bananapi-m3

Thanks

Herbert Xu

maintainer

2022-06-10 09:15 UTC #2 lore raw

In reply to Dan Carpenter

Quoted 8 lines · Dan Carpenter

If there is a dma_mapping_error() then return negative error codes. Currently this code returns success.
Fixes 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch applied. Thanks.

Signature · 3 lines

Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt